Your message dated Sun, 31 Aug 2014 00:20:48 +0000 with message-id <e1xnssy-00074v...@franck.debian.org> and subject line Bug#757289: fixed in stimfit 0.13.19-1 has caused the Debian Bug report #757289, regarding stimfit: Please update to use wxwidgets3.0 to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 757289: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=757289 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: stimfit Version: 0.13.15-1 Severity: important Tags: patch Tags: sid jessie User: freewx-ma...@lists.alioth.debian.org Usertags: wx3.0 wxpy3.0 Control: block 748169 by -1 Control: block 755757 by -1 We're aiming to migrate the archive to using wxwidgets3.0/wxpython3.0 instead of wxwidgets2.8, and hope to drop wxwidgets2.8 before jessie is released. Upstream, stimfit supports wx3.0, but it looks like there's a problem with this support under wxGTK - when __WXGTK__ is defined, src/stimfit/gui/app.cpp calls: wxMenuBar* menu_bar = CreateUnifiedMenuBar(); This defaults the doc parameter to NULL, and if wxCHECK_VERSION(2, 9, 0) is true (which it is for wx >= 2.9.0) we then try to call a method on doc, which segfaults: ((wxStfDoc*)doc)->SetFileMenu( file_menu ); I've added a simple fix for this, though it may not be the best way to address this. But with the patch, I can run stimfit, and it starts up OK and I can open a few dialogs. I don't have suitable data to actually test much functionality though. I'm happy to NMU this change if you wish me to - just let me know. Cheers, Ollydiff -Nru stimfit-0.13.15/debian/changelog stimfit-0.13.15/debian/changelog --- stimfit-0.13.15/debian/changelog 2014-02-17 02:23:17.000000000 +1300 +++ stimfit-0.13.15/debian/changelog 2014-08-07 09:42:21.000000000 +1200 @@ -1,3 +1,10 @@ +stimfit (0.13.15-1.1) unstable; urgency=medium + + * Non-maintainer upload. + * Update to use wxWidgets 3.0 - new patch: wx3.0-compat.patch + + -- Olly Betts <o...@survex.com> Thu, 07 Aug 2014 09:42:05 +1200 + stimfit (0.13.15-1) unstable; urgency=low * Fix half duration limits bug diff -Nru stimfit-0.13.15/debian/control stimfit-0.13.15/debian/control --- stimfit-0.13.15/debian/control 2014-02-17 02:23:17.000000000 +1300 +++ stimfit-0.13.15/debian/control 2014-08-07 09:14:27.000000000 +1200 @@ -3,13 +3,13 @@ Priority: optional Maintainer: Christoph Schmidt-Hieber <chris...@gmx.de> Uploaders: Yaroslav Halchenko <deb...@onerussian.com> -Build-Depends: debhelper (>= 7), libboost-dev (>= 1.40.0), python-all-dev (>= 2.6.6-3), python-numpy, libhdf5-dev, swig, python-wxgtk2.8 (>= 2.8.9), libwxgtk2.8-dev (>= 2.8.9), libfftw3-dev, liblapack-dev, chrpath, help2man, libbiosig-dev, libsuitesparse-dev, dh-autoreconf +Build-Depends: debhelper (>= 7), libboost-dev (>= 1.40.0), python-all-dev (>= 2.6.6-3), python-numpy, libhdf5-dev, swig, python-wxgtk3.0, python-wxgtk3.0-dev, libwxgtk3.0-dev, libfftw3-dev, liblapack-dev, chrpath, help2man, libbiosig-dev, libsuitesparse-dev, dh-autoreconf Standards-Version: 3.9.4 Homepage: http://www.stimfit.org Package: stimfit Architecture: any -Depends: ${shlibs:Depends}, ${misc:Depends}, ${python:Depends}, libbiosig-dev, libsuitesparse-dev, python-wxgtk2.8 (>= 2.8.9), python-numpy, python-matplotlib +Depends: ${shlibs:Depends}, ${misc:Depends}, ${python:Depends}, libbiosig-dev, libsuitesparse-dev, python-wxgtk3.0, python-numpy, python-matplotlib Recommends: python-scipy Description: Program for viewing and analyzing electrophysiological data Stimfit is a free, fast and simple program for viewing and analyzing diff -Nru stimfit-0.13.15/debian/patches/series stimfit-0.13.15/debian/patches/series --- stimfit-0.13.15/debian/patches/series 1970-01-01 12:00:00.000000000 +1200 +++ stimfit-0.13.15/debian/patches/series 2014-08-07 09:39:02.000000000 +1200 @@ -0,0 +1 @@ +wx3.0-compat.patch diff -Nru stimfit-0.13.15/debian/patches/wx3.0-compat.patch stimfit-0.13.15/debian/patches/wx3.0-compat.patch --- stimfit-0.13.15/debian/patches/wx3.0-compat.patch 1970-01-01 12:00:00.000000000 +1200 +++ stimfit-0.13.15/debian/patches/wx3.0-compat.patch 2014-08-07 09:42:00.000000000 +1200 @@ -0,0 +1,22 @@ +Description: Fix build with wx3.0 under __WXGTK__ + While stimfit has been ported to wx3.0, it seems this hasn't been tested + under __WXGTK__ as there doc is always NULL in wxStfApp::CreateUnifiedMenuBar + but we try to call methods on it for wx >= 2.9.0. + . + I don't understand the reason for all the conditionalisation on __WXGTK__, + __WXMSW__ etc, so this may not be the best fix, but it seems to work. +Author: Olly Betts <o...@survex.com> +Forwarded: no +Last-Update: 2014-08-06 + +--- stimfit-0.13.15.orig/src/stimfit/gui/app.cpp ++++ stimfit-0.13.15/src/stimfit/gui/app.cpp +@@ -605,7 +605,7 @@ wxMenuBar *wxStfApp::CreateUnifiedMenuBa + file_menu->AppendSeparator(); + file_menu->Append(wxID_EXIT); + +-#if (wxCHECK_VERSION(2, 9, 0)) ++#if !defined __WXGTK__ && (wxCHECK_VERSION(2, 9, 0)) + ((wxStfDoc*)doc)->SetFileMenu( file_menu ); + #else + GetDocManager()->FileHistoryLoad( *config );
--- End Message ---
--- Begin Message ---Source: stimfit Source-Version: 0.13.19-1 We believe that the bug you reported is fixed in the latest version of stimfit, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 757...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Christoph Schmidt-Hieber <chris...@gmx.de> (supplier of updated stimfit package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Sat, 30 Aug 2014 14:40:04 +0000 Source: stimfit Binary: stimfit stimfit-dbg python-stfio Architecture: source amd64 Version: 0.13.19-1 Distribution: unstable Urgency: low Maintainer: Christoph Schmidt-Hieber <chris...@gmx.de> Changed-By: Christoph Schmidt-Hieber <chris...@gmx.de> Description: python-stfio - Python module to read common electrophysiology file formats. stimfit - Program for viewing and analyzing electrophysiological data stimfit-dbg - Debug symbols for stimfit Closes: 757289 Changes: stimfit (0.13.19-1) unstable; urgency=low . * Update to use wxWidgets 3.0 (Closes: #757289) Checksums-Sha1: 5d72a77f79dd3b9a24d6c1c173f5592100492c3e 1463 stimfit_0.13.19-1.dsc e8e303203c46ffd5e9462878ccdc6380a0b750c8 2277860 stimfit_0.13.19.orig.tar.gz 0402673b3ac03c034609850b73d4dc0a94d2795e 7580 stimfit_0.13.19-1.debian.tar.xz 9007d7896fdf2d509d875a403ccbecc921324998 695060 stimfit_0.13.19-1_amd64.deb 31a17aa6a6b788885846da0c12ddb663a006381a 5341924 stimfit-dbg_0.13.19-1_amd64.deb ca98b638abee4fbd7761070d7e7bccc9349039ef 193094 python-stfio_0.13.19-1_amd64.deb Checksums-Sha256: 4f432951cd00ad0dfae5c132a008a8045b984137debe42361d32d411692752df 1463 stimfit_0.13.19-1.dsc 6e0d75d2a56b1d6fadb160f6b379d4b9407c41b7f57a1a29e7595654a82f55df 2277860 stimfit_0.13.19.orig.tar.gz 7976fd6102d19e77de95f46454e973f7e055522f4d7644b1e758817eddff75c2 7580 stimfit_0.13.19-1.debian.tar.xz df28bdd4113e4038d1e4080c843ac118d064b9b29b0108597c276c5be8442c04 695060 stimfit_0.13.19-1_amd64.deb 06001bf30235e7ea6cce8502c837d087e64dd94296a4aeac46771293359da2a9 5341924 stimfit-dbg_0.13.19-1_amd64.deb 9d2bd875afdff63bd8023d7e794977c6f961262b716771c15cb0b0c4f1ea2e86 193094 python-stfio_0.13.19-1_amd64.deb Files: 6b1807b215918a48175a3a851f84d166 695060 science optional stimfit_0.13.19-1_amd64.deb 56db9287cf3df8306661b5888c8b0e7b 5341924 debug extra stimfit-dbg_0.13.19-1_amd64.deb e99b4305d7cea0918f9d9cbdd84aae63 193094 python optional python-stfio_0.13.19-1_amd64.deb 09a61410b56014f1978e2ad414f1398d 1463 science optional stimfit_0.13.19-1.dsc fb825ee69cc4fa6689f3d5108f793f3c 2277860 science optional stimfit_0.13.19.orig.tar.gz 7481c09ce4796bc6e657a9836aa81cdd 7580 science optional stimfit_0.13.19-1.debian.tar.xz -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlQCZlMACgkQjRFFY3XAJMi7cACgmBlvNscXhwd5SMbSWRUeb8UD TXcAn1yU6ul6tQ6sEOxbPhYp7gwYoaQ/ =TwNe -----END PGP SIGNATURE-----
--- End Message ---
