Hi Gianfranco, On Sun, Aug 3, 2014 at 1:02 AM, Gianfranco Costamagna <costamagnagianfra...@yahoo.it> wrote:
> I see, the copy-pasted stripped the "tab" > > + #define HTCP_GET 1 > + #define HTCP_PUT 2 > + #define HTCP_DELETE 3 > > + #define HTCP_GET 1 > + #define HTCP_PUT 2 > + #define HTCP_DELETE 3 > > maybe next time I'll send the patch as attachment, to avoid this kind of > problems Ah, that explains it. Sorry, I didn't realize you already had a package up on mentors, please link it along with your debdiff next time. >> Aside from that, I have to say that I prefer Colin's proposed debdiff >> rather than yours; testing for older versions of curl rather than just >> getting rid of legacy code is the right approach and makes it easier >> to backport this package if desired. >> > > I have _nothing_ against Colin's approach (we already discussed it a little > on irc). > > But look at the define > ++#if (LIBCURL_VERSION_NUM < 0x070907) > > do you want to really to backport this package to a system with a curl > packaged in 2002??? > curl (7.9.7-1) unstable; urgency=low > Wed, 15 May 2002 21:09:19 +0200 > > > oldstable has already 7.21, so I don't see the point in maintaining such > code, moreover because upstream > just dropped it completely. > > So if you want to go with this approach is fine for me, since ubuntu already > took the patch. > > But I still think that having an upstream commit cherry-picked (alrady used > by fedora people) can help in maintaining the code > https://github.com/CESNET/gridsite/commit/2124d471f9fc1eed4bf5893ed2701350357c01af > > http://pkgs.fedoraproject.org/cgit/gridsite.git/tree/curl-opts.patch I'm still of the opinion that Colin's approach is a more technically-correct one, but either debdiff fixes this build failure, and ultimately it's up to gridsite's maintainer to choose the approach they prefer (once they start actively working on their package again). *shrugs* Regards, Vincent -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
