Your message dated Tue, 29 Jul 2014 05:18:30 +0000
with message-id <e1xbzny-0005ma...@franck.debian.org>
and subject line Bug#756282: fixed in downtimed 0.6-4
has caused the Debian Bug report #756282,
regarding broken systemd service file
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
756282: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756282
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: downtimed
Version: 0.6-3
Severity: serious
User: pkg-systemd-maintain...@lists.alioth.debian.org
Usertags: systemd-units

The systemd service file shipped with downtimed has several issues:
- it starts downtimed with -D, which disables database updates. Surely
  that's not what's expected. (Hence severity serious.)
- the daemon forks, but the service isn't configured properly for that
  and as a result the unit remains in state "inactive (dead)".
  Since there's no option to disable forking, it should use Type=forking
  and let systemd guess the right PID (which it does).
- the reload action, which was present in the sysv init script, has not
  been reimplemented.
- the description contains a typo, and doesn't really describe the
  service anyway.
- KillMode=process is not necessary, the default would be fine.
- After=network.target is not necessary.

I guess that this service file was adapted from ssh.service, which is
where the -D, KillMode and After come from... but as-is, it's broken.

Here's a better version:

| [Unit]
| Description=Downtime record keeper
| 
| [Service]
| EnvironmentFile=-/etc/default/downtimed
| ExecStart=/usr/sbin/downtimed $DOWNTIMED_OPTS
| ExecReload=/bin/kill -HUP $MAINPID
| Type=forking
| Restart=on-failure
| 
| [Install]
| WantedBy=multi-user.target

Thanks,

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (650, 'testing'), (600, 'unstable'), (550, 'experimental'), (550, 
'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-rc7-ore (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages downtimed depends on:
ii  init-system-helpers  1.19
ii  libc6                2.19-7
ii  lsb-base             4.1+Debian13

downtimed recommends no packages.

downtimed suggests no packages.

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: downtimed
Source-Version: 0.6-4

We believe that the bug you reported is fixed in the latest version of
downtimed, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 756...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jörg Frings-Fürst <deb...@jff-webhosting.net> (supplier of updated downtimed 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 28 Jul 2014 20:14:25 +0200
Source: downtimed
Binary: downtimed
Architecture: source amd64
Version: 0.6-4
Distribution: unstable
Urgency: medium
Maintainer: Jörg Frings-Fürst <deb...@jff-webhosting.net>
Changed-By: Jörg Frings-Fürst <deb...@jff-webhosting.net>
Description:
 downtimed  - monitor of downtime, shutdown, and crashes
Closes: 756282
Changes:
 downtimed (0.6-4) unstable; urgency=medium
 .
   * Move downtimed.service from debian/systemd/ to debian/.
   * Rewrite debian/downtimed.service (Closes: #756282):
     - Change Unit/Description to describe the service better.
     - Remove not required Unit/After=network.target.
     - Remove unnecessary Service/KillMode=process.
     - Add new Service/Type=forking so that systemd can handle downtimed.
     - Remove -D from Service/ExecStart to enable database updates.
       Thanks to Romain Francoise <rfranco...@debian.org>
Checksums-Sha1:
 01ed0efc01b8c238f4b248032257a3b6cc401069 1868 downtimed_0.6-4.dsc
 74bc1c6042fee89f640b5855bd9fc85487c12a71 108855 downtimed_0.6.orig.tar.gz
 5fdbf133f8341d4fad6f036d4d4e7f94cfcb1859 5736 downtimed_0.6-4.debian.tar.xz
 a308c7f38bc8c4da24591a26402e8a99a0daa0dc 23888 downtimed_0.6-4_amd64.deb
Checksums-Sha256:
 483840dc6d2bfea650888f65c49920aa22579c2b7f5d8fbb205e9f8ca4fc91d2 1868 
downtimed_0.6-4.dsc
 6da4ca239c84caed7723625d5db1f814344cec4c4c3c391d44e152bb97a07757 108855 
downtimed_0.6.orig.tar.gz
 b5b96e6fcabb6d6be81273a35889a3d15e351d088b389e419ea5e67972d71211 5736 
downtimed_0.6-4.debian.tar.xz
 4f8bf24a4603c5c36cce63a01e376aa289487103bca1be57e5ad10f8dd0e321f 23888 
downtimed_0.6-4_amd64.deb
Files:
 e26c728477136a370e94d1e1435527fb 23888 admin extra downtimed_0.6-4_amd64.deb
 3a503e204de58948a7ec7e10fb77f105 1868 admin extra downtimed_0.6-4.dsc
 e084f42bb845386dee3994fdfe06d3b2 108855 admin extra downtimed_0.6.orig.tar.gz
 73b5bf7700f4cf47e9383abbd9db59af 5736 admin extra downtimed_0.6-4.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJT1ywyAAoJEHQmOzf1tfkTLIMP/1IGUwReLXV23AZyjLB6JTzO
UeJy3Hjc2JrISZ0jiozt6JOEsakCulvLQBbg6kNHvHm8dJwGNlag5hD8D/I1dbb4
Q7EYvnZgUfME9fDnjISUUZgpFhZ6Z2c66Y17iml6VYMDC900/1arUwpJcnshCsDT
XoAiiJmXGqvdVzS/2BIdwBF8CAnrV5Unign+3M3o0ePSJXOzbyL0EoA1UAhc9hkw
Hxo0AfVWqpMlF1P3Pd3SWlspgn2KlLBgZLdBYyudJCtUGNpmfKmMQZpyhbDhRmc2
lJbpoQuqlrwQGjbCk/LLGqjKYS8puEHb2+PX7Ne8SwDJJjNPQcXOpTZZIXKhj55O
EJxMczLn1qQ3aWHpXttA8wVjWcpAjYW5l+F6ufmE3LG6XGIm8pWwjvONfQhtyLd8
caYhpUBu6FGVILqbygro2JEtMUvP3TQmZpZxjhn28QFVRU9OrFSWvwRIIOtHXdOA
A5UUZift7TYsvk2t5w/3aFEhnSy08pnosjlBUyQCuYFPDPMr+UxD+AjNIj3JrjHu
APFsTQOp7qnFq9rtasSSvXanxA1XpZ1Ed+ndrnLfP3vXKdL20EgCQ1FU9IgZTOLU
Oi8vyG/im/Sg2jc4wu5ksaMEaQlBNnOO5osfnJa6+ABhOOL9M/AqEyFo65sBsqrC
Vw2qJJyYDvxSuQwV4rjp
=L6pA
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to