Control: tag -1 + patch Hi Daniel,
Michael Tautschnig wrote: > During a rebuild of all Debian packages in a clean sid chroot (using > cowbuilder > and pbuilder) the build failed with the following error. > > [...] > /srv/jenkins-slave/workspace/sid-goto-cc-xdotool/xdotool-3.20130111.1/t/xdo_test_helper.rb:7:in > `setup' > =============================================================================== > E > =============================================================================== > Error: test_xdotool_exits_success_with_help_flag(XdotoolBasicTests) > EOFError: end of file reached This (very likely) can be fixed by moving write.close after all occurrences of reader.readline in t/xdo_test_helper.rb. Patch attached. I likely can NMU this, but due to upstream's time-consuming way to conduct the tests (one "sleep 300" per test as it seems, etc.), building the packages takes ages. So I can't promise to NMU this until the build finished. (But at least it's not immediately bailing out on the first test anymore, so I consider the attached patch as sufficient. :-) Please tell me if you'd prefer the NMU to go to unstable directly. Otherwise I'd target DELAYED/10 or such as it's "just" a FTBFS. Regards, Axel -- ,''`. | Axel Beckert <a...@debian.org>, http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE `- | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
Description: Fix failing test suite by calling close after read in xdo_test_helper.rb Author: Axel Beckert <a...@debian.org> Bug-Debian: https://bugs.debian.org/752974 Index: xdotool-3.20130111.1/t/xdo_test_helper.rb =================================================================== --- xdotool-3.20130111.1.orig/t/xdo_test_helper.rb 2013-01-10 18:52:07.000000000 +0100 +++ xdotool-3.20130111.1/t/xdo_test_helper.rb 2014-07-12 13:12:14.611829739 +0200 @@ -28,9 +28,9 @@ reader.close exec("exec xterm -T '#{@title}' -e 'echo $WINDOWID >& #{writer.fileno}; echo $$ >& #{writer.fileno}; #{cmd}'") end # xterm fork - writer.close @wid = reader.readline.to_i @shellpid = reader.readline.to_i + writer.close healthy = false while !healthy
signature.asc
Description: Digital signature