On 2014-06-23 10:11:20, Rowan Thorpe wrote: > I've attached an updated diff based on the below feedback. Because the changes > only affect this bug I won't update the diff on the other two bugs until this > version is confirmed good. > > On 14:20 Mon 23 Jun 2014, Niko Tyni wrote: >> On Mon, Jun 23, 2014 at 01:44:17PM +0300, Rowan Thorpe wrote: >> >> > Attached is a debdiff for several smokeping bugs. >> >> Thanks for your work. I'm not the maintainer (anymore), so just >> a couple of comments.
Thanks Rowan for those patches, and Niko for the review! I have factored in what I think are the latest patches from Rowan, and uploaded 2.6.9 to sid, so hopefully we'll have something to test in jessie soon enough before the freeze that we can get some more testing. Unfortunately, I mostly run Smokeping on production systems, which makes this quite difficult to test for me - I'm working a little bit in the blind here. I have nevertheless reviewed the patches, and they seem good. I'm a little hesitant about the documentation changes, because we're diverging From upstream - Rowan, could you look at submitting those patches upstream in a way that would work for both Debian and upstream? Ideally we'd cut down on the number of patches in debian/patches, not add to them. :) But of course, better to fix bugs than avoid patching... Finally, Rowan, if you are interested, you could join me in maintaining that package. Even if you are not a Debian maintainer, you can still work on the git repository through the Alioth service. See this page to get more information on how it works and getting an account: https://wiki.debian.org/Alioth/PackagingProject The workflow would basically be that you could commit the changes into git, and then I could review them and upload the changes in the Debian archive. Smokeping packaging definitely needs help. I did some work in getting it up to speed in the last 5 years, but the work is far from done, as can be seen in the debian/TODO file and the numerous bugs found in the Debian BTS. Sorry if I've been a little slow with the patches, I'll try to be swifter next time! :) A. -- Le péché est né avant la vertu, comme le moteur avant le frein. - Jean-Paul Sartre
pgpfmhj8rtIMh.pgp
Description: PGP signature
