On Thu, Jun 05, 2014 at 06:55:41PM +0200, Agustin Martin wrote:
> [#750069] On Sun, Jun 01, 2014 at 11:54:13AM +0200, Holger Levsen wrote:
> > Package: ingerman, iswiss
> > Version: 20131206-4
> > Severity: serious
> > 
> > during a test with piuparts I noticed your packages fail to upgrade from
> > wheezy. They installed fine in wheezy, then the upgrade to jessie fails.
> > 
> > From the attached logs (scroll to the bottom...):
> > 
> >   Unpacking ingerman (20131206-4) over (20120607-1) ...
> > [...]
> >   Setting up ingerman (20131206-4) ...
> >   /var/lib/dpkg/info/ingerman.postinst: 23: 
> > /var/lib/dpkg/info/ingerman.postinst: cannot create 
> > /var/lib/ispell/ngerman.compat: Directory nonexistent
> 
> [#750540] On Mi, 04 iun 14, 11:41:11, Matthias Urlichs wrote:
> 
> > ingerman (20131206-4) wird eingerichtet ...
> > /var/lib/dpkg/info/ingerman.postinst: 23: 
> > /var/lib/dpkg/info/ingerman.postinst: cannot create 
> > /var/lib/ispell/ngerman.compat: Directory nonexistent
> 
> [#750067] On Sun, Jun 01, 2014 at 11:48:55AM +0200, Holger Levsen wrote:
> >   Setting up aspell-de (20131206-4) ...
> >   touch: cannot touch '/var/lib/aspell/dontremove': No such file or 
> > directory
> 
> Hi, Roland and submitters,
> 
> I am replying to these three bugs together because they are tightly related
> (#750069 and #750540 are indeed the same, merging).

> 
> #750069 and #750540: They are fixed by upgrading build-depends to
>   dictionaries-common-dev (>= 1.23.3) to force up to date debhelper snippets
>   dealing harder with /var/lib/ispell availability in upgrades. See attached 
> 
>   0001-control-Build-Depend-on-dictionaries-common-dev-1.23.patch
> 
> #750067: aspell-de 20131206-4 uses a workaround to deal with the problem
>  behind #750069 and #750540 for aspell-de (see #748253), but when it tries
>  to write /var/lib/aspell it may have already been removed, leading to
>  #750067.
> 
>  If above 0001-control-Build-Depend-on-dictionaries-common-dev-1.23.patch
>  patch is applied the dontremove hack becomes meaningless and should be
>  removed, see attached
> 
>  0002-aspell-de.postinst-No-longer-use-dontremove-hack-Clo.patch

Really adding patches also for this bug report. Sorry for the noise, Roland.

-- 
Agustin
>From 294c948cb51fe6606e4f86adbd7e6334434349d6 Mon Sep 17 00:00:00 2001
From: Agustin Martin Domingo <agmar...@debian.org>
Date: Thu, 5 Jun 2014 17:30:13 +0200
Subject: [PATCH 1/2] control: Build-Depend on dictionaries-common-dev (>=
 1.23.3) (Closes: #750069, #750540).

This will force up to date debhelper snippets dealing harder with
/var/lib/$class availability.

Suggested changelog entry:

* debian/control: Build-Depend on dictionaries-common-dev (>= 1.23.3) to
  force up to date debhelper snippets dealing harder with
  /var/lib/$class availability (Closes: #750069, #750540).
---
 debian/control | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index 0e2ed24..cfe486d 100644
--- a/debian/control
+++ b/debian/control
@@ -5,7 +5,7 @@ Maintainer: Roland Rosenfeld <rol...@debian.org>
 Uploaders: Rene Engelhard <r...@debian.org>
 Standards-Version: 3.9.5
 Build-Depends-Indep: ispell (>= 3.1.20-12.1), hunspell, aspell (>= 0.60.5-2),
- dictionaries-common-dev (>= 1.23.2)
+ dictionaries-common-dev (>= 1.23.3)
 Build-Depends: debhelper (>= 9)
 Homepage: https://www.j3e.de/ispell/igerman98/
 
-- 
2.0.0

>From 225cf4cb7caa2ec9deb9a69da33cb1becd3d31dd Mon Sep 17 00:00:00 2001
From: Agustin Martin Domingo <agmar...@debian.org>
Date: Thu, 5 Jun 2014 17:34:40 +0200
Subject: [PATCH 2/2] aspell-de.postinst: No longer use dontremove hack
 (Closes: #750067).

dontremove hack tries to avoid /var/lib/$class deletion by writing a
flag in it, but that dir may have already been removed on upgrades.
Also, if dictionaries-common-dev build-depends is changed to
(>= 1.23.3) the hack is no longer meaningful.

Suggested changelog entry:

* aspell-de.postinst: No longer need to use the dontremove hack as we
  also create /var/lib/$class from postinst if needed and it may fail
  for some upgrades (Closes: #750067).
---
 debian/aspell-de.postinst | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/debian/aspell-de.postinst b/debian/aspell-de.postinst
index bb28889..e487876 100644
--- a/debian/aspell-de.postinst
+++ b/debian/aspell-de.postinst
@@ -33,18 +33,11 @@ case "$1" in
     ;;
 esac
 
-# Workaround for upgrading from older versions that contained
-# /var/lib/aspell and remove it on upgrade:
-touch /var/lib/aspell/dontremove
-
 # dh_installdeb will replace this with shell code automatically
 # generated by other debhelper scripts.
 
 #DEBHELPER#
 
-# And undo the workaround again:
-rm -f /var/lib/aspell/dontremove
-
 exit 0
 
 # vim:sw=4:
-- 
2.0.0

Reply via email to