Package: passwd
Version: 1:4.2-1
Severity: grave
Hi,
Recently, subuid/subgid support was added to passwd through a serie of patches.
In commit, 68fb7a, those patches were later merged to form the userns patch
present in HEAD. However, the package cannot be built due to an incorrect patch
to src/useradd.c -- an #endif is removed.
Attached is a patch to correct the patch :)
Also, on my quest to acquire the updated package, I noticed a couple of issues
with the project's FusionForge page:
- SCM points to an empty repository (pkg-shadow.git, cloneable);
- The actual repo is shadow.git (not mentionned, not cloneable);
I had to download a tarball of master to play with the package. Maybe it is on
purpose -- hiding the fire from kids?
And... I couldn't say all this without sincere thanks to the whole project,
Philippe
-- System information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 3.13-1-686-pae (SMP w/2 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages passwd depends on:
ii debianutils 4.4
ii libc6 2.18-4
ii libpam-modules 1.1.8-3
ii libpam0g 1.1.8-3
ii libselinux1 2.2.2-1
ii libsemanage1 2.2-1
passwd recommends no packages.
passwd suggests no packages.
-- no debconf information
diff --git a/debian/patches/1000_configure_userns b/debian/patches/1000_configure_userns
index 0cddc99..5cd39b6 100644
--- a/debian/patches/1000_configure_userns
+++ b/debian/patches/1000_configure_userns
@@ -51,17 +51,17 @@ Index: git/src/useradd.c
/*
* Get my name so that I can use it to report errors.
*/
-@@ -2023,9 +2027,10 @@
+@@ -2023,8 +2027,10 @@
is_shadow_grp = sgr_file_present ();
#endif
#ifdef ENABLE_SUBIDS
- is_sub_uid = sub_uid_file_present ();
- is_sub_gid = sub_gid_file_present ();
--#endif /* ENABLE_SUBIDS */
+ is_sub_uid = sub_uid_file_present () && !rflg &&
+ (!user_id || (user_id <= uid_max && user_id >= uid_min));
+ is_sub_gid = sub_gid_file_present () && !rflg &&
+ (!user_id || (user_id <= uid_max && user_id >= uid_min));
+ #endif /* ENABLE_SUBIDS */
get_defaults ();
