Package: dotlrn
Severity: serious
version: 2.5.0+dfsg-10
user: debian...@lists.debian.org
usertags: source-is-missing
severity: serious
X-Debbugs-CC:  ftpmas...@debian.org

Hi,

Your package seems to include some files that lack sources
in prefered forms of modification:

 * xinha library (need to be packaged)
 * tinymce (use packaged one)
 
List here:
packages/acs-templating/www/resources/xinha-nightly/XinhaCore.js
packages/acs-templating/www/resources/xinha-nightly/XinhaLoader.js
packages/theme-zen/www/resources/js/styleswitcher.js
packages/acs-templating/www/resources/xinha-nightly/examples/XinhaConfig.js
packages/acs-templating/www/resources/xinha-nightly/popups/popup.js
packages/lorsm/www/delivery-scorm/tigra/compressed/tree.js
packages/lorsm/www/delivery/tigra/compressed/tree.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/tiny_mce.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/tiny_mce_popup.js
packages/acs-templating/www/resources/xinha-nightly/modules/AboutBox/AboutBox.js
packages/acs-templating/www/resources/xinha-nightly/modules/ColorPicker/ColorPicker.js
packages/acs-templating/www/resources/xinha-nightly/modules/CreateLink/link.js
packages/acs-templating/www/resources/xinha-nightly/modules/CreateLink/pluginMethods.js
packages/acs-templating/www/resources/xinha-nightly/modules/Dialogs/XinhaDialog.js
packages/acs-templating/www/resources/xinha-nightly/modules/Dialogs/dialog.js
packages/acs-templating/www/resources/xinha-nightly/modules/Dialogs/popupwin.js
packages/acs-templating/www/resources/xinha-nightly/modules/FullScreen/full-screen.js
packages/acs-templating/www/resources/xinha-nightly/modules/Gecko/Gecko.js
packages/acs-templating/www/resources/xinha-nightly/modules/Gecko/paraHandlerBest.js
packages/acs-templating/www/resources/xinha-nightly/modules/GetHtml/DOMwalk.js
packages/acs-templating/www/resources/xinha-nightly/modules/GetHtml/TransformInnerHTML.js
packages/acs-templating/www/resources/xinha-nightly/modules/InlineStyler/InlineStyler.js
packages/acs-templating/www/resources/xinha-nightly/modules/InsertImage/insert_image.js
packages/acs-templating/www/resources/xinha-nightly/modules/InsertImage/pluginMethods.js
packages/acs-templating/www/resources/xinha-nightly/modules/InsertTable/insert_table.js
packages/acs-templating/www/resources/xinha-nightly/modules/InsertTable/pluginMethods.js
packages/acs-templating/www/resources/xinha-nightly/modules/InternetExplorer/InternetExplorer.js
packages/acs-templating/www/resources/xinha-nightly/modules/Opera/Opera.js
packages/acs-templating/www/resources/xinha-nightly/modules/WebKit/WebKit.js
packages/acs-templating/www/resources/xinha-nightly/plugins/Abbreviation/Abbreviation.js
packages/acs-templating/www/resources/xinha-nightly/plugins/CSS/CSS.js
packages/acs-templating/www/resources/xinha-nightly/plugins/CharCounter/CharCounter.js
packages/acs-templating/www/resources/xinha-nightly/plugins/CharacterMap/CharacterMap.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ContextMenu/ContextMenu.js
packages/acs-templating/www/resources/xinha-nightly/plugins/DynamicCSS/DynamicCSS.js
packages/acs-templating/www/resources/xinha-nightly/plugins/Equation/ASCIIMathML.js
packages/acs-templating/www/resources/xinha-nightly/plugins/Equation/Equation.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ExtendedFileManager/ExtendedFileManager.js
packages/acs-templating/www/resources/xinha-nightly/plugins/FindReplace/fr_engine.js
packages/acs-templating/www/resources/xinha-nightly/plugins/FormOperations/FormOperations.js
packages/acs-templating/www/resources/xinha-nightly/plugins/Forms/Forms.js
packages/acs-templating/www/resources/xinha-nightly/plugins/FullPage/FullPage.js
packages/acs-templating/www/resources/xinha-nightly/plugins/HorizontalRule/HorizontalRule.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ImageManager/ImageManager.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ImageManager/image-picker.js
packages/acs-templating/www/resources/xinha-nightly/plugins/InsertAnchor/InsertAnchor.js
packages/acs-templating/www/resources/xinha-nightly/plugins/InsertNote/InsertNote.js
packages/acs-templating/www/resources/xinha-nightly/plugins/InsertSnippet2/InsertSnippet2.js
packages/acs-templating/www/resources/xinha-nightly/plugins/LangMarks/LangMarks.js
packages/acs-templating/www/resources/xinha-nightly/plugins/Linker/pluginMethods.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ListType/ListType.js
packages/acs-templating/www/resources/xinha-nightly/plugins/PSFixed/PSFixed.js
packages/acs-templating/www/resources/xinha-nightly/plugins/PSLocal/PSLocal.js
packages/acs-templating/www/resources/xinha-nightly/plugins/PSLocal/gears_init.js
packages/acs-templating/www/resources/xinha-nightly/plugins/PSServer/PSServer.js
packages/acs-templating/www/resources/xinha-nightly/plugins/PasteText/PasteText.js
packages/acs-templating/www/resources/xinha-nightly/plugins/PersistentStorage/PersistentStorage.js
packages/acs-templating/www/resources/xinha-nightly/plugins/QuickTag/tag-lib.js
packages/acs-templating/www/resources/xinha-nightly/plugins/SaveSubmit/SaveSubmit.js
packages/acs-templating/www/resources/xinha-nightly/plugins/SmartReplace/SmartReplace.js
packages/acs-templating/www/resources/xinha-nightly/plugins/SpellChecker/spell-check-ui.js
packages/acs-templating/www/resources/xinha-nightly/plugins/Stylist/Stylist.js
packages/acs-templating/www/resources/xinha-nightly/plugins/SuperClean/SuperClean.js
packages/acs-templating/www/resources/xinha-nightly/plugins/SuperClean/pluginMethods.js
packages/acs-templating/www/resources/xinha-nightly/plugins/TableOperations/TableOperations.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ExtendedFileManager/assets/EditorContent.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ExtendedFileManager/assets/dialog.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ExtendedFileManager/assets/dragTableCols.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ExtendedFileManager/assets/editor.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ExtendedFileManager/assets/editorFrame.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ExtendedFileManager/assets/images.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ExtendedFileManager/assets/manager.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ExtendedFileManager/assets/wz_jsgraphics.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ImageManager/assets/EditorContent.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ImageManager/assets/dialog.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ImageManager/assets/editor.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ImageManager/assets/editorFrame.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ImageManager/assets/images.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ImageManager/assets/manager.js
packages/acs-templating/www/resources/xinha-nightly/plugins/ImageManager/assets/wz_jsgraphics.js
packages/acs-templating/www/resources/xinha-nightly/plugins/Linker/dTree/dtree.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/_template/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/advhr/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/advimage/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/advlink/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/autosave/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/bbcode/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/compat2x/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/contextmenu/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/devkit/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/directionality/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/emotions/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/example/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/flash/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/fullpage/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/fullscreen/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/iespell/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/inlinepopups/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/insertdatetime/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/layer/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/media/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/nonbreaking/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/noneditable/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/pagebreak/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/paste/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/preview/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/print/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/safari/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/save/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/searchreplace/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/spellchecker/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/style/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/tabfocus/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/table/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/template/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/visualchars/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/xhtmlxtras/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/plugins/zoom/editor_plugin.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/themes/advanced/editor_template.js
packages/acs-templating/www/resources/tinymce/jscripts/tiny_mce/themes/simple/editor_template.js

According to Debian Free Software Guidelines [1] (DFSG) §2: 
 "The program must include source code, and must allow distribution 
  in source code as well as compiled form.".

This could also constitute a license violation for some copyleft licenses such 
as the GNU GPL.

In order to solve this problem, you could:
1. repack the origin tarball adding the missing source to it.
2  add the source files to "debian/missing-sources" directory

Both way satisfies the requirement that we ship the source. Second option
might be preferable due to the following reasons [2]:
 - Upstream can do it too and you could even supply a patch to them, thus full 
filling our social contract [3], see particularly §2.
 - If source and non-source are in different locations, ftpmasters may
   miss the source and (needlessly) reject the package.
 - The source isn't duplicated in every .diff.gz/.debian.tar.* (though
   this only really matters for larger sources).

You could also ask debian-qa for more guidance.

[1] https://www.debian.org/social_contract.en.html#guidelines
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=736873#8
[3] https://www.debian.org/social_contract


--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to