Your message dated Fri, 17 Jan 2014 05:19:56 +0000 with message-id <e1w41qw-0004ru...@franck.debian.org> and subject line Bug#725383: fixed in osgearth 2.4.0+dfsg-6 has caused the Debian Bug report #725383, regarding osgearth: FTBFS on kfreebsd-*: SYS_gettid Linux-specific to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 725383: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=725383 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: osgearth Version: 2.4.0+dfsg-5 Tags: patch User: debian-...@lists.debian.org Usertags: kfreebsd X-Debbugs-Cc: debian-...@lists.debian.org Severity: serious Justification: fails to build from source (but built successfully in the past) Hi, osgearth fails to build on kfreebsd-* because it tries to directly use a Linux-specific syscall: https://buildd.debian.org/status/package.php?p=osgearth&suite=sid > cd /«BUILDDIR»/osgearth-2.4.0+dfsg/build/src/osgEarth && /usr/bin/c++ > -DOSGEARTH_LIBRARY -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DTIXML_USE_STL > -DosgEarth_EXPORTS -g -O2 -fstack-protector --param=ssp-buffer-size=4 > -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -fPIC > -isystem /usr/include/qt4 -isystem /usr/include/qt4/QtGui -isystem > /usr/include/qt4/QtCore -I/«BUILDDIR»/osgearth-2.4.0+dfsg/src > -I/usr/include/gdal -I/usr/include/curl -o > CMakeFiles/osgEarth.dir/ThreadingUtils.cpp.o -c > /«BUILDDIR»/osgearth-2.4.0+dfsg/src/osgEarth/ThreadingUtils.cpp > /«BUILDDIR»/osgearth-2.4.0+dfsg/src/osgEarth/ThreadingUtils.cpp: In function > 'unsigned int osgEarth::Threading::getCurrentThreadId()': > /«BUILDDIR»/osgearth-2.4.0+dfsg/src/osgEarth/ThreadingUtils.cpp:42:30: error: > 'SYS_gettid' was not declared in this scope > return (unsigned)::syscall(SYS_gettid); > ^ osgearth also knows how to use Windows and Mac OS X--specific syscalls to get a thread ID. This is not portable and there is nothing directly equivalent on FreeBSD, see: http://lists.freebsd.org/pipermail/freebsd-hackers/2010-June/031992.html A workaround may be to use pthread_self(), except that the exported getCurrentThreadId function has to return 'unsigned int'. On kfreebsd-amd64 a 64-bit pointer to a pthread_t is not absolutely guaranteed to be unique if truncated to 32 bits, but it is extremely likely, and certainly better than nothing... Please refer to attached patch which fixes package build at least. Thanks! -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: kfreebsd-amd64 (x86_64) Kernel: kFreeBSD 9.0-2-amd64-xenhvm Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dashIndex: osgearth-2.4.0+dfsg/src/osgEarth/ThreadingUtils.cpp =================================================================== --- osgearth-2.4.0+dfsg.orig/src/osgEarth/ThreadingUtils.cpp 2013-04-11 19:07:39.000000000 +0100 +++ osgearth-2.4.0+dfsg/src/osgEarth/ThreadingUtils.cpp 2013-10-04 22:04:38.898332000 +0100 @@ -20,9 +20,11 @@ #ifdef _WIN32 extern "C" unsigned long __stdcall GetCurrentThreadId(); -#else +#elif defined(__APPLE__) || defined(__LINUX__) # include <unistd.h> # include <sys/syscall.h> +#else +# include <pthread.h> #endif using namespace osgEarth::Threading; @@ -38,7 +40,10 @@ return (unsigned)::GetCurrentThreadId(); #elif __APPLE__ return ::syscall(SYS_thread_selfid); -#else +#elif __LINUX__ return (unsigned)::syscall(SYS_gettid); +#else + /* :XXX: this truncates to 32 bits, but better than nothing */ + return (unsigned)pthread_self(); #endif }
--- End Message ---
--- Begin Message ---Source: osgearth Source-Version: 2.4.0+dfsg-6 We believe that the bug you reported is fixed in the latest version of osgearth, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 725...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Bas Couwenberg <sebas...@xs4all.nl> (supplier of updated osgearth package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Thu, 16 Jan 2014 21:14:30 +0100 Source: osgearth Binary: osgearth osgearth-data libosgearth2 libosgearthannotation2 libosgearthfeatures2 libosgearthqt2 libosgearthsymbology2 libosgearthutil2 openscenegraph-plugin-osgearth libosgearth-dev Architecture: source amd64 all Version: 2.4.0+dfsg-6 Distribution: unstable Urgency: low Maintainer: Debian GIS Project <pkg-grass-de...@lists.alioth.debian.org> Changed-By: Bas Couwenberg <sebas...@xs4all.nl> Description: libosgearth-dev - osgEarth development files libosgearth2 - Dynamic 3D terrain rendering toolkit for OpenSceneGraph (shared l libosgearthannotation2 - Dynamic 3D terrain rendering toolkit for OpenSceneGraph (osgEarth libosgearthfeatures2 - Dynamic 3D terrain rendering toolkit for OpenSceneGraph (osgEarth libosgearthqt2 - Dynamic 3D terrain rendering toolkit for OpenSceneGraph (osgEarth libosgearthsymbology2 - Dynamic 3D terrain rendering toolkit for OpenSceneGraph (osgEarth libosgearthutil2 - Dynamic 3D terrain rendering toolkit for OpenSceneGraph (osgEarth openscenegraph-plugin-osgearth - OpenSceneGraph plugins for osgEarth osgearth - Dynamic 3D terrain rendering toolkit for OpenSceneGraph (binaries osgearth-data - Dynamic 3D terrain rendering toolkit for OpenSceneGraph (data) Closes: 725383 Changes: osgearth (2.4.0+dfsg-6) unstable; urgency=low . * Fix watch file, don't strip .0 from debian version. * Batchpatch the symbols files with recent build logs. * Add patch to fix FTBFS on kfreebsd-*, use pthread_self instead of gettid. Thanks Steven Chamberlain for the patch. (closes: #725383) * Add patch to use thr_self syscall on kFreeBSD. Thanks Petr Salinger, Robert Millan and Ed Maste for the advice. * Add patch to support libminizip as installed by the libkml package, but don't include KMZ support yet. * Change priority to optional. * Remove -1 from libkml build dependency version. * Update tinyxml lintian override to not be osgearth version specific. * Dump Standards-Version to 3.9.5, no changes required. * Update libgdal-dev build dependency. Checksums-Sha1: 9ea138d86fc7d2890c65dbb25288e8315df892f7 2174 osgearth_2.4.0+dfsg-6.dsc e6235b610420cd380382764a302030fd79c753c7 100352 osgearth_2.4.0+dfsg-6.debian.tar.xz 2abe8ff4b620e4fda98cef55f27950304831d5e0 125560 osgearth_2.4.0+dfsg-6_amd64.deb dad256323981742f71727b8e7c003e44a7289aba 3943640 osgearth-data_2.4.0+dfsg-6_all.deb e9cbdd74dd9976875edac258c0b787f7e3559f88 727072 libosgearth2_2.4.0+dfsg-6_amd64.deb 8b499800a09a4a939dbc7fa5586c4bb48be6711e 195826 libosgearthannotation2_2.4.0+dfsg-6_amd64.deb b45edb125ed555754fc919da2a8e031ec00ace01 248200 libosgearthfeatures2_2.4.0+dfsg-6_amd64.deb 512943774da3482849604da594042880f83b8850 184240 libosgearthqt2_2.4.0+dfsg-6_amd64.deb 48bc57b1821d63e2b8051951ac2e83d48d1e98a9 239976 libosgearthsymbology2_2.4.0+dfsg-6_amd64.deb 459b2de69502b78d458d7b2b28dc111b8f322d96 601028 libosgearthutil2_2.4.0+dfsg-6_amd64.deb e6fddde152f692c317640c2bfff0f96c2d9278d9 3400186 openscenegraph-plugin-osgearth_2.4.0+dfsg-6_amd64.deb a6556e5e81a39be80f228a4bdd0ea7620ebac613 436554 libosgearth-dev_2.4.0+dfsg-6_amd64.deb Checksums-Sha256: 71bff451792ebd92c0f8e93de84c020e5be5b27d97d66145e7a9f9e8979b50c1 2174 osgearth_2.4.0+dfsg-6.dsc ba2b89a6a2c8d5583b94ff0397af431f8756ee4336871223f14eba8caed395b5 100352 osgearth_2.4.0+dfsg-6.debian.tar.xz 047f8dbdf504b3a20205855271a75c862c1b1580e224135677ada6a3c49ba463 125560 osgearth_2.4.0+dfsg-6_amd64.deb 9040dea8b1cf275d9bfb4485e8c8f829fa988698a48b1f89e364ee436e7e8ea9 3943640 osgearth-data_2.4.0+dfsg-6_all.deb 8da2375717a37c5b5893b0585bde287e9805871fef0b4ab813950e03db7d6d21 727072 libosgearth2_2.4.0+dfsg-6_amd64.deb 56aebd67746867f023b3c2a39eafd002024d9539dcb585fe27e7c5d21d44306d 195826 libosgearthannotation2_2.4.0+dfsg-6_amd64.deb bafefaefe137d1a2736ce879c576cc8412613f5cfdace5cc98381b944b67281d 248200 libosgearthfeatures2_2.4.0+dfsg-6_amd64.deb 845344e381851093be587b7b08fe6a4af84ee966312fa55a93ca5cb66f23e873 184240 libosgearthqt2_2.4.0+dfsg-6_amd64.deb 23d72aaf65b81b9c919cfcf8fc24c8c05247d191836d83890c2053b1242f3da1 239976 libosgearthsymbology2_2.4.0+dfsg-6_amd64.deb 4d21fe579539b97828057fbd4083c95a36d9f1f8f6654d4396b241ea21bbff21 601028 libosgearthutil2_2.4.0+dfsg-6_amd64.deb e538b93d0f27399ed958c2cede147ba30ed90f43e13cbea44362f86ce1689c72 3400186 openscenegraph-plugin-osgearth_2.4.0+dfsg-6_amd64.deb 8c338dad3d0cd0fc2fb46238884b43e382a47b331cfd9fbdd67e0f8e4db03232 436554 libosgearth-dev_2.4.0+dfsg-6_amd64.deb Files: c651c719d49c9a86cad494ba770018d0 2174 devel optional osgearth_2.4.0+dfsg-6.dsc 09aa682d09ae65ebe25aa8a6a28d3237 100352 devel optional osgearth_2.4.0+dfsg-6.debian.tar.xz d95498cae0e9c69dc14bfbcb7387af2d 125560 devel optional osgearth_2.4.0+dfsg-6_amd64.deb 9d1d06c799def41dca648e3912aa3811 3943640 devel optional osgearth-data_2.4.0+dfsg-6_all.deb bf79932b1c77a2b49f55b92659733f86 727072 libs optional libosgearth2_2.4.0+dfsg-6_amd64.deb e87a2bfe149db686d14c8f16d1f9803d 195826 libs optional libosgearthannotation2_2.4.0+dfsg-6_amd64.deb 8d5a060736871b16ee3eb0b1c91f2e4e 248200 libs optional libosgearthfeatures2_2.4.0+dfsg-6_amd64.deb 7321922af5f0f5331696878217eaa5e5 184240 libs optional libosgearthqt2_2.4.0+dfsg-6_amd64.deb e6f5ce1fec32b189f3981f20802f5011 239976 libs optional libosgearthsymbology2_2.4.0+dfsg-6_amd64.deb 974fd2b0e15226e8709ae2374f98770b 601028 libs optional libosgearthutil2_2.4.0+dfsg-6_amd64.deb fe8a248445781cc2b2c5cfb0bed11317 3400186 devel optional openscenegraph-plugin-osgearth_2.4.0+dfsg-6_amd64.deb d629af128479eba9474cf6b1ec215366 436554 libdevel optional libosgearth-dev_2.4.0+dfsg-6_amd64.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlLYuIwACgkQYDBbMcCf01r63wCfeLutMX202ta863xWRtuoY/V6 fqUAn1jqA4B2t/q9gcMq6zXI8rXcrT06 =kWQ6 -----END PGP SIGNATURE-----
--- End Message ---
