Your message dated Sat, 28 Dec 2013 00:04:03 +0000
with message-id <e1vwhnr-0002ey...@franck.debian.org>
and subject line Bug#728647: fixed in pppoeconf 1.21
has caused the Debian Bug report #728647,
regarding missing dependencies on ifupdown and net-tools
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
728647: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=728647
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: pppoeconf
Version: 1.20
Severity: serious
Tags: patch
Hi
pppoeconf depends on ifupdown and net-tools (ifconfig) without
declaring an explicit dependency on either of these packages. Due to
ifupdown having switched its own reliance on net-tools to iproute2,
new jessie installs are particularly prone to this problem, as ifconfig
is no longer guaranteed to be available.
Rather than just declaring net-tools as a dependency, I've ported
pppoeconf to use iproute2 instead, thereby following ifupdown and
reducing the dependency chain as a whole. Existing configurations will
not be migrated to iproute2 automatically, as doing so would be a
policy violation, but existing -upgraded- installations should still
have net-tools/ ifconfig available (and pppoeconf will adapt it when
reconfiguring an interface).
I'll follow up this bug with a, tested, 2-patch patch series (which
also fixes the newly introduced i18n changes), once I receive the bug
number, but the changes are basically these:
*** Please apply the two patches mailed as follow-up to this bug, ***
*** rather than this patch which is only meant for demonstrating ***
*** the changes ***
--- a/debian/control
+++ b/debian/control
@@ -10,7 +10,7 @@ Standards-Version: 3.9.2
Package: pppoeconf
Architecture: all
-Depends: ${misc:Depends}, whiptail-provider | whiptail, ppp (>=
2.4.2+20040428-2) | pppoe (>= 3.0), ppp (>= 2.4.1.uus2-4), gettext-base (>=
0.13), sed (>= 3.95)
+Depends: ${misc:Depends}, whiptail-provider | whiptail, ppp (>=
2.4.2+20040428-2) | pppoe (>= 3.0), ppp (>= 2.4.1.uus2-4), gettext-base (>=
0.13), sed (>= 3.95), ifupdown (>= 0.7.44~), iproute2
Recommends: locales
Suggests: xdialog
Description: configures PPPoE/ADSL connections
--- a/pppoeconf
+++ b/pppoeconf
@@ -101,7 +101,7 @@ if test "$*" ; then
list="$*"
force_manual=1
else
- list=$( LANG=C /sbin/ifconfig -a | grep "Ethernet" | grep -v irlan | cut
-f1 -d" " )
+ list=$( LANG=C /bin/ip -f link -o addr list | awk
'/^[0-9]*\:.*link\/ether/{print $2}' | grep -v irlan | cut -f1 -d: )
fi
if test "$list" ; then
@@ -189,7 +189,7 @@ Webnetix:
fi
touch $TMP/pppoe.scan
- ifconfig $iface up
+ ip link set $iface up
($DISCOVERY_PROGRAM $mmm -A -I $iface > $TMP/$iface.pppoe ; rm
$TMP/pppoe.scan) &
( time=0 ; while test -f $TMP/pppoe.scan ; do time=`expr $time +
6`; echo $time; sleep 1; done ) | $DIALOG --title "$title" --gauge "$text
$mmode" 10 60 0
@@ -253,9 +253,12 @@ Continue with configuration?')
# interface activation code - this sucks here, pppd plugin should do
it as needed
#sed -i -e "s,pre-up
/sbin/ifconfig[[:space:]]\+[^[:space:]]\+[[:space:]]\+up.#.line.maintained.by.pppoeconf,pre-up
/sbin/ifconfig $ifacenocomma up # line maintained by pppoeconf," $INTFILE
# FIXME: Make sure that it gets added to correct iface stanza! (Because
it's not always added above)
- PATTERN_PREUP_IFACE="pre-up
/sbin/ifconfig[[:space:]]\+[^[:space:]]\+[[:space:]]\+up.#.line.maintained.by.pppoeconf"
- REPLACE_PREUP_IFACE="pre-up /sbin/ifconfig $ifacenocomma up # line
maintained by pppoeconf"
- if grep -q "$PATTERN_PREUP_IFACE" $INTFILE; then
+ PATTERN_PREUP_IFACE_LEGACY="pre-up
/sbin/ifconfig[[:space:]]\+[^[:space:]]\+[[:space:]]\+up.#.line.maintained.by.pppoeconf"
+ PATTERN_PREUP_IFACE="pre-up /bin/ip link
set[[:space:]]\+[^[:space:]]\+[[:space:]]\+up.#.line.maintained.by.pppoeconf"
+ REPLACE_PREUP_IFACE="pre-up /bin/ip link set $ifacenocomma up # line
maintained by pppoeconf"
+ if grep -q "$PATTERN_PREUP_IFACE_LEGACY" $INTFILE; then
+ sed -i -e "s,$PATTERN_PREUP_IFACE_LEGACY,$REPLACE_PREUP_IFACE,"
$INTFILE
+ elif grep -q "$PATTERN_PREUP_IFACE" $INTFILE; then
sed -i -e "s,$PATTERN_PREUP_IFACE,$REPLACE_PREUP_IFACE," $INTFILE
else
sed -i -e "s,[^#]*\(iface dsl-provider.*\),\1\n$REPLACE_PREUP_IFACE,"
$INTFILE
@@ -461,7 +464,7 @@ Note that this situation is not expected and you should
consider submitting a bu
cd /
pon dsl-provider
title=$(gettext 'CONNECTION INITIATED')
- text=$(gettext 'The DSL connection has been triggered. You can use the
"plog" command to see the status or "ifconfig ppp0" for general interface
info.')
+ text=$(gettext 'The DSL connection has been triggered. You can use the
"plog" command to see the status or "ip addr show ppp0" for general interface
info.')
$DIALOG --title "$title" --clear --msgbox "$text" 10 60
;;
1)
*** Please apply the two patches mailed as follow-up to this bug, ***
*** rather than this patch which is only meant for demonstrating ***
*** the changes ***
Regards
Stefan Lippers-Hollmann
-- System Information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.11-6.slh.3-aptosid-amd64 (SMP w/8 CPU cores; PREEMPT)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
signature.asc
Description: This is a digitally signed message part.
--- End Message ---
--- Begin Message ---
Source: pppoeconf
Source-Version: 1.21
We believe that the bug you reported is fixed in the latest version of
pppoeconf, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 728...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Gregory Colpart <r...@debian.org> (supplier of updated pppoeconf package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160
Format: 1.8
Date: Fri, 27 Dec 2013 03:03:25 +0100
Source: pppoeconf
Binary: pppoeconf
Architecture: source all
Version: 1.21
Distribution: unstable
Urgency: low
Maintainer: Gregory Colpart <r...@debian.org>
Changed-By: Gregory Colpart <r...@debian.org>
Description:
pppoeconf - configures PPPoE/ADSL connections
Closes: 697939 728647 732174 732192
Changes:
pppoeconf (1.21) unstable; urgency=low
.
[ Stefan Lippers-Hollmann ]
* Add missing package dependency on ifupdown.
* Follow ifupdown and switch from net-tools' ifconfig to iproute2, adapt
dependencies accordingly (Closes: #728647).
.
[ Gregory Colpart ]
* Warn about changes in pap/chap-secrets files and comment old lines instead
of remove (Closes: #697939).
* Update to standards version 3.9.5, no further required changes.
* Add build-indep and build-arch targets (fix lintian warning).
* Update POT and PO files.
* Update japanese translation (Closes: #732174)
Thanks to Kenshi Muto <km...@debian.org>
* Update russian translation (Closes: #732192)
Thanks to Yuri Kozlov <yu...@komyakino.ru>
* Update slovene language
Thanks to Jure Cuhalev <gand...@owca.info>
Checksums-Sha1:
c5c0cbc7039b27c0b1ad04c4c5f08884b7423e69 927 pppoeconf_1.21.dsc
ebb663ddece35b12c1d562289d5c61164e9af9a9 51889 pppoeconf_1.21.tar.gz
4f21b0611b49794e4b338d21198d94bc4ec7662e 40252 pppoeconf_1.21_all.deb
Checksums-Sha256:
be2b391105fa499985365989b7eb12ac88511b27bead9d1d31d7ce9c8ba1ff9e 927
pppoeconf_1.21.dsc
8064e943edccc2c68b555c83a7dd2811952181993b3f97fc45257581a43ff581 51889
pppoeconf_1.21.tar.gz
a559761f1b40e8e3868198f87257d68c425858036069f922ea17ef7599cb95e1 40252
pppoeconf_1.21_all.deb
Files:
da498d5a30d1094d8cb8f5556c612495 927 net optional pppoeconf_1.21.dsc
2971d1038839e221a0917fd86c62b29a 51889 net optional pppoeconf_1.21.tar.gz
8fdf64048d8075ff957b3a17efea0249 40252 net optional pppoeconf_1.21_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEAREDAAYFAlK+FGsACgkQMhdcDcECeg6LhACfSLxPVciRA1UysLsuvvu+GP9s
7uoAniebwkSVSZfbdtQcCfR+2DeuED5I
=rR3R
-----END PGP SIGNATURE-----
--- End Message ---
