Your message dated Fri, 29 Nov 2013 22:18:34 +0000 with message-id <e1vmwoq-0005w7...@franck.debian.org> and subject line Bug#730490: fixed in apt 0.9.13.1 has caused the Debian Bug report #730490, regarding apt: invoking dpkg no longer respects APT::Keep-Fds to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 730490: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=730490 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: apt Version: 0.9.13 Severity: grave Justification: breaks d-i Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu ubuntu-patch trusty This bug originated as: https://bugs.launchpad.net/bugs/1254696 The ExecFork refactoring in 0.9.13~exp1 broke d-i, because APT::Keep-Fds is no longer respected when invoking dpkg. Here's a patch, although perhaps you want this laid out in some way that duplicates less code; however I couldn't readily see how to do that without just undoing the refactoring. I spent a couple of hours trying to write an integration test that exercises the whole debconf-apt-progress path. I failed because that requires actually executing the postinst in a test package, which requires chrooting because we use dpkg --root, and I couldn't get fakechroot to do the right thing. Suggestions gratefully appreciated if you think this is important. * Fix two subprocess calls to continue to honour APT::Keep-Fds (LP: #1254696). diff -Nru apt-0.9.13~exp1ubuntu1/apt-pkg/deb/dpkgpm.cc apt-0.9.13~exp1ubuntu2/apt-pkg/deb/dpkgpm.cc --- apt-0.9.13~exp1ubuntu1/apt-pkg/deb/dpkgpm.cc 2013-11-23 08:18:03.000000000 +0000 +++ apt-0.9.13~exp1ubuntu2/apt-pkg/deb/dpkgpm.cc 2013-11-25 13:18:34.000000000 +0000 @@ -416,6 +416,18 @@ // Create the pipes std::set<int> KeepFDs; + Configuration::Item const *KeepFDsOpts = _config->Tree("APT::Keep-Fds"); + if (KeepFDsOpts != 0 && KeepFDsOpts->Child != 0) + { + KeepFDsOpts = KeepFDsOpts->Child; + for (; KeepFDsOpts != 0; KeepFDsOpts = KeepFDsOpts->Next) + { + if (KeepFDsOpts->Value.empty() == true) + continue; + int fd = atoi(KeepFDsOpts->Value.c_str()); + KeepFDs.insert(fd); + } + } int Pipes[2]; if (pipe(Pipes) != 0) return _error->Errno("pipe","Failed to create IPC pipe to subprocess"); @@ -1378,6 +1390,18 @@ // now run dpkg d->progress->StartDpkg(); std::set<int> KeepFDs; + Configuration::Item const *KeepFDsOpts = _config->Tree("APT::Keep-Fds"); + if (KeepFDsOpts != 0 && KeepFDsOpts->Child != 0) + { + KeepFDsOpts = KeepFDsOpts->Child; + for (; KeepFDsOpts != 0; KeepFDsOpts = KeepFDsOpts->Next) + { + if (KeepFDsOpts->Value.empty() == true) + continue; + int fd = atoi(KeepFDsOpts->Value.c_str()); + KeepFDs.insert(fd); + } + } KeepFDs.insert(fd[1]); pid_t Child = ExecFork(KeepFDs); if (Child == 0) Thanks, -- Colin Watson [cjwat...@ubuntu.com]
--- End Message ---
--- Begin Message ---Source: apt Source-Version: 0.9.13.1 We believe that the bug you reported is fixed in the latest version of apt, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 730...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Michael Vogt <m...@debian.org> (supplier of updated apt package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Fri, 29 Nov 2013 20:50:17 +0100 Source: apt Binary: apt libapt-pkg4.12 libapt-inst1.5 apt-doc libapt-pkg-dev libapt-pkg-doc apt-utils apt-transport-https Architecture: source all amd64 Version: 0.9.13.1 Distribution: unstable Urgency: low Maintainer: APT Development Team <de...@lists.debian.org> Changed-By: Michael Vogt <m...@debian.org> Description: apt - commandline package manager apt-doc - documentation for APT apt-transport-https - https download transport for APT apt-utils - package management related utility programs libapt-inst1.5 - deb package format runtime library libapt-pkg-dev - development files for APT's libapt-pkg and libapt-inst libapt-pkg-doc - documentation for APT development libapt-pkg4.12 - package management runtime library Closes: 709560 720597 730490 730795 Changes: apt (0.9.13.1) unstable; urgency=low . [ Colin Watson ] * fix "apt-get --purge build-dep" (closes: #720597) * fix regression that APT::Keep-Fds is not honored (closes: #730490) . [ Michael Vogt ] * add "-f" option to "build-dep" as sbuild is using it to fix regression with cross-building (LP: #1255806) * add autopkgtest support for the integration testsuite * merge mvo/feature/short-list * merge mvo/feature/edit-sources * fix segfault in pkgDepCache::SetCandidateRelease() (closes: #709560) * reset terminal on error (closes: #730795) * fix apport report writing (LP: #1254499) Checksums-Sha1: 2ebaa317532e6aa627f69fc5f042118741eea3bb 1640 apt_0.9.13.1.dsc ac9ce9a61a24045c40568fd794a6f64d3af445e4 3435299 apt_0.9.13.1.tar.gz b4318f00b1dad3755695810fef355323f4853414 267222 apt-doc_0.9.13.1_all.deb 6a9ecb5bea987967b13329a0f9cda0bb4a64c823 581064 libapt-pkg-doc_0.9.13.1_all.deb c2df2838c4a70b0aab370bb39bc8b7da3ee559fa 725344 libapt-pkg4.12_0.9.13.1_amd64.deb 945129d528c3e2d7cd2743e1372b194f33121c09 158476 libapt-inst1.5_0.9.13.1_amd64.deb b6a063e6178307e6b32a85cbb346fa48f09ea3fd 1049610 apt_0.9.13.1_amd64.deb ad66bfa98d1425299a4ec859f23ef6720e86bc50 181454 libapt-pkg-dev_0.9.13.1_amd64.deb adb90a54c96494d7408847edef0bda7f8ee4bf39 346686 apt-utils_0.9.13.1_amd64.deb c5bb56d95d01da1c76ad53378185125a3f2f976d 125332 apt-transport-https_0.9.13.1_amd64.deb Checksums-Sha256: 6d8b9c63e84f0b2b3e4a8482e5082b73af666ffd81d3550535a9d7f22e821b27 1640 apt_0.9.13.1.dsc c13b6857d70c46c55dd83b19bc1eebcff332e350fa1ed1374f2bbc1bf978d827 3435299 apt_0.9.13.1.tar.gz 3b6323d0d1ecccbc92a7964ce9314e9ba8591afa773bfdea479296e2ed9c6849 267222 apt-doc_0.9.13.1_all.deb 2263fae0d52d8df9bee3cce92d2368db93df651cf98e3df22619c5afaaf774f0 581064 libapt-pkg-doc_0.9.13.1_all.deb 8d1304052fff2fab937e9d0a05a560352e590fbaa91a3406ca349b05d5ba4b75 725344 libapt-pkg4.12_0.9.13.1_amd64.deb 7cc2ca4d53fc6bcc857370aebf55329d7aaf924d198421bdf0697c5f25940a21 158476 libapt-inst1.5_0.9.13.1_amd64.deb 5d27d565f49b1d5d808a7975249f1d8237c022364c0f1c4a42ae9342de27a886 1049610 apt_0.9.13.1_amd64.deb ca043c80128b35659904a7c3aac4c443266cdac10b2947b2ead9ff878337bab9 181454 libapt-pkg-dev_0.9.13.1_amd64.deb 0fecd051593ca9e5e9dc7817ae1a7484f1ac8479f4e5c3a7d1f0d3e3c140c819 346686 apt-utils_0.9.13.1_amd64.deb 4f172363ef2e3360b7cc97bd871cffd892872f62f121cdd47982ec5bfcc50f90 125332 apt-transport-https_0.9.13.1_amd64.deb Files: da3b02dd97ace2a41df138f2bd3103ee 1640 admin important apt_0.9.13.1.dsc c7585d51e78095c538edaf01ba74e595 3435299 admin important apt_0.9.13.1.tar.gz 517c61b142969beb9bddfc6fe570070a 267222 doc optional apt-doc_0.9.13.1_all.deb 273174b4cfff3ec12a351c83b47c073b 581064 doc optional libapt-pkg-doc_0.9.13.1_all.deb 955a2f4c00c865f631599fbcaddcf385 725344 libs important libapt-pkg4.12_0.9.13.1_amd64.deb f31416cc22dcf867d1f0584e40ec8dcb 158476 libs important libapt-inst1.5_0.9.13.1_amd64.deb 78b0dd842740c5f1dbce809a80d092aa 1049610 admin important apt_0.9.13.1_amd64.deb dba8b797985c938d4d1b9adf5c405a37 181454 libdevel optional libapt-pkg-dev_0.9.13.1_amd64.deb 48aacb981b27c2a39e80bb23d57dc766 346686 admin important apt-utils_0.9.13.1_amd64.deb ef4a43a2135f0b2eef3c56cfb6abc0b9 125332 admin optional apt-transport-https_0.9.13.1_amd64.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEYEARECAAYFAlKY/vAACgkQliSD4VZixzTrQACfemVKRVjJKw8Q82unfCjXRbak 9nQAn0F8ujVGKS/UHodpRkZP+8g3hxKw =lQyY -----END PGP SIGNATURE-----
--- End Message ---
