Hi, I don't see that any major refactoring is needed, but rather the default assumed flags are unsafe, although changing them might be incompatible with some scripts/applications using pwgen.
CVE-2013-4440 non-tty passwords are trivially weak by default should ideally stop using -0A by default in non-tty mode, but could maybe warn/fail if the caller doesn't override with -nc, which has been recommended in the man page until now. CVE-2013-4441 Phonemes mode has heavy bias and is enabled by default assume -s by default? I think it uses the same character set but with more entropy, so only a human user should notice any difference at all. As long as the -s flag is set *before* parsing command line flags, it does not conflict with -0 -A -B or -v. CVE-2013-4442 Silent fallback to insecure entropy consider using /dev/random instead of /dev/urandom? (Debian bug #672241) and in any case fail if it cannot be read CVE-2013-4443 Secure mode has bias towards numbers and uppercase letters probably the least serious issue; -n guarantees at least one numeral, -c guarantees at least one capital, instead of being a completely random selection. Sometimes necessary if the password consumer enforces such a rule. Regards, -- Steven Chamberlain ste...@pyro.eu.org -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
