Your message dated Wed, 09 Oct 2013 21:19:49 +0000
with message-id <e1vu1ab-0003cd...@franck.debian.org>
and subject line Bug#722924: fixed in xfce4-taskmanager 1.0.0-4
has caused the Debian Bug report #722924,
regarding xfce4-taskmanager: FTBFS on kfreebsd-*
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
722924: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=722924
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: xfce4-taskmanager
Version: 1.0.0-3
Severity: serious
Tags: patch
Justification: fails to build from source (but built successfully in the past)
User: debian-...@lists.debian.org
Usertags: kfreebsd

Hi,

xfce4-taskmanager 1.0.0-3 fails to build on GNU/kFreeBSD [1][2].

The problem is that the existing patch 01_configure-kfreebsd.patch
changes only configure, so the autoreconf'ing during build introduced
in 1.0.0-3 causes the regeneration of configure which tosses away the
changes previously done.

While I was there, other than patching the right file (configure.ac
instead of configure) I made it use the "freebsd" OS implementation,
patching a couple of build issues (one upstream and one not) with it.
Attached there is:
- kfreebsd.diff (which replaces entirely 01_configure-kfreebsd.patch)
- debian.diff (changes for the debian directory only)

[1] 
https://buildd.debian.org/status/fetch.php?pkg=xfce4-taskmanager&arch=kfreebsd-i386&ver=1.0.0-3&stamp=1376828879
[2] 
https://buildd.debian.org/status/fetch.php?pkg=xfce4-taskmanager&arch=kfreebsd-amd64&ver=1.0.0-3&stamp=1376829790

Thanks,
-- 
Pino
Author: Pino Toscano <toscano.p...@tiscali.it>
Description: Enable building on kFreeBSD
 Make use of the "freebsd" OS implementation, as the kernel is the same.
 .
 Also, provide build fixes for task-manager-freebsd.c:
 - include <sys/vmmeter.h>, needed with FreeBSD >= 9.0 (see also the upstream
   bug #8081)
 - NZERO is not provided by kfreebsd-kernel-headers, as already provided by
   limits.h but only when _XOPEN_SOURCE is requested (and it is not in this
   case); make use of sysconf to query that value instead
Last-Update: 2013-9-14
Forwarded: no

--- a/configure.ac
+++ b/configure.ac
@@ -92,7 +92,7 @@ if test x"$ac_skel" = x"yes"; then
 	ac_os_implementation="skel"
 else
 	case "$target_os" in
-		freebsd*)
+		freebsd*|kfreebsd*-gnu)
 		ac_os_implementation="freebsd"
 		AC_CHECK_LIB([kvm], [kvm_openfiles])
 		AC_CHECK_HEADERS([fcntl.h kvm.h paths.h pwd.h sys/param.h sys/proc.h \
--- a/src/task-manager-freebsd.c
+++ b/src/task-manager-freebsd.c
@@ -18,6 +18,7 @@
 #include <fcntl.h>
 #include <paths.h>
 #include <unistd.h>
+#include <sys/vmmeter.h>
 
 #include <glib.h>
 
@@ -104,6 +105,7 @@ get_task_details (kvm_t *kd, struct kinf
 	struct passwd *pw;
 	char **argv;
 	int i;
+	long nzero = sysconf (_SC_NZERO);
 
 	task->pid = kp->ki_pid;
 	task->ppid = kp->ki_ppid;
@@ -168,9 +170,9 @@ get_task_details (kvm_t *kd, struct kinf
 	i++;
 	if (!(kp->ki_sflag & PS_INMEM))
 		task->state[i++] = 'W';
-	if (kp->ki_nice < NZERO)
+	if (kp->ki_nice < nzero)
 		task->state[i++] = '<';
-	else if (kp->ki_nice > NZERO)
+	else if (kp->ki_nice > nzero)
 		task->state[i++] = 'N';
 	if (kp->ki_flag & P_TRACED)
 		task->state[i++] = 'X';
--- a/debian/control
+++ b/debian/control
@@ -6,7 +6,8 @@ Uploaders: Yves-Alexis Perez <corsac@deb
  Lionel Le Folgoc <mrpo...@gmail.com>
 Build-Depends: debhelper (>= 9), libgtk2.0-dev (>= 2.12.0),
  libcairo2-dev (>= 1.5.0), libwnck-dev (>= 2.0), intltool, dh-autoreconf,
- xfce4-dev-tools
+ xfce4-dev-tools,
+ libkvm-dev [kfreebsd-any]
 Standards-Version: 3.9.4
 Homepage: http://goodies.xfce.org/
 Vcs-Svn: svn://anonscm.debian.org/pkg-xfce/goodies/trunk/xfce4-taskmanager/

--- End Message ---
--- Begin Message ---
Source: xfce4-taskmanager
Source-Version: 1.0.0-4

We believe that the bug you reported is fixed in the latest version of
xfce4-taskmanager, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 722...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Yves-Alexis Perez <cor...@debian.org> (supplier of updated xfce4-taskmanager 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 09 Oct 2013 22:47:11 +0200
Source: xfce4-taskmanager
Binary: xfce4-taskmanager
Architecture: source amd64
Version: 1.0.0-4
Distribution: unstable
Urgency: low
Maintainer: Debian Xfce Maintainers <pkg-xfce-de...@lists.alioth.debian.org>
Changed-By: Yves-Alexis Perez <cor...@debian.org>
Description: 
 xfce4-taskmanager - process manager for the Xfce4 Desktop Environment
Closes: 722924
Changes: 
 xfce4-taskmanager (1.0.0-4) unstable; urgency=low
 .
   [ Jackson Doak ]
   * debian/patches:
     - update 01_configure-kfreebsd to fix FTBFS on kFreeBSD.    closes: #722924
   * debian/control:
     - build-depend on libkvm-dev [kfreebsd-any]
     - Make homepage more specific
     - Extend description
   * debian/rules:
     - Use disable-silent-rules
Checksums-Sha1: 
 cc2a347d12244526105e07a5bd55f75bc7dee915 1894 xfce4-taskmanager_1.0.0-4.dsc
 2f32abbe9aff057d899a50d4dc6f49f70aa74bb0 4498 
xfce4-taskmanager_1.0.0-4.debian.tar.gz
 33fde537e7c2807fc2706b1b9d5f89caaee968ad 65626 
xfce4-taskmanager_1.0.0-4_amd64.deb
Checksums-Sha256: 
 a7f90d55cb7e5fbd9846445a3b3e12e3c82d5e45d50996730e594807f0678c62 1894 
xfce4-taskmanager_1.0.0-4.dsc
 34d58e2b0b8878a95505303f9c92b8552fc1e6dd8ed69d3aa13ed999d176a2d3 4498 
xfce4-taskmanager_1.0.0-4.debian.tar.gz
 9e7513482e07379bc87de18fc04a3ba8461af82814304927340039f031b0e7a2 65626 
xfce4-taskmanager_1.0.0-4_amd64.deb
Files: 
 925f5d254fe43979b7720867672301d4 1894 xfce optional 
xfce4-taskmanager_1.0.0-4.dsc
 ed86e8f5770448fd1751a4b1bde3c171 4498 xfce optional 
xfce4-taskmanager_1.0.0-4.debian.tar.gz
 6f76ee713ca509cb440948515e865b45 65626 xfce optional 
xfce4-taskmanager_1.0.0-4_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iQEcBAEBCgAGBQJSVcaiAAoJEG3bU/KmdcCle6sH/iuGMAYfsIFOAtYRJU81s7cM
mA3cRHMFD/ZU6o7JlVRQvxeJ/obIB2KWW404mdCpKvJqEJwlEPM5ojP4IY/Bcxni
076ccaAzDIwhgHX9acpy3fBNPBHywdMur1Ss8+BSLou7yT+cchne+ESBzG0sdrw3
VNkn+HM5lms5o2U918vMfm9z0+Jako20OSsJNHieWRXQvf+Bir6VtaUB9NkraohI
2XOH51s3wttAm3JIuNDeFHXSWiXIUcSmACQPGph99zxc1+tqpaBmNfcRjUIJXkCE
M4TWCaYcrOYlJIP+twQiAB4MueZjEWlylLxeW3C6aDDLL23s38+F21CBqghWj0g=
=Qafl
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to