On Mon, 26 Aug 2013 18:46:49 +0100, Dominic Hargreaves wrote:
> Source: libdbix-dr-perl
> Version: 0.24-1
> Severity: serious
> Justification: transition imminent
> User: debian-p...@lists.debian.org
> Usertags: perl-5.18-transition
> Tags: sid jessie
>
> This package FTBFS with perl 5.18:
>
> (cd . && /usr/bin/perl Makefile.PL INSTALLDIRS=vendor )
> Checking if your kit is complete...
> Looks good
> Can't use string ("https://github.com/dr-co/dbix-dr";) as a HASH ref while
> "stric
> t refs" in use at /usr/share/perl/5.18/CPAN/Meta/Converter.pm line 708.
> at /usr/share/perl/5.18/ExtUtils/MM_Any.pm line 822.
> Can't use string ("https://github.com/dr-co/dbix-dr";) as a HASH ref while
> "stric
> t refs" in use at /usr/share/perl/5.18/CPAN/Meta/Converter.pm line 708.
> make: *** [Makefile] Error 255
This can be fixed with something like:
#v+
--- libdbix-dr-perl-0.24.orig/Makefile.PL
+++ libdbix-dr-perl-0.24/Makefile.PL
@@ -18,8 +18,12 @@
LICENSE => 'Artistic License',
META_MERGE => {
- resources => 'https://github.com/dr-co/dbix-dr',
- bugtracker => 'https://github.com/dr-co/dbix-dr/issues'
+ resources => {
+ homepage => 'https://github.com/dr-co/dbix-dr',
+ bugtracker => {
+ web => 'https://github.com/dr-co/dbix-dr/issues',
+ },
+ },
}
);
#v-
or in plain text:
#v+
META_MERGE => {
resources => {
homepage => 'https://github.com/dr-co/dbix-dr',
bugtracker => {
web => 'https://github.com/dr-co/dbix-dr/issues',
},
},
}
#v-
(for details: https://metacpan.org/module/CPAN::Meta::Spec#resources )
but then the tests fail as well:
# Failed test 'First item'
# at t/035-dr.t line 148.
# Failed test 'Second item'
# at t/035-dr.t line 149.
# Looks like you failed 2 tests of 67.
t/035-dr.t ....................
1..67
# ************* DBIx::DR *************
ok 1 - use DBIx::DR;
ok 2 - use DBD::SQLite;
ok 3 - use File::Temp;
ok 4 - use File::Path;
ok 5 - use File::Spec::Functions;
ok 6 - use File::Basename;
ok 7 - Directory contained sqls is found: t/sql
ok 8 - Temporary directory was created: /tmp/4fpXNksWkn
ok 9 - Connector was created isa DBIx::DR::db
ok 10 - Database file was created
ok 11 - Default iterator class
ok 12 - Default item class
ok 13 - Table tbl was created
ok 14 - Array item was inserted
ok 15 - Array item was inserted
ok 16 - Array item was inserted
ok 17 - Array item was inserted
ok 18 - Array item was inserted
ok 19 - Array item was inserted
ok 20 - Array item was inserted
ok 21 - Updated was passed
ok 22 - A few rows were fetched isa DBIx::DR::Iterator
ok 23 - Rows count has well value
ok 24 - Record identifier: 1
ok 25 - Record value: 1
ok 26 - Record identifier: 2
ok 27 - Record value: 2
ok 28 - Record identifier: 3
ok 29 - Record value: 3_suffix
ok 30 - Record identifier: 4
ok 31 - Record value: 4_suffix
ok 32 - Record identifier: 5
ok 33 - Record value: 6_suffix
ok 34 - Record identifier: 6
ok 35 - Record value: abc_suffix
ok 36 - Record identifier: 7
ok 37 - Record value: def_suffix
ok 38 - select.sql is found
ok 39 - -die statement
ok 40 - -warn statement
ok 41 - SELECT was done
ok 42 - Get iterator size
ok 43 - Rows count has well value
ok 44 - Get item value
ok 45 - First item
ok 46 - Get item value
ok 47 - Second item
ok 48 - Repeat sql from file isa MyIteratorPackage
ok 49 - Get iterator size
ok 50 - Rows count has well value
ok 51 - Get iterator size
ok 52 - Rows count has well value
ok 53 - Get item value
not ok 54 - First item
ok 55 - Get item value
not ok 56 - Second item
ok 57 - Select one exists row
ok 58 - Identifier
ok 59 - Value
ok 60 - No results
ok 61 - User helper
ok 62 - User helper (call the other helper)
ok 63 - Exception
ok 64 - "at line" is present
ok 65 - t/sql/unknown_function.sql.ep
ok 66 - Exception point
ok 67 - Temporary dir was removed: /tmp/4fpXNksWkn
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/67 subtests
Test Summary Report
-------------------
t/035-dr.t (Wstat: 512 Tests: 67 Failed: 2)
Failed tests: 54, 56
Non-zero exit status: 2
Files=5, Tests=280, 0 wallclock secs ( 0.06 usr 0.00 sys + 0.28 cusr 0.02
csys = 0.36 CPU)
Result: FAIL
Failed 1/5 test programs. 2/280 subtests failed.
which is hash randomization at work: (with Data::Dumper:)
SUCCESS:
$VAR1 = bless( {
'is_hash' => 1,
'item_constructor' => 'new',
'iterator' => 0,
'count' => 2,
'is_changed' => 0,
'item_class' => 'MyItemPackage',
'is_array' => 0,
'fetch' => {
'2' => {
'value' => '2',
'id' => 2
},
'1' => {
'value' => '1',
'id' => 1
}
}
}, 'MyIteratorPackage' );
FAILURE:
$VAR1 = bless( {
'is_hash' => 1,
'item_class' => 'MyItemPackage',
'count' => 2,
'is_changed' => 0,
'is_array' => 0,
'iterator' => 0,
'fetch' => {
'1' => {
'value' => '1',
'id' => 1
},
'2' => {
'id' => 2,
'value' => '2'
}
},
'item_constructor' => 'new'
}, 'MyIteratorPackage' );
Not sure where to fix this ...
Cheers,
gregor
--
.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
: :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Tom Waits: Circus
signature.asc
Description: Digital signature
