Dear all,
I hope this is the right way to communicate my thoughts on this bug.
> I'm sad to report that tkdiff still seems broken. This is on a diff of
> a subversion file.
>
> Error in startup script: can't read "errorCode": no such variable
I have the same problem when using tkdiff from tkcvs.
I would like to note that the problem does not occur when tkdiff is
called directly on two files, but it does when specifying revisions,
i.e. tkdiff -rREV1 -rREV2 FILE and probably also in similar cases.
There are two problems:
Problem 1:
This is in fact a general one, but triggers in my setting only because
of problem 2.
lines 460-463 of tkdiff:
if {[catch {open $tmpfile $access $perm} fid ]} {
# something went wrong
error "Failed creating temporary file: $errorCode"
}
errorCode is not defined here. If the catch fails, the error message
will be in fid. So this can be fixed easily:
if {[catch {open $tmpfile $access $perm} fid ]} {
# something went wrong
error "Failed creating temporary file: $fid"
}
Problem 2:
This occurs with -r being specified. The open of problem 1 should
not fail in my setting. The tmpdir is perfectly read- and writeable.
I found that two tmpfiles like /tmp/12345-1 and /tmp/12345-2 are
tried to be initialised twice: Indeed, init-files is called once from
do-new-diff directly, then do-new-diff invokes do-diff, from which
init-files is called again.
init-files calls get-file-rev for each -r on the command line, which in
turn calls tmpfile to create a temporary file. In both invocations of
init-files the temporary files will get the same names. tmpfile tries to
open them with access parameters CREAT EXCL (line 458), which will try
to create the file and fail whenever it already exists.
Since this is always done twice, the second open call will always fail
in such a situation.
A quick fix is to eliminate EXCL from access on line 458, which will
just do nothing if the file already exists. It will however write over
a previously existing file.
On the long run it would probably be better to fix one point for calling
init-files and try to create them with EXCL.
best
Wolfgang
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
