Your message dated Sat, 19 Nov 2005 18:17:08 -0800
with message-id <[EMAIL PROTECTED]>
and subject line Bug#339977: fixed in gftp 2.0.18-11
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 20 Nov 2005 00:21:48 +0000
>From [EMAIL PROTECTED] Sat Nov 19 16:21:48 2005
Return-path: <[EMAIL PROTECTED]>
Received: from zproxy.gmail.com ([64.233.162.196])
by spohr.debian.org with esmtp (Exim 4.50)
id 1Edcxo-0004zA-HC
for [EMAIL PROTECTED]; Sat, 19 Nov 2005 16:21:48 -0800
Received: by zproxy.gmail.com with SMTP id 13so473253nzp
for <[EMAIL PROTECTED]>; Sat, 19 Nov 2005 16:21:47 -0800 (PST)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
s=beta; d=gmail.com;
h=received:content-type:mime-version:from:to:subject:x-mailer:date:message-id;
b=jhlW4MieM/+Fl+i0JkdMKYKdTO6WSuU8z/QG4Y0/y7ACE0gsZh+OlSXeNO8ebD0oUTmJhM9psEmpe/RpW4TmbmpiJk+hARAu0YtphYdhHVmzUaRfZ+nEL5XDGAm/8j+fsxZDr8SfT+Ci4bZNzQirubt741TEx52esi0Ug2jC4ZU=
Received: by 10.64.199.9 with SMTP id w9mr1244679qbf;
Sat, 19 Nov 2005 16:21:47 -0800 (PST)
Received: from lala.nounou.net ( [81.57.45.18])
by mx.gmail.com with ESMTP id f15sm597428qba.2005.11.19.16.21.46;
Sat, 19 Nov 2005 16:21:47 -0800 (PST)
Received: from matt by lala.nounou.net with local (Exim 4.54)
id 1Edcxk-0005dT-Ty; Sun, 20 Nov 2005 01:21:44 +0100
Content-Type: multipart/mixed; boundary="===============1895068761=="
MIME-Version: 1.0
From: Matthieu Crapet <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: gftp: Segfault while trying to get any file (2)
X-Mailer: reportbug 3.17
Date: Sun, 20 Nov 2005 01:21:44 +0100
Message-Id: <[EMAIL PROTECTED]>
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
This is a multi-part MIME message sent by reportbug.
--===============1895068761==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Package: gftp
Version: 2.0.18-10
Severity: grave
Justification: renders package unusable
Hi,
Making segfault is similar to (closed) bug #325587, just connect to an FTP site
and try to download one file (click with left arrow button).
I recompiled with debug "gftp-2.0.18" (apt-get source)
===========================================
Program received signal SIGSEGV, Segmentation fault.
0x08077c9c in rfc959_ipv4_data_connection_new (request=0x822fa30) at
rfc959.c:706
706 memcpy (&data_addr.sin_addr,
(gdb) bt
#0 0x08077c9c in rfc959_ipv4_data_connection_new (request=0x822fa30) at
rfc959.c:706
#1 0x080787db in rfc959_data_connection_new (request=0x822fa30) at rfc959.c:969
#2 0x08078c60 in rfc959_get_file (request=0x822fa30,
filename=0x822f918 "/rep/fichier", fd=-1, startsize=0) at rfc959.c:1107
It is here (rfc959.c, line 1936)
=============================================
if (ignore_pasv_address)
{
#if defined (HAVE_GETADDRINFO)
memcpy (&data_addr.sin_addr,
&((struct sockaddr_in *)
request->current_hostp->ai_addr)->sin_addr,
sizeof (data_addr.sin_addr));
#else
memcpy (&data_addr.sin_addr,
request->hostp->h_addr_list[request->curhost],
request->hostp->h_length);
#endif
pos = (char *) &data_addr.sin_addr;
request->logging_function (gftp_logging_error, request,
_("Ignoring IP address in PASV response, connecting to
%d.%d.%d.%d:%d\n"),
pos[0] & 0xff, pos[1] & 0xff, pos[2] & 0xff, pos[3] & 0xff,
ntohs (data_addr.sin_port));
}
else
memcpy (&data_addr.sin_addr, &ad[0], 4);
=============================================
As you can see, it only happens, when the general option "Ignore PASV address"
is ticked.
(and with configure HAVE_GETADDRINFO)
I saw that the request->current_hostp (and request->hostp) was NULL.
The structure "fromreq" is created for the first time here:
transfer_window_files (src/gtk/transfer.c):
transfer->fromreq = gftp_copy_request (fromwdata->request);
transfer->toreq = gftp_copy_request (towdata->request);
transfer->fromwdata = fromwdata;
Inside "fromwdate->request", hostp and current_hostp are not NULL, but after
the call
transfer->fromreq will have hostp=NULL.
The problem is in "lib/misc", gftp_copy_request
When you want to transfer files : current_hostp is not NULL and hostp is NULL.
That's the problem.
When browsing the ftp, the fonction is called with host filled (not NULL), so
it's ok !
[
Loading directory listing / from server ([EMAIL PROTECTED])
PASV
227 Entering Passive Mode (11,22,33,44,195,105)
Ignoring IP address in PASV response, connecting to 11.22.33.44:50025
]
(misc.c, around line 1335)
=============================================
#if defined (HAVE_GETADDRINFO) && defined (HAVE_GAI_STRERROR)
struct addrinfo *hostp = req->hostp;
struct addrinfo *newhostp = newreq->hostp; /* <=== bug */
while (hostp != NULL)
{
newhostp = g_malloc (sizeof(struct addrinfo));
memcpy(newhostp, hostp, sizeof(struct addrinfo));
newhostp->ai_addr = g_malloc (sizeof(struct sockaddr));
memcpy(newhostp->ai_addr, hostp->ai_addr, sizeof(struct sockaddr));
if (hostp->ai_canonname)
newhostp->ai_canonname = strdup(hostp->ai_canonname);
if (req->current_hostp == hostp)
newreq->current_hostp = newhostp;
hostp = hostp->ai_next; newhostp = newhostp->ai_next;
}
#else
newreq->hostp = g_malloc (sizeof(struct hostent));
memcpy(newreq->hostp, req->hostp, sizeof(struct hostent));
newreq->host = req->host;
newreq->curhost = req->curhost;
#endif
=============================================
The first element is never set to newreq->hostp, because malloc is done after.
I also think that listed list is not correct (only if req->hostp->ai_next !=
NULL,
which is not very common).
That's all !
Matthieu Crapet
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'stable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.14-matt
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=ISO-8859-15)
Versions of packages gftp depends on:
ii gftp-gtk 2.0.18-10 X/GTK+ FTP client
ii gftp-text 2.0.18-10 colored FTP client using GLib
gftp recommends no packages.
-- no debconf information
--===============1895068761==
Content-Type: application/octet-stream
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="misc.c-patch.gz"
H4sICES2f0MAA21pc2MuYy1wYXRoAH1T207CQBB9tl8xxsS01jVboFEhGEhEJTGS1Mtr07Rb2Ehb
bIt4Cf/uLu3Cbi/uS1nmzJk5Z2YRQhDRzL/wUZLS+VEHYxtZFrKuodPp23a/d3mBxQETWxhrpmmW
OQq827ev+t06fDQCZF/2zjsWmPzbxTAaacDPrwYnNISAhDQmAegP47eJez95Gd/eOtOnu5kBp6fV
6HjqPr84E8eZOUbBApDl6drPwQuClMZhAmeLJMtXMISUfKCb3WWgoRZsTDYCzn42ZGhmS+YqJZ80
WWeuoDhX2J5eHx8HInlO4xxCmma5K0GQVQCEkM2CLgnoRfi4oNir3Pl1OBLN3I285TLxQc/oD0lC
vdKqYez74IdZrldaYbWwwfglFKh2FPaUziiwmiqsALZAlhmpcte8QzceZZevvK3QVhYfkchffesH
48tPu/4G53YlOeYfC7PEf+eQCkWl/p6pbES6t9Oho2IUhwzfi5M49iJiyMKbHFJ2S8y0kUg2XaXa
gxgfay9YrxoZmG6ZhBfabYW/TlMS52459WGhvF6wCSxNGMQz40eEVb0DUN9oJSrb0EIgQ2qbp7Yj
rdsJX1zxT/UxtC0MjzOlfMB/lvfO3V0FAAA=
--===============1895068761==--
---------------------------------------
Received: (at 339977-close) by bugs.debian.org; 20 Nov 2005 02:21:21 +0000
>From [EMAIL PROTECTED] Sat Nov 19 18:21:21 2005
Return-path: <[EMAIL PROTECTED]>
Received: from katie by spohr.debian.org with local (Exim 4.50)
id 1EdelQ-0003SJ-G0; Sat, 19 Nov 2005 18:17:08 -0800
From: Aurelien Jarno <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.56 $
Subject: Bug#339977: fixed in gftp 2.0.18-11
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Sat, 19 Nov 2005 18:17:08 -0800
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-4.8 required=4.0 tests=BAYES_00,FROM_ENDS_IN_NUMS,
HAS_BUG_NUMBER autolearn=no version=2.60-bugs.debian.org_2005_01_02
Source: gftp
Source-Version: 2.0.18-11
We believe that the bug you reported is fixed in the latest version of
gftp, which is due to be installed in the Debian FTP archive:
gftp-common_2.0.18-11_i386.deb
to pool/main/g/gftp/gftp-common_2.0.18-11_i386.deb
gftp-gtk_2.0.18-11_i386.deb
to pool/main/g/gftp/gftp-gtk_2.0.18-11_i386.deb
gftp-text_2.0.18-11_i386.deb
to pool/main/g/gftp/gftp-text_2.0.18-11_i386.deb
gftp_2.0.18-11.diff.gz
to pool/main/g/gftp/gftp_2.0.18-11.diff.gz
gftp_2.0.18-11.dsc
to pool/main/g/gftp/gftp_2.0.18-11.dsc
gftp_2.0.18-11_all.deb
to pool/main/g/gftp/gftp_2.0.18-11_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Aurelien Jarno <[EMAIL PROTECTED]> (supplier of updated gftp package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sun, 20 Nov 2005 02:47:57 +0100
Source: gftp
Binary: gftp gftp-text gftp-common gftp-gtk
Architecture: source i386 all
Version: 2.0.18-11
Distribution: unstable
Urgency: medium
Maintainer: Aurelien Jarno <[EMAIL PROTECTED]>
Changed-By: Aurelien Jarno <[EMAIL PROTECTED]>
Description:
gftp - X/GTK+ FTP client
gftp-common - shared files for other gFTP packages
gftp-gtk - X/GTK+ FTP client
gftp-text - colored FTP client using GLib
Closes: 326782 339962 339977
Changes:
gftp (2.0.18-11) unstable; urgency=medium
.
* Fixed copy of addrinfo type linked list (closes: bug#339977).
* Removed circular dependency on gftp-gtk|gtk-text (closes: bug#339962).
* Fixed a typo in edit bookmarks window (closes: bug#326782).
Files:
f4c38bbe9afd04a6c4588c5bbd2c5e90 708 net optional gftp_2.0.18-11.dsc
c49ef44e834109485d9da10929c79a5b 6726 net optional gftp_2.0.18-11.diff.gz
695f30093281f3e1c3032d55220fa06b 44976 net optional gftp_2.0.18-11_all.deb
76aeb9490d372f3ca11a9acfce633732 272384 net optional
gftp-gtk_2.0.18-11_i386.deb
429e2482d9c0ec86c493b834cbdfa414 119412 net optional
gftp-text_2.0.18-11_i386.deb
f4e68c4932c1edde36905358545004d4 730604 net optional
gftp-common_2.0.18-11_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDf9l+w3ao2vG823MRAn9VAJ9qNIe05BweKzewwOvBA/YJz0UyYwCfVXlq
yOzLS3ZiOtUdtCgOx4qcEjE=
=6PWf
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
