Your message dated Mon, 24 Jun 2013 18:33:21 +0000
with message-id <e1urbzp-0006fv...@franck.debian.org>
and subject line Bug#713998: fixed in iproute2 3.9.0-4
has caused the Debian Bug report #713998,
regarding iproute2: FTBFS due to a broken memset
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
713998: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=713998
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: iproute2
Version: 3.9.0-3
Severity: serious
Tags: patch
Justification: fails to build from source (but built successfully in the past)

Hi!

As iproute2 builds with -Werror, new warnings that came up with gcc-4.8
(the new default on x86 and arm architectures) make it FTBFS.

lnstat.c: In function 'build_hdr_string':
lnstat.c:169:30: error: argument to 'sizeof' in 'memset' call is the same 
expression as the destination; did you mean to provide an explicit length? 
[-Werror=sizeof-pointer-memaccess]
   memset(th.hdr[i], 0, sizeof(th.hdr[i]));

This one actually looks quite serious: it zeroes only the first 4/8 bytes of
the structure.  In any case, thanks to -Werror it's fatal.


Patch attached, with a rider that also fixes another FTBFS, this time on
x32 only.


-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (1500, 'unstable'), (500, 'experimental')
Architecture: x32 (x86_64)

Kernel: Linux 3.9.4-x32 (SMP w/6 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages iproute2 depends on:
ii  libc6     2.17-6
ii  libdb5.1  5.1.29-6

Versions of packages iproute2 recommends:
ii  libatm1       1:2.5.1-1.5
ii  libxtables10  1.4.18-1

Versions of packages iproute2 suggests:
pn  iproute2-doc  <none>

-- no debconf information
diff -Nurd iproute2-3.9.0.orig/ip/iproute.c iproute2-3.9.0/ip/iproute.c
--- iproute2-3.9.0.orig/ip/iproute.c	2013-04-30 14:47:54.000000000 +0000
+++ iproute2-3.9.0/ip/iproute.c	2013-06-24 16:33:29.731514426 +0000
@@ -1330,7 +1330,7 @@
 
 			if (time(0) - start > 30) {
 				printf("\n*** Flush not completed after %ld seconds, %d entries remain ***\n",
-				       time(0) - start, filter.flushed);
+				       (long)(time(0) - start), filter.flushed);
 				exit(1);
 			}
 
diff -Nurd iproute2-3.9.0.orig/misc/lnstat.c iproute2-3.9.0/misc/lnstat.c
--- iproute2-3.9.0.orig/misc/lnstat.c	2013-04-30 14:47:54.000000000 +0000
+++ iproute2-3.9.0/misc/lnstat.c	2013-06-24 17:11:01.942620103 +0000
@@ -166,7 +166,7 @@
 
 	for (i = 0; i < HDR_LINES; i++) {
 		th.hdr[i] = malloc(HDR_LINE_LENGTH);
-		memset(th.hdr[i], 0, sizeof(th.hdr[i]));
+		memset(th.hdr[i], 0, sizeof(*th.hdr[i]));
 	}
 
 	for (i = 0; i < fps->num; i++) {

--- End Message ---
--- Begin Message ---
Source: iproute2
Source-Version: 3.9.0-4

We believe that the bug you reported is fixed in the latest version of
iproute2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 713...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Henriksson <andr...@fatal.se> (supplier of updated iproute2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 24 Jun 2013 19:54:41 +0200
Source: iproute2
Binary: iproute2 iproute2-doc iproute iproute-doc
Architecture: source all amd64
Version: 3.9.0-4
Distribution: unstable
Urgency: low
Maintainer: Debian iproute2 Maintainers <ah-ipro...@debian.org>
Changed-By: Andreas Henriksson <andr...@fatal.se>
Description: 
 iproute    - transitional dummy package for iproute2
 iproute-doc - transitional dummy package for iproute2-doc
 iproute2   - networking and traffic control tools
 iproute2-doc - networking and traffic control tools - documentation
Closes: 713998
Changes: 
 iproute2 (3.9.0-4) unstable; urgency=low
 .
   * Cherry-pick upstream patch to build with gcc 4.8.0 (Closes: #713998)
Checksums-Sha1: 
 237e6c7516a0c47b5c24319cda4c763b0027cdd8 1609 iproute2_3.9.0-4.dsc
 3468802d2493f81452d482725af70ce0d8292671 29827 iproute2_3.9.0-4.debian.tar.gz
 04f43af1a46070eb9b43eca9d57e919661a27016 15016 iproute_3.9.0-4_all.deb
 171769aacb00d483dbc0df4c36578d52f688dbc7 15022 iproute-doc_3.9.0-4_all.deb
 73fc8826e9bcd8aef15136edd505509159ae7180 529464 iproute2_3.9.0-4_amd64.deb
 530d1b80dd0a8b437c58a6597398f25ec2aa5252 937932 iproute2-doc_3.9.0-4_all.deb
Checksums-Sha256: 
 f4e6ff40d60a646240b18dcde7d5975413989d04312a46fc0c61bb7e666b7ca1 1609 
iproute2_3.9.0-4.dsc
 2cf52218f0d9a61a41844ca93eda5debd1bea23399a0ddbff65c072826373a10 29827 
iproute2_3.9.0-4.debian.tar.gz
 792af9ad67ff5d7c124ea652659733f5e279dbb4b15e62b6521af8d481b240a2 15016 
iproute_3.9.0-4_all.deb
 62efac9451f5b44fd10d55d880e1b9d948ad0cfedbf873a62abe75856e196ed9 15022 
iproute-doc_3.9.0-4_all.deb
 e8c0dd8c2c813a12b030031cee404b50034f847c5ce537082f4a1c65740ef8f9 529464 
iproute2_3.9.0-4_amd64.deb
 96e8fea13045b63ce769e1862f4bcdd6ddabc5b7d7c17d0d02cd5c4e9b2fcdf2 937932 
iproute2-doc_3.9.0-4_all.deb
Files: 
 0a00537431f1e0e38df29f6ee22a0bb7 1609 net optional iproute2_3.9.0-4.dsc
 0cf84b68aa21a9d83d0039aa499f8689 29827 net optional 
iproute2_3.9.0-4.debian.tar.gz
 fd3409946f15694eeb79bdc38cdd9eed 15016 oldlibs optional iproute_3.9.0-4_all.deb
 c1646b9cdd6191531d0a4d9422c40973 15022 oldlibs optional 
iproute-doc_3.9.0-4_all.deb
 e520a733e1e0696319a6bfa142e3e75a 529464 net important 
iproute2_3.9.0-4_amd64.deb
 0d3cd7a51a2189259595154c59bc19ad 937932 doc optional 
iproute2-doc_3.9.0-4_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlHIivwACgkQcgQ2cL3l8e6vswCgtqPQo2aqqqOknx/sLCTidjxh
RMQAoNUbGQC0STT0JmmJ7VZxsHn2iXcH
=OCW+
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to