The patch seems fine but given that F_DUPFD_CLOEXEC has been implemented in
FreeBSD[1], I wonder if the __linux__ test shouldn't be changed to a
HAVE_F_DUPFD_CLOEXEC check (or to a hurd one). How long do you think it'll take
for Debian's freebsd kernel to have that?
The version in stable does not support it, and upgrade wheezy -> jessie
should be doable under wheezy kernel.
I expect that jessie one (9.2+) will support it.
Actually Hurd has had support for F_DUPFD_CLOEXEC for a while, so this should
either be __FreeBSD_kernel__ (or whatever) or a HAVE_F_DUPFD_CLOEXEC (with the
appropriate configure check) or perhaps even an #ifdef F_DUPFD_CLOEXEC (assuming
it will be a define in kfreebsd, it is one on linux and hurd).
"The <fcntl.h> header shall define the following symbolic constants for the cmd
argument used by fcntl(). The values shall be unique and shall be suitable for
use in #if preprocessing directives"
I say we can just do an #ifdef F_DUPFD_CLOEXEC
Good idea.
The libc might provide wrapper inside fcntl together with defining
F_DUPFD_CLOEXEC to support older kernels.
Cheers
Petr
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
