Your message dated Tue, 04 Jun 2013 15:49:05 +0000
with message-id <e1ujttt-0007ks...@franck.debian.org>
and subject line Bug#709482: fixed in debhelper 9.20130604
has caused the Debian Bug report #709482,
regarding debhelper: dh_installinit should add a versioned dep on sysv-rc for 
upstart jobs
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
709482: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=709482
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: debhelper
Version: 9.20130516
Severity: normal

Hi Joey,

While fixing up debhelper in Ubuntu to match the dh_installinit upstart
implementation in Debian, I noticed that packages shipping upstart jobs
should have a versioned dependency on the version of sysv-rc whose
invoke-rc.d provides native support for upstart - otherwise, on upstart
systems the init script may be used instead of the upstart job in error.

This is more of an issue for Ubuntu than for Debian, since the versioned dep
is satisfied already in wheezy; but it would be correct to add it for Debian
as well, so I'm forwarding this patch on.

Thanks for considering the patch.


-- System Information:
Debian Release: wheezy/sid
  APT prefers saucy-updates
  APT policy: (500, 'saucy-updates'), (500, 'saucy-security'), (500, 'saucy')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
armhf

Kernel: Linux 3.9.0-2-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
>From c701061d7b3ded60d1a308aa2b004301df4a7bed Mon Sep 17 00:00:00 2001
From: Steve Langasek <steve.langa...@ubuntu.com>
Date: Fri, 17 May 2013 20:37:39 -0500
Subject: [PATCH] Packages with upstart jobs should carry a versioned
 dependency on sysv-rc

Depend on the version of invoke-rc.d that supports upstart jobs directly,
without which invoke-rc.d will incorrectly use the sysvinit script instead
of the upstart job when starting the service.
---
 dh_installinit | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/dh_installinit b/dh_installinit
index e227006..3260866 100755
--- a/dh_installinit
+++ b/dh_installinit
@@ -224,6 +224,13 @@ foreach my $package (@{$dh{DOPACKAGES}}) {
 
 	my $init=pkgfile($package,$script) || pkgfile($package,"init") ||
 		pkgfile($package,"init.d");
+
+	if ($job ne '' || ($dh{ONLYSCRIPTS} && -e "$tmp/etc/init/$jobfile.conf")) {
+		# minimal version of invoke-rc.d that supports upstart jobs
+		# directly
+		addsubstvar($package, "misc:Depends", "sysv-rc (>= 2.88dsf-24)");
+	}
+
 	if ($init ne '' && ! $dh{ONLYSCRIPTS}) {
 		if (! -d "$tmp/etc/init.d") {
 			doit("install","-d","$tmp/etc/init.d");
-- 
1.8.1.2


--- End Message ---
--- Begin Message ---
Source: debhelper
Source-Version: 9.20130604

We believe that the bug you reported is fixed in the latest version of
debhelper, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 709...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joey Hess <jo...@debian.org> (supplier of updated debhelper package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 04 Jun 2013 11:27:29 -0400
Source: debhelper
Binary: debhelper
Architecture: source all
Version: 9.20130604
Distribution: unstable
Urgency: low
Maintainer: Joey Hess <jo...@debian.org>
Changed-By: Joey Hess <jo...@debian.org>
Description: 
 debhelper  - helper programs for debian/rules
Closes: 562874 707481 709482 709557
Changes: 
 debhelper (9.20130604) unstable; urgency=low
 .
   * dh_installchangelogs: No longer automatically converts html changelogs.
     A plain text version can be provided as a second parameter, or it will
     generate a file with a pointer to the html changelog if not.
     html2text's reign of terror has ended. Closes: #562874
   * Allow building debhelper with USE_NLS=no to not require po4a to build.
     Closes: #709557
   * Correct broken patch for #706923.
     Closes: #707481
   * dh_installinit: Add appropriately versioned file-rc as an alternate
     when adding misc:Depends for an invoke-rc.d that supports upstart
     jobs. Closes: #709482
Checksums-Sha1: 
 cbc898a8edcef5ca4f67c733506f9c6e29a2e154 1577 debhelper_9.20130604.dsc
 92744ce317fa857ab39195b13af769fd7d01af16 473080 debhelper_9.20130604.tar.gz
 0c63e528f2b6ed5c0139e67d082fcb855de52207 708638 debhelper_9.20130604_all.deb
Checksums-Sha256: 
 208c2c09fccca20f9736aee068be1c3e35836148b823e731d008444835c04e00 1577 
debhelper_9.20130604.dsc
 27c3b7f8dcafea0d4e0f6311970ad26b76be24122b312ed42b2db0a9b9c0be0d 473080 
debhelper_9.20130604.tar.gz
 cece80b5e6f207d3be204f2027889cf5277dd383379b46cf143ca285ae198ab6 708638 
debhelper_9.20130604_all.deb
Files: 
 d74997880b3f1329f3a1fdd646d6dae0 1577 devel optional debhelper_9.20130604.dsc
 f13f1807b4baf95bd52391412b1f9eeb 473080 devel optional 
debhelper_9.20130604.tar.gz
 44b8a86693caffa8a3166b715d561b10 708638 devel optional 
debhelper_9.20130604_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIVAwUBUa4I4ckQ2SIlEuPHAQi9eRAAk4yTcgqbyTZ8b+dYn/jsdOUmge9sYo3Q
Wv+9OBVOsHyHBWKzoB8HiaAe0WCqqCEmOG1j+Xf9p7H7Gqo/4qRXw3ghDhZhWDqS
Hq6RwD6nVzy8zD80mZBRep/aQw30IPMfIlNww3Ktw9d+qamzpsup7SoxGQ6P0OP7
OCB8szmKWQOeSbu3nGW2tweuMhnXkXGvdO53tJ8vhBPbRSCTUBf5fJHlTPlQ6C9i
GeTOXs8QiqiQoFKWQVWNGuG5BXUJEthbeI4HYJbuU/R6mK4GAVIc/lPEwNDj1CKB
2T/OwvPmFQv8O3s0dj79cMUxfwmr9fpbegh8eiH+UARdKx/96qysGAn78dBUrdva
43QwgIH7heaNxMEZkTE4a85A+S3Hy6aCltLZYf7jmNwQueS0bBHuvAnUSPlI2CAV
1yM23g51BBGNDuBgWjMxnJ2JabZg8J/gQxNnECJpXqd7XWFkX9QRAyYBurWHBEYJ
lcmpVRaIH0Zm8NaqbmCMSILQGx9y7/fNXj/15N/7NZrtMKv3ZQNmvCABflArFetT
rsJIS6gqOWs0mfB/0r5UnMRKgpbHu7pOFVWF+Gnf/ikY177A0/UyuXCJkaK9rC+P
nRx8tw+kgEhOYwiOoRgqlDGfOkihI235J+u+Lw49X9AdTiEnOEy6cUtrOuG/K61S
/3zyj2FdVB0=
=TZrz
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to