On Mon, 03 Jun 2013 11:14:41 +0300, Niko Tyni wrote: > > - libapache-singleton-perl, libapache-authenhook-perl, > > libapache2-reload-perl build, reviews/tests still welcome > These look OK to me.
Thanks for your feedback! > Possibly we/upstream should make Apache::Test > provide at least a default MPM if one can't be parsed from the system > Apache configuration. Still, it's much cleaner to have a standalone > configuration in the packaging. > > The t/logs (and/or t/run?) directory creation should really be pushed > into Apache-Test, but having 'mkdir -p $(CURDIR)/t/logs' should be OK > as that doesn't fail if the directory already exists. Adding d/apache2.conf and creating/removing these directories in each package is a bit tiresome indeed; but I also think it's fine for now and we can always revisit the situation. I've uploaded those three packages now. > > - libapache2-authcookie-perl explodes in the test suite, and I have > > no idea how to fix it (and if the problem is somewhere between > > tests and packaging or if we have a more fundamental problem re. > > apache auth* changes in general) > > There are Apache 2.4 API changes breaking this. At least this, > in Apache2::AuthCookie::authorize() > > my $reqs_arr = $r->requires or return DECLINED; > > From t/logs/error_log: > > [Mon Jun 03 08:13:11.638444 2013] [perl:error] [pid 16238:tid > 46981196248832] [client 127.0.0.1:35254] Can't locate object method > "requires" via package "Apache2::RequestRec" at > /home/niko/libapache2-authcookie-perl/blib/lib/Apache2/AuthCookie.pm line > 391.\n Oh, I missed this in t/logs/error_log among all the other authn and authz errors ... (Now I see it, too :)) > ap_requires() was removed in Apache2.4. From the documentation at > http://httpd.apache.org/docs/2.4/developer/new_api_2_4.html > > The core server now provides better infrastructure for handling > Require configuration. Register an auth provider function for each > supported entity using ap_register_auth_provider(). The function > will be called as necessary during Require processing. (Consult > bundled modules for detailed examples.) > > I expect it's currently totally broken and we should drop the package > from testing for now. (The bug should probably be 'grave'.) Ack, thanks for updating the bug report. > The unfortunate lack of a reference mod_perl2 version to test against > makes it a bit hard to report this upstream. Yup :/ I'm forwarding it anyway now to make upstream aware of the issue. Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Tracy Chapman: Subcity
signature.asc
Description: Digital signature
