Am 28.04.2013 09:07, schrieb Tomas Pospisek: > I have had a look at the patch and as an outsider to the fetchmail code > that is not a maintaner of fetchmail am personaly not comfortable with > it. The problem is that the patched code in question is allready twisted > enough, it's in very large part code to work around various buggy mail > software that f.ex. doesn't signal the content length correctly. So > dynamic content lengths and fixed buffers are passed around and written > into and added to. The provided patch now adds on top of all of this yet > another work around that adds a newline at the end of the buffer in > order to get the transformed mime encoded content right. > > In short, in the time I was looking at the patch, I was not able to > determine, if it doesn't add a buffer overflow. To me as an ignorant > fetchmail code outsider the code in question does contain buffer > overflow code smell.
Would you care to share particular concerns with the code? If you can share more concrete concerns, I may be able to answer them. I am happy to answer questions or revise the patch if necessary. -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org