Hello,

I agree to what Anton said. A full disk can cause more issues than just the bash history file being overwritten.

I understand that this is an important issue for you, but please also keep in mind that we want to release Wheezy at some point in the near future. It's good to know that this issue exist and I am glad that you reported it, but I don't think the issue is important enough *right now* to have it fixed as it will just delay the release even further.

It might have worth a shot fixing the package if you had come up with a patch, but I think this way it will just add up as another show stopper for Wheezy which is something we want to avoid.

I had, btw, a look at the bash source already and from what I learned from the code so far, I am not sure whether it's possible that an overwrite can occur when the disk is full. Rather, the write should just fail.

The code blocks in questions are in bashhist.c, lib/readline/history.c and lib/readline/histfile.c.

The function save_history() in bashhist.c has the following mechanism to decide whether to append or overwrite history:

if (history_lines_this_session <= where_history () || force_append_history)
        append_history (history_lines_this_session, hf);
      else
        write_history (hf);

Both append_history and write_history in lib/readline/histfile.c call history_do_write with either HISTORY_APPEND or HISTORY_OVERWRITE to eventually write the file.

So these are definitely the parts to look into. I haven't found anything suspicious yet, however.

Maybe you could do some debugging and run/recompile bash with the "force_append_history" flag set? I'd be very interested whether your history file would still get overwritten.

Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to