tags 704300 patch pending thanks On Mon, April 1, 2013 10:12, Ana Guerrero wrote: > On Mon, Apr 01, 2013 at 10:06:48AM +0200, Thijs Kinkhorst wrote: >> On Mon, April 1, 2013 09:59, Thijs Kinkhorst wrote: >> > On Mon, April 1, 2013 09:55, Ana Guerrero wrote: >> >> On Mon, Apr 01, 2013 at 09:41:54AM +0200, Thijs Kinkhorst wrote: >> >>> >> >>> Yes, but I'm making the point that strict standards messages would >> >>> normally and by default be logged, not output to the browser... >> >> >> >> Cool, then the problem has an easy fix as hinted by Jan? :) (I can't >> >> test that right now). In the current state, the application is not >> >> usable, that's a RC bug... >> > >> > I'm saying it can be fixed by changing the value of error_reporting in >> > /etc/php5/*/php.ini back to something that doesn't include E_STRICT. >> Which >> > is the default in the php.ini Debian ships and which is the >> recommended >> > production value. >> > >> > So it's not only fixed easily, it should not occur in the default and >> > recommended PHP configuration. >> > >> > Yes, not ideal indeed, but that's why it's still an important bug. >> >> Sorry, I have to retract all this. What I said about PHP was correct, >> but >> it seems that scuttle overrides these settings in its own code :/ >> Therefore the default PHP settings are not relevant. So this is indeed >> RC. > > Yes, the change proposed by Jan might fix it but I can't test right now.
I've made attached fix which fixes it (imo) correctly: follow the local admin's wishes with respect to error_reporting. This ensures that scuttle works in default configurations and generally does whatever the admin configures in php.ini. I have confirmed that the problem goes away on a default wheezy system. Marcelo, given the point in the freeze timeframe, I've uploaded this to DELAYED/5. Let me know if you want me to delay/cancel it or if you want me to reduce the delay and upload immediately. Cheers, Thijs
scuttle.debdiff
Description: Binary data
