On Sat, Feb 23, 2013 at 01:53:19PM -0800, Vagrant Cascadian wrote:
> On Sat, Feb 23, 2013 at 10:17:32AM +0100, Ralf Treinen wrote:
> > On Fri, Feb 22, 2013 at 04:09:01PM -0800, Vagrant Cascadian wrote:
> > 
> > > I haven't tested the following patch, but it should essentially resolve 
> > > the
> > > issue.
> > 
> > Shouldn't one keep checking that the user doesn't enter empty values
> > for USER and PASS ? I was thinking of a patch like this one:
> > 
> > -------------------------------------------------------------------------
> > 
> > --- config  2013-02-23 10:11:45.000000000 +0100
> > +++ config.orig     2013-02-23 10:08:49.000000000 +0100
> > @@ -2,6 +2,8 @@
> >  
> >  set -e
> >  
> > +[ `echo $DEBIAN_FRONTEND | tr '[:upper:]' '[:lower:]'` = "noninteractive" 
> > ] && exit 0
> > +
> >  . /usr/share/debconf/confmodule
> >  
> >  db_beginblock
> > @@ -11,11 +13,8 @@
> >  
> >  db_go
> >  
> > -USER=rinput
> >  db_get rinputd/username
> >  USER="$RET"
> > -
> > -PASS=DEFAULTPASSWD
> >  db_get rinputd/passwd
> >  PASS="$RET"
> > 
> > ------------------------------------------------------------------------
> 
> That will still overwrite it with an empty value...
> 
> probably something more like:
> 
>   db_get rinput/passwd
>   PASS="$RET"
> 
>   if [ -z "$PASS" ]; then
>     db_set rinput/passwd "DEFAULTPASSWD"
>   fi

The idea was of course th eleave the loop that was in the original
config script, which in the interactive case would succeed only when
the iser has entered valid values.

Anyway, it seems I won't have time to do an NMU in the next days so if
you want to do it please go ahead.

-Ralf.


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to