Your message dated Sun, 17 Feb 2013 01:17:30 +0000
with message-id <e1u6ssk-0006i0...@franck.debian.org>
and subject line Bug#700535: fixed in fts 1.1-1.1
has caused the Debian Bug report #700535,
regarding fts: several issues w.r.t. configuration file handling
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
700535: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=700535
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: fts
Version: 1.1-1
Severity: serious
Tags: patch
Hi,
actually I only wanted to look whether #674007 can be fixed easily ...
but then I found a lot of serious errors handling /etc/fts/config:
* upstream git repository has moved (ok, found the new location)
* incorrect usage of debconf in postrm purge
* shipping /etc/fts/config as conffile *and* generating it in postinst
* having the template in /usr/share/doc/ instead of /usr/share/fts/
* not using ucfr/ucfr --purge
* not using ucf --purge in postinst (install, purge, install - and ucf
will notice that the config file was deleted inbetween and keep it
that way)
I have all the changes that are combined (and duplicated due to the
upstream repository layout) in the attached diff as separate git
commits, I just need to push the repository somewhere so that you can
pull ... from here: git://github.com/anbe42/tmp-fts.git
Since I brought the package into shape so far, I can also NMU it ... and
I intend to do so in a few days.
Andreas
diffstat for fts-1.1 fts-1.1
contrib/packaging/debian/fts/debian/changelog | 17 +++++++++++++++
contrib/packaging/debian/fts/debian/control | 6 ++---
contrib/packaging/debian/fts/debian/fts.dirs | 1
contrib/packaging/debian/fts/debian/fts.docs | 1
contrib/packaging/debian/fts/debian/fts.install | 2 -
contrib/packaging/debian/fts/debian/fts.postinst | 3 +-
contrib/packaging/debian/fts/debian/fts.postrm | 25 ++++++++++++++++-------
contrib/packaging/debian/fts/package.sh | 2 -
debian/changelog | 17 +++++++++++++++
debian/control | 6 ++---
debian/fts.dirs | 1
debian/fts.docs | 1
debian/fts.install | 2 -
debian/fts.postinst | 3 +-
debian/fts.postrm | 25 ++++++++++++++++-------
15 files changed, 85 insertions(+), 27 deletions(-)
diff -Nru fts-1.1/contrib/packaging/debian/fts/debian/changelog fts-1.1/contrib/packaging/debian/fts/debian/changelog
--- fts-1.1/contrib/packaging/debian/fts/debian/changelog 2012-05-21 15:47:26.000000000 +0200
+++ fts-1.1/contrib/packaging/debian/fts/debian/changelog 2013-02-14 03:49:19.000000000 +0100
@@ -1,3 +1,20 @@
+fts (1.1-1.1) UNRELEASED; urgency=low
+
+ * Non-maintainer upload.
+ * Update Homepage and Vcs URLs to https://github.com/gonicus/fts.
+ * fts.postrm: Do not fail to purge if the config file is not there.
+ (Closes: #674007)
+ * fts.postrm: Fix debconf usage during purge. Load the module before doing
+ any actions (this re-execs the postinst). Move #DEBHELPER# token to the
+ end s.t. we can do db_get before db_purge is run.
+ * Ship default config as /usr/share/fts/config, postinst may not rely on
+ /usr/share/doc/fts/config (Policy 12.3).
+ * Do not ship /etc/fts/config as a conffile, postinst generates it.
+ * Register and purge /etc/fts/config with ucf/ucfr.
+ * Ship empty /var/lib/tftpboot directory.
+
+ -- Andreas Beckmann <a...@debian.org> Thu, 14 Feb 2013 02:10:51 +0100
+
fts (1.1-1) unstable; urgency=low
* New upstream release.
diff -Nru fts-1.1/contrib/packaging/debian/fts/debian/control fts-1.1/contrib/packaging/debian/fts/debian/control
--- fts-1.1/contrib/packaging/debian/fts/debian/control 2012-05-21 15:47:26.000000000 +0200
+++ fts-1.1/contrib/packaging/debian/fts/debian/control 2013-02-14 03:49:19.000000000 +0100
@@ -5,9 +5,9 @@
Build-Depends: debhelper (>= 7.0.50~), python (>= 2.6.6-3~), python-setuptools
X-Python-Version: >= 2.6
Standards-Version: 3.9.2
-Homepage: https://github.com/clacks/fts
-Vcs-Browser: https://github.com/clacks/fts
-Vcs-Git: git://github.com/clacks/fts.git
+Homepage: https://github.com/gonicus/fts
+Vcs-Browser: https://github.com/gonicus/fts
+Vcs-Git: git://github.com/gonicus/fts.git
Package: fts
Architecture: all
diff -Nru fts-1.1/contrib/packaging/debian/fts/debian/fts.dirs fts-1.1/contrib/packaging/debian/fts/debian/fts.dirs
--- fts-1.1/contrib/packaging/debian/fts/debian/fts.dirs 2012-05-21 15:47:26.000000000 +0200
+++ fts-1.1/contrib/packaging/debian/fts/debian/fts.dirs 2013-02-14 03:49:19.000000000 +0100
@@ -1,2 +1,3 @@
usr/sbin
etc/fts
+var/lib/tftpboot
diff -Nru fts-1.1/contrib/packaging/debian/fts/debian/fts.docs fts-1.1/contrib/packaging/debian/fts/debian/fts.docs
--- fts-1.1/contrib/packaging/debian/fts/debian/fts.docs 2012-05-21 15:47:26.000000000 +0200
+++ fts-1.1/contrib/packaging/debian/fts/debian/fts.docs 2013-02-14 03:49:19.000000000 +0100
@@ -1,2 +1 @@
-config
debian/README.Debian
diff -Nru fts-1.1/contrib/packaging/debian/fts/debian/fts.install fts-1.1/contrib/packaging/debian/fts/debian/fts.install
--- fts-1.1/contrib/packaging/debian/fts/debian/fts.install 2012-05-21 15:47:26.000000000 +0200
+++ fts-1.1/contrib/packaging/debian/fts/debian/fts.install 2013-02-14 03:49:19.000000000 +0100
@@ -2,4 +2,4 @@
usr/lib/python*/dist-packages/fts
usr/lib/python*/dist-packages/fts-*.egg-info
../rsyslog/fts.conf /etc/rsyslog.d
-../../config /etc/fts
+../../config /usr/share/fts/
diff -Nru fts-1.1/contrib/packaging/debian/fts/debian/fts.postinst fts-1.1/contrib/packaging/debian/fts/debian/fts.postinst
--- fts-1.1/contrib/packaging/debian/fts/debian/fts.postinst 2012-05-21 15:47:26.000000000 +0200
+++ fts-1.1/contrib/packaging/debian/fts/debian/fts.postinst 2013-02-14 03:49:19.000000000 +0100
@@ -36,8 +36,9 @@
# Apply to config
sed -e "s~^path\s*=\s*/.*$~path = $tftppath/pxelinux.cfg~" \
- -e "s~^static-path\s*=\s*/.*$~static-path = $tftppath/pxelinux.static~" /usr/share/doc/fts/config > /etc/fts/config.debconf-tmp
+ -e "s~^static-path\s*=\s*/.*$~static-path = $tftppath/pxelinux.static~" /usr/share/fts/config > /etc/fts/config.debconf-tmp
ucf --three-way --debconf-ok /etc/fts/config.debconf-tmp /etc/fts/config
+ ucfr fts /etc/fts/config
rm -f /etc/fts/config.debconf-tmp || true
;;
diff -Nru fts-1.1/contrib/packaging/debian/fts/debian/fts.postrm fts-1.1/contrib/packaging/debian/fts/debian/fts.postrm
--- fts-1.1/contrib/packaging/debian/fts/debian/fts.postrm 2012-05-21 15:47:26.000000000 +0200
+++ fts-1.1/contrib/packaging/debian/fts/debian/fts.postrm 2013-02-14 03:49:19.000000000 +0100
@@ -2,20 +2,29 @@
set -e
-#DEBHELPER#
-
if [ "$1" = "purge" ] ; then
+ . /usr/share/debconf/confmodule
+
deluser --quiet --system tftpd > /dev/null || true
delgroup --quiet --system tftpd > /dev/null || true
# Remove configuration file
- rm /etc/fts/config
- if [ -d "/etc/fts" ]; then
- rmdir "$f" || { chown root:root "$f" && chmod 00700 "$f"; }
- fi
+ ftsconfig=/etc/fts/config
+
+ for ext in '~' '%' .bak .ucf-new .ucf-old .ucf-dist; do
+ rm -f "$ftsconfig$ext"
+ done
+
+ rm -f $ftsconfig
+
+ if which ucf >/dev/null; then
+ ucf --purge $ftsconfig
+ fi
+ if which ucfr >/dev/null; then
+ ucfr --purge fts $ftsconfig
+ fi
# See if there's some stuff that is not created by us
- . /usr/share/debconf/confmodule
db_version 2.0
db_get "fts/tftppath"
tftppath="$RET"
@@ -24,3 +33,5 @@
rmdir "$tftppath/pxelinux.cfg" || true
rmdir "$tftppath/pxelinux.static" || true
fi
+
+#DEBHELPER#
diff -Nru fts-1.1/contrib/packaging/debian/fts/package.sh fts-1.1/contrib/packaging/debian/fts/package.sh
--- fts-1.1/contrib/packaging/debian/fts/package.sh 2012-05-21 15:47:26.000000000 +0200
+++ fts-1.1/contrib/packaging/debian/fts/package.sh 2013-02-14 03:49:19.000000000 +0100
@@ -1,6 +1,6 @@
#!/bin/sh
NAME=fts
-VERSION=`parsechangelog | sed -n 's/^Version:\s*\(.*\)-[0-9][0-9]*$/\1/p'`
+VERSION=`parsechangelog | sed -n 's/^Version:\s*\(.*\)-\(.*\)*$/\1/p'`
#----
diff -Nru fts-1.1/debian/changelog fts-1.1/debian/changelog
--- fts-1.1/debian/changelog 2012-05-19 11:04:50.000000000 +0200
+++ fts-1.1/debian/changelog 2013-02-14 03:48:57.000000000 +0100
@@ -1,3 +1,20 @@
+fts (1.1-1.1) UNRELEASED; urgency=low
+
+ * Non-maintainer upload.
+ * Update Homepage and Vcs URLs to https://github.com/gonicus/fts.
+ * fts.postrm: Do not fail to purge if the config file is not there.
+ (Closes: #674007)
+ * fts.postrm: Fix debconf usage during purge. Load the module before doing
+ any actions (this re-execs the postinst). Move #DEBHELPER# token to the
+ end s.t. we can do db_get before db_purge is run.
+ * Ship default config as /usr/share/fts/config, postinst may not rely on
+ /usr/share/doc/fts/config (Policy 12.3).
+ * Do not ship /etc/fts/config as a conffile, postinst generates it.
+ * Register and purge /etc/fts/config with ucf/ucfr.
+ * Ship empty /var/lib/tftpboot directory.
+
+ -- Andreas Beckmann <a...@debian.org> Thu, 14 Feb 2013 02:10:51 +0100
+
fts (1.1-1) unstable; urgency=low
* New upstream release.
diff -Nru fts-1.1/debian/control fts-1.1/debian/control
--- fts-1.1/debian/control 2012-05-21 15:55:09.000000000 +0200
+++ fts-1.1/debian/control 2013-02-14 02:10:48.000000000 +0100
@@ -5,9 +5,9 @@
Build-Depends: debhelper (>= 7.0.50~), python (>= 2.6.6-3~), python-setuptools
X-Python-Version: >= 2.6
Standards-Version: 3.9.2
-Homepage: https://github.com/clacks/fts
-Vcs-Browser: https://github.com/clacks/fts
-Vcs-Git: git://github.com/clacks/fts.git
+Homepage: https://github.com/gonicus/fts
+Vcs-Browser: https://github.com/gonicus/fts
+Vcs-Git: git://github.com/gonicus/fts.git
Package: fts
Architecture: all
diff -Nru fts-1.1/debian/fts.dirs fts-1.1/debian/fts.dirs
--- fts-1.1/debian/fts.dirs 2012-01-12 13:34:41.000000000 +0100
+++ fts-1.1/debian/fts.dirs 2013-02-14 03:48:18.000000000 +0100
@@ -1,2 +1,3 @@
usr/sbin
etc/fts
+var/lib/tftpboot
diff -Nru fts-1.1/debian/fts.docs fts-1.1/debian/fts.docs
--- fts-1.1/debian/fts.docs 2012-01-12 13:34:41.000000000 +0100
+++ fts-1.1/debian/fts.docs 2013-02-14 02:51:02.000000000 +0100
@@ -1,2 +1 @@
-config
debian/README.Debian
diff -Nru fts-1.1/debian/fts.install fts-1.1/debian/fts.install
--- fts-1.1/debian/fts.install 2012-05-21 12:05:23.000000000 +0200
+++ fts-1.1/debian/fts.install 2013-02-14 02:52:20.000000000 +0100
@@ -2,4 +2,4 @@
usr/lib/python*/dist-packages/fts
usr/lib/python*/dist-packages/fts-*.egg-info
../rsyslog/fts.conf /etc/rsyslog.d
-../../config /etc/fts
+../../config /usr/share/fts/
diff -Nru fts-1.1/debian/fts.postinst fts-1.1/debian/fts.postinst
--- fts-1.1/debian/fts.postinst 2012-05-19 11:03:01.000000000 +0200
+++ fts-1.1/debian/fts.postinst 2013-02-14 03:21:13.000000000 +0100
@@ -36,8 +36,9 @@
# Apply to config
sed -e "s~^path\s*=\s*/.*$~path = $tftppath/pxelinux.cfg~" \
- -e "s~^static-path\s*=\s*/.*$~static-path = $tftppath/pxelinux.static~" /usr/share/doc/fts/config > /etc/fts/config.debconf-tmp
+ -e "s~^static-path\s*=\s*/.*$~static-path = $tftppath/pxelinux.static~" /usr/share/fts/config > /etc/fts/config.debconf-tmp
ucf --three-way --debconf-ok /etc/fts/config.debconf-tmp /etc/fts/config
+ ucfr fts /etc/fts/config
rm -f /etc/fts/config.debconf-tmp || true
;;
diff -Nru fts-1.1/debian/fts.postrm fts-1.1/debian/fts.postrm
--- fts-1.1/debian/fts.postrm 2012-05-19 11:03:01.000000000 +0200
+++ fts-1.1/debian/fts.postrm 2013-02-14 03:24:02.000000000 +0100
@@ -2,20 +2,29 @@
set -e
-#DEBHELPER#
-
if [ "$1" = "purge" ] ; then
+ . /usr/share/debconf/confmodule
+
deluser --quiet --system tftpd > /dev/null || true
delgroup --quiet --system tftpd > /dev/null || true
# Remove configuration file
- rm /etc/fts/config
- if [ -d "/etc/fts" ]; then
- rmdir "$f" || { chown root:root "$f" && chmod 00700 "$f"; }
- fi
+ ftsconfig=/etc/fts/config
+
+ for ext in '~' '%' .bak .ucf-new .ucf-old .ucf-dist; do
+ rm -f "$ftsconfig$ext"
+ done
+
+ rm -f $ftsconfig
+
+ if which ucf >/dev/null; then
+ ucf --purge $ftsconfig
+ fi
+ if which ucfr >/dev/null; then
+ ucfr --purge fts $ftsconfig
+ fi
# See if there's some stuff that is not created by us
- . /usr/share/debconf/confmodule
db_version 2.0
db_get "fts/tftppath"
tftppath="$RET"
@@ -24,3 +33,5 @@
rmdir "$tftppath/pxelinux.cfg" || true
rmdir "$tftppath/pxelinux.static" || true
fi
+
+#DEBHELPER#
--- End Message ---
--- Begin Message ---
Source: fts
Source-Version: 1.1-1.1
We believe that the bug you reported is fixed in the latest version of
fts, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 700...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andreas Beckmann <a...@debian.org> (supplier of updated fts package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 17 Feb 2013 01:09:01 +0100
Source: fts
Binary: fts fts-fai-ldap fts-clacks fts-ltsp-ldap fts-opsi
Architecture: source all
Version: 1.1-1.1
Distribution: unstable
Urgency: low
Maintainer: Cajus Pollmeier <ca...@debian.org>
Changed-By: Andreas Beckmann <a...@debian.org>
Description:
fts - Modular TFTP/Fuse supplicant
fts-clacks - Clacks module for the TFTP/Fuse supplicant
fts-fai-ldap - LDAP FAI module for the TFTP/Fuse supplicant
fts-ltsp-ldap - LDAP LTSP module for the TFTP/Fuse supplicant
fts-opsi - LDAP LTSP module for the TFTP/Fuse supplicant
Closes: 674007 700535
Changes:
fts (1.1-1.1) unstable; urgency=low
.
* Non-maintainer upload with maintainer approval. (Closes: #700535)
* Update Homepage and Vcs URLs to https://github.com/gonicus/fts.
* fts.postinst: Fix the check for user 'tftpd' being in group 'fuse'.
* fts.postrm: Do not fail to purge if the config file is not there.
(Closes: #674007)
* fts.postrm: Fix debconf usage during purge. Load the module before doing
any actions (this re-execs the postinst). Move #DEBHELPER# token to the
end s.t. we can do db_get before db_purge is run.
* Ship default config as /usr/share/fts/config, postinst may not rely on
/usr/share/doc/fts/config (Policy 12.3).
* Do not ship /etc/fts/config as a conffile, postinst generates it.
* Register and purge /etc/fts/config with ucf/ucfr.
* Ship empty /var/lib/tftpboot directory.
Checksums-Sha1:
71838dcd40954dfe96508007ef609ca095e66af7 1965 fts_1.1-1.1.dsc
71a6a83ec9140ffc54208d1af9a228fe19de0acb 12300 fts_1.1-1.1.debian.tar.gz
65654705dfd9d45fbbe73ef339c24bab929c9f56 18996 fts_1.1-1.1_all.deb
b66a30494734d4fbe3ab774805dbc50202595def 7296 fts-fai-ldap_1.1-1.1_all.deb
0c4b095709eb657548335ad07eac2fb476ac8077 5816 fts-clacks_1.1-1.1_all.deb
77a9c5caf800f63e3a1e8c0577db5366100b7b53 7072 fts-ltsp-ldap_1.1-1.1_all.deb
6a132403ed0d584827394929019aa9fa8fd63dce 6488 fts-opsi_1.1-1.1_all.deb
Checksums-Sha256:
e31ff84cf77657d0c1cec36f51544b73ad0d3cb3c37ff3a425ec2f1fc5ee1859 1965
fts_1.1-1.1.dsc
9ca8ad965c98df6298a6261c4676bb0dff46a162517bef433d34b1e65fd43446 12300
fts_1.1-1.1.debian.tar.gz
59b3debfb771de96309bd28e3857dea64a690794e8296432ec10346557032343 18996
fts_1.1-1.1_all.deb
95eea74a3f26744f74a148adb4c30b3d1401ae62508f9bece6cd11d321faed45 7296
fts-fai-ldap_1.1-1.1_all.deb
4d38aca71bedd494187006895c7fd42068eb9b2e87dfcd518e0799d0bb935aa6 5816
fts-clacks_1.1-1.1_all.deb
aaa5b8b8ff579046d85cee18350d1656047fd44e751362bab955af8a9df21105 7072
fts-ltsp-ldap_1.1-1.1_all.deb
d378b66f7beea4654db77396b7d6545bc666a494d4d5ed41c754fc02266783de 6488
fts-opsi_1.1-1.1_all.deb
Files:
5023fef41f2fc9f4c8eb74679455f9b4 1965 utils optional fts_1.1-1.1.dsc
2b6b69a97dfa4e103dde0d4c576b75a1 12300 utils optional fts_1.1-1.1.debian.tar.gz
97386f7d53a18306d772a3a8df6c09e1 18996 utils optional fts_1.1-1.1_all.deb
29eb2ec00e5c8c7a1af5a1e38a7af8d9 7296 utils optional
fts-fai-ldap_1.1-1.1_all.deb
fd2324cb6b4e126691929de0cb14b531 5816 utils optional fts-clacks_1.1-1.1_all.deb
1a5f04cd5801652a9dbbcabc95940215 7072 utils optional
fts-ltsp-ldap_1.1-1.1_all.deb
b1b182a0fe552d986deb59ab0ca25cb8 6488 utils optional fts-opsi_1.1-1.1_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCAAGBQJRICL2AAoJEF+zP5NZ6e0Ijz8P/RHlw1LfVufjy7Ih4DcCRGuL
wLHOs+o6RkTDrjWdZpicUsAykIJc6QYbi63iZYUKt53VFKUz4gluLNXPxmaqgYB1
MBOexRpM1XTV/+jedEu7HLUzveye1nZPq2hARcsbpmjmJkVpFPo5+8NX/79EfhqR
RVZTtq5PWna6v3jNizt7jmP3GlFeoyFsyQnOy4yaKqyCukWcEif1asKZP1lDULDG
CL4cNTDaVqOd5j2S6+Kf2//CoVgOxejqSlkMK24zmuP9k+HdWN9EpSIShNHClZHg
XGWjGUtNkvDUbmSp2TOf201fANZN6+4ABNP8JuGWhyq3zB4iIEULrLys2Gfk4crl
rpZ63e7I5jEG+JktnkADvI+LeehNWE6Ml5OZHXp68/AkCoWwEfEOEbZhj1f3ZhO4
so7rexwVGkdhMqRNayqhvupgAjIe4AfYJgSmCviuubdUoLiBgQFV3H1k9eZGDMLA
svJGLVf7kIgjwnNLQvK+UJPR17mT9+xL+mvIMjP9Hu7CIVvCpMxupTdrNy6p99kz
n9PfP5UD3osrqHUbJ9se1lw6GEt4Jw2ntNQllKHc427Lu0330ncu74ivxLCZ2TVl
fqkG7hnwiVEoLw2CVA304CtkEz0PzzFFJwp8QO+wr7bUvaFb/1CCYoeN2TiKXLYF
jhYxGU3yZMmJ7qMv70s0
=lDrS
-----END PGP SIGNATURE-----
--- End Message ---
