Your message dated Sat, 01 Dec 2012 16:02:47 +0000
with message-id <e1tepwh-0004w3...@franck.debian.org>
and subject line Bug#693136: fixed in pptpd 1.3.4-5.2
has caused the Debian Bug report #693136,
regarding pptpd: Binary trash when launching ppp
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
693136: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=693136
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: pptpd
Version: 1.3.4-5.1
Severity: important
Dear Maintainer,
This is my /etc/pptpd.conf:
option /etc/ppp/pptpd-options
debug
noipparam
logwtmp
localip 192.168.0.4
remoteip 192.168.0.33-34
And this is my /etc/ppp/pptpd-options:
name pptpd
refuse-pap
refuse-chap
refuse-mschap
require-mschap-v2
require-mppe-128
proxyarp
nodefaultroute
debug
lock
nobsdcomp
The problem I'm getting is that pptpd calls pppd with invalid argument.
Take a look at my syslog:
Nov 13 09:27:39 rigel pptpd[7342]: CTRL (PPPD Launcher): remote address =
192.168.0.33
Nov 13 09:27:39 rigel pppd[7342]: unrecognized option
'<FF><FF><FF>#177<FE>...'
The problem is in this session of the pptpctrl.c (line 763)
if (*pppaddrs[0] || *pppaddrs[1]) {
char pppInterfaceIPs[33];
sprintf(pppInterfaceIPs, "%s:%s", pppaddrs[0], pppaddrs[1]);
pppd_argv[an++] = pppInterfaceIPs;
}
pppInterfaceIPs is declared as a local variable and is not valid outside
the if statement, but it's appended on a global variable, leading to the
problem. the following patch solves the problem:
--- pptpctrl.c 2012-11-13 11:30:52.000000000 -0200
+++ pptpctrl.c.mine 2012-11-13 11:31:19.000000000 -0200
@@ -759,8 +759,8 @@
syslog(LOG_DEBUG, "CTRL (PPPD Launcher): remote address = %s",
pppaddrs[1]);
}
+ char pppInterfaceIPs[33];
if (*pppaddrs[0] || *pppaddrs[1]) {
- char pppInterfaceIPs[33];
sprintf(pppInterfaceIPs, "%s:%s", pppaddrs[0], pppaddrs[1]);
pppd_argv[an++] = pppInterfaceIPs;
}
Thanks in advance!
-- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1,
'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 3.2.0-rc7-amd64 (SMP w/2 CPU cores)
Locale: LANG=pt_BR.utf8, LC_CTYPE=pt_BR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages pptpd depends on:
ii bcrelay 1.3.4-5.1
ii debconf [debconf-2.0] 1.5.46
ii libc6 2.13-36
ii libwrap0 7.6.q-24
ii netbase 5.0
ii ppp 2.4.5-5.1+b1
--- End Message ---
--- Begin Message ---
Source: pptpd
Source-Version: 1.3.4-5.2
We believe that the bug you reported is fixed in the latest version of
pptpd, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 693...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Maximiliano Curia <m...@debian.org> (supplier of updated pptpd package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 28 Nov 2012 16:21:01 +0100
Source: pptpd
Binary: pptpd bcrelay
Architecture: source amd64
Version: 1.3.4-5.2
Distribution: unstable
Urgency: low
Maintainer: Rene Mayrhofer <rm...@debian.org>
Changed-By: Maximiliano Curia <m...@debian.org>
Description:
bcrelay - Broadcast relay daemon
pptpd - PoPToP Point to Point Tunneling Server
Closes: 692129 693136
Changes:
pptpd (1.3.4-5.2) unstable; urgency=low
.
* Non-maintainer upload.
* Handle ENOBUFS gracefully.
Closes: #692129: pptpd: PPTP Connections Drop
* Programming error, reference to a stack variable used out of scope in
arguments to execvp call.
Closes: #693136: pptpd: Binary trash when launching ppp
Checksums-Sha1:
5b80424bfaf0d31e239c5ebcd3f92b4bfcb8abdf 1692 pptpd_1.3.4-5.2.dsc
e3527f5927f1381d4858bf5e487e62a269d14894 13110 pptpd_1.3.4-5.2.diff.gz
0266c0c243dc71562dc50d00ad5eb79be3fa82c3 99796 pptpd_1.3.4-5.2_amd64.deb
f697dbc32b8f017b8b6108d5a337fdaf98a8f70d 23632 bcrelay_1.3.4-5.2_amd64.deb
Checksums-Sha256:
5ae035b834dd6e1ff9a57f4b1cbfbab8ade5059eb0c4fc039cd83512c6764dc0 1692
pptpd_1.3.4-5.2.dsc
18aa3117a6963660e8a20ebe741efe5573c7ac929ad43f97a5f5158a1bbc7bbf 13110
pptpd_1.3.4-5.2.diff.gz
0508c6af1184d34b0a1d8ef2babc76fab615b7fc9f25cb0c261bfa8e4ec45119 99796
pptpd_1.3.4-5.2_amd64.deb
84e0a0177c7223b0acfc0d6b4c410d48b894b6684a112b527fde9cb38fd182f6 23632
bcrelay_1.3.4-5.2_amd64.deb
Files:
1a6abe35a8813bdbf6f0822af9b1af91 1692 net optional pptpd_1.3.4-5.2.dsc
23844f163ddd1bf4eaa04d3b8a4da7df 13110 net optional pptpd_1.3.4-5.2.diff.gz
8ef0b9726ec047f5abe08923068f41ea 99796 net optional pptpd_1.3.4-5.2_amd64.deb
d361b4239ad18efbaa7a1e3b39d76a7d 23632 net optional bcrelay_1.3.4-5.2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCAAGBQJQtjG0AAoJEMcZdpmymyMqDzIQAIDvLCF/aR+b2pQszWbM6xsz
N03M+wM4d8978/QoH4TMun/CGXXV81sMOd7LdtbP5G54WJslHPotjZMunqFZzSr2
IgOB6YklikhKLjnlUxBsF/khOQBvQtXEzTjEd2KW1D2BfixglUN6qBebIG+IwjAf
Tr/OBfOcNri3NIKmQlxGKSWB3fzPRWLQWtBh+YnkSKLqPPkO9ZXquuf03gyfnATx
mzbzJxbA2LVaXV5eAsvnNbWCaKeiJEHNiXABNnZHAFhzkr8yoGq0rFmV7hwVnpyU
SwrCiiC6VwRFDkde8OPCAGUpBn9Lr075VuhR9fZekHBsXtha0uA9WzBre9Q91QAN
k/Opop04J9qK/CFJyUiT9pUIxJg4OF3pPE0kzWCGB18FZ+m0ZrjK7OUbyy4nMci7
61jdoPKb/O981n1V8lPPyG1fyzttddshIsSJqspWWQsoKNxJ+IlP3RCgmtTGoAZf
qqls/w56NiwmaRT8biojTQBBtAdt8t2MeTZ1HGmhDxTRj4bvJnA6/YIcn5NqWjfU
y1jS7eZKaZ95LPQP0cAmL6h9f/rRKz8DRjBLWaqOxtAg9bCbccq2Twdb3c/3nmRg
DYRgUEHX4jbvHekNR0cuCdEqA4M1xwrfa4RpZMKDyxVg9F/6HQue6VpXn0teIaKK
o7d93fz34kwdYZHvjLNB
=TnQ7
-----END PGP SIGNATURE-----
--- End Message ---
