Bug#694486: lib/LWP/Authen/Wsse.pm uses Digest::SHA1

[Salvatore Bonaccorso]

Control: tags -1 + pending

Hi

On Mon, Nov 26, 2012 at 08:50:34PM +0100, Ansgar Burchardt wrote:
> Package: liblwp-authen-wsse-perl
> Version: 0.05-1
> Severity: serious
> 
> lib/LWP/Authen/Wsse.pm uses Digest::SHA1 which is no longer in Debian.
> It should use Digest::SHA instead which is part of the core modules
> included with the perl interpreter since 5.10.
> 
> In most cases just replacing Digest::SHA1 by Digest::SHA should be
> enough.  Also change Digest/SHA1.pm to Digest/SHA.pm.

The attached patch should solve, #694486. But I have not yet pushed
the changes to git.

Salvatore

From 384e1f6b6b5d4fd2aeb68becefabeda998f9beb5 Mon Sep 17 00:00:00 2001
From: Salvatore Bonaccorso <car...@debian.org>
Date: Tue, 27 Nov 2012 17:36:57 +0100
Subject: [PATCH] Use Digest::SHA instead of Digest::SHA1

libdigest-sha1-perl package was reoved from Debian. Digest::SHA is part
of Perl core modules included with the perl interpreter since 5.10.

Thanks: Ansgar Burchardt <ans...@debian.org>
Closes: #694486
---
 lib/LWP/Authen/Wsse.pm |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/LWP/Authen/Wsse.pm b/lib/LWP/Authen/Wsse.pm
index a5d9046..bb26283 100644
--- a/lib/LWP/Authen/Wsse.pm
+++ b/lib/LWP/Authen/Wsse.pm
@@ -6,7 +6,7 @@ use English qw( -no_match_vars );
 
 $LWP::Authen::Wsse::VERSION = '0.05';
 
-use Digest::SHA1 ();
+use Digest::SHA  ();
 use MIME::Base64 ();
 
 =head1 NAME
@@ -75,7 +75,7 @@ sub authenticate {
     my $nonce     = $class->make_nonce;
     my $nonce_enc = MIME::Base64::encode_base64( $nonce, WITHOUT_LINEBREAK );
     my $digest    = MIME::Base64::encode_base64(
-        Digest::SHA1::sha1( $nonce . $now . $pass ), WITHOUT_LINEBREAK
+        Digest::SHA::sha1( $nonce . $now . $pass ), WITHOUT_LINEBREAK
     );
 
     my $auth_header = ( $proxy ? 'Proxy-Authorization' : 'Authorization' );
@@ -114,7 +114,7 @@ sub authenticate {
 }
 
 sub make_nonce {
-    Digest::SHA1::sha1( time() . {} . rand() . $PID );
+    Digest::SHA::sha1( time() . {} . rand() . $PID );
 }
 
 sub now_w3cdtf {
-- 
1.7.10.4

signature.asc
Description: Digital signature