Control: reopen 689769 On Sat, Nov 3, 2012 at 13:58:38 +0000, Ulrich Dangel wrote:
> tags 689769 + pending
> thanks
>
> Dear maintainer,
>
> I've prepared an NMU for ample (versioned as 0.5.7-6.1) and
> uploaded it to DELAYED/5. Please feel free to tell me if I
> should delay it longer.
>
> Regards.
> diff -u ample-0.5.7/debian/postrm ample-0.5.7/debian/postrm
> --- ample-0.5.7/debian/postrm
> +++ ample-0.5.7/debian/postrm
> @@ -5,12 +5,7 @@
> case "$1" in
> purge|remove)
> if [ -d /var/run/ample ]; then
> - rmdir /var/run/ample
> -
> - # delete override if exists
> - if dpkg-statoverride --list /var/run/ample >/dev/null; then
> - dpkg-statoverride --remove /var/run/ample >/dev/null
> - fi
> + rmdir /var/run/ample || true
> fi
> ;;
Why are you ignoring errors?
> upgrade|abort-upgrade|failed-upgrade|abort-install|disapper)
> diff -u ample-0.5.7/debian/init.d ample-0.5.7/debian/init.d
> --- ample-0.5.7/debian/init.d
> +++ ample-0.5.7/debian/init.d
> @@ -1,13 +1,13 @@
> #! /bin/sh
> ### BEGIN INIT INFO
> # Provides: ample
> -# Required-Start: $network
> -# Required-Stop:
> +# Required-Start: $remote_fs $network
> +# Required-Stop: $remote_fs
> # Default-Start: 2 3 4 5
> # Default-Stop: 0 1 6
> # Short-Description: Ample MP3 server
> # Description: Simple MP3 Server
> -#
> +#
> ### END INIT INFO
>
> # Author: Rene Mayorga <rmayo...@debian.org.sv>
> @@ -27,8 +27,8 @@
> # Read configuration variable file if it is present
> [ -r /etc/default/$NAME ] && . /etc/default/$NAME
>
> -if [ -z "$STARTAMPLE" ] ; then
> - exit 0
> +if [ -z "$STARTAMPLE" ] ; then
> + exit 0
> fi
>
> if [ "$STARTAMPLE" != "no" ] ; then
> @@ -43,6 +43,13 @@
>
> . /lib/lsb/init-functions
>
> +if ! [ -d /var/run/ample ] ; then
> + mkdir -p /var/run/ample || true
Why are you
1) using -p
2) ignoring errors
?
> + if [ -d /var/run/ample ] ; then
> + chown ${DEFUSER:-nobody}:${DEFGROUP:-nogroup} /var/run/ample
> + fi
The whole point of nobody/nogroup is they don't own anything. This is
broken.
> +fi
> +
> do_start()
> {
> # Return
Cheers,
Julien
signature.asc
Description: Digital signature
