Some minor issues with what's currently committed to svn:

+  * Remove Cipher directory from upstream tarball (closes: #694336,

This is not quite accurate. Not the whole Cipher directory was removed, and some files outside this directories were removed.

+DEB_DIRECTORY := $(dir $(firstword $(MAKEFILE_LIST)))
+DEB_VERSION := $(word 2,$(shell cd $(DEB_DIRECTORY)/.. && dpkg-parsechangelog 
| grep ^Version:))
+UPSTREAM_DFSG_VERSION := $(firstword $(subst -, ,$(DEB_VERSION)))

I'd recommend using "=" instead of ":=" here. Otherwise they will be needlessly evaluated (multiple times, thanks to how dh works) even when they're not used.

+get-orig-source:
+       sh $(dir $(firstword $(MAKEFILE_LIST)))/get-orig-source.sh 
$(UPSTREAM_DFSG_VERSION)

Here you could use DEB_DIRECTORY, which you defined earlier.

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to