Your message dated Tue, 20 Nov 2012 00:48:07 +0000 with message-id <e1tac0v-0000qa...@franck.debian.org> and subject line Bug#693736: fixed in rawtherapee 4.0.9-4 has caused the Debian Bug report #693736, regarding rawtherapee: Corrupt EXIF MarkerNote for some Canon cameras to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 693736: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=693736 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: rawtherapee Version: 4.0.9-3 Severity: normal Tags: upstream patch Hi, RawTherapee corrupts Exif MarkerNotes for some Canon cameras. This was reported on upstreams bugtracker: http://code.google.com/p/rawtherapee/issues/detail?id=615 and already fixed with the attached one line patch. This data corruption affects at least the following Canon cameras: EOS 450D, EOS 350D, EOS 50D, EOS 60D and EOS 600D These cameras are all often used so a lot of people will experience this problem. The bug can be fixed by using the correct size for multibyte EXIF tags which use TagDirectoryTable. It's tested upstream for five month now and no problem was reported so I think it's safe. To reproduce: 1. Get Canon EOS 450D raw file: http://www.rawsamples.ch/raws/canon/450d/RAW_CANON_450D.CR2 2. Process with Rawtherapee and save as jpeg (RAW_CANON_450D_RT.jpg) 3. With exiftool examine the exif information: exiftool -v RAW_CANON_450D.CR2 and exiftool -v RAW_CANON_450D_RT.jpg After that the Exif SubDirectory "MarkerNoteCanon" is corrupted: | | 13) MakerNoteCanon (SubDirectory) --> | | + [MakerNotes directory with 26 entries] | | | Warning = [minor] Overlapping MakerNotes values | | | 0) CanonCameraSettings (SubDirectory) --> | | | Warning = Invalid CanonCameraSettings data | | | 1) CanonFocalLength (SubDirectory) --> | | | + [BinaryData directory, 16 bytes] | | | | FocalType = 0 | | | | FocalLength = 50 Here the correct data after applying the patch: | | 13) MakerNoteCanon (SubDirectory) --> | | + [MakerNotes directory with 26 entries] | | | 0) CanonCameraSettings (SubDirectory) --> | | | + [BinaryData directory, 94 bytes] | | | | MacroMode = 2 | | | | SelfTimer = 0 | | | | Quality = 4 | | | | CanonFlashMode = 0 | | | | ContinuousDrive = 0 | | | | FocusMode = 0 | | | | RecordMode = 7 | | | | CanonImageSize = 0 | | | | EasyMode = 1 | | | | DigitalZoom = 0 | | | | Contrast = 0 | | | | Saturation = 0 | | | | Sharpness = 32767 | | | | CameraISO = 32767 | | | | MeteringMode = 3 | | | | FocusRange = 2 | | | | AFPoint = 0 | | | | CanonExposureMode = 3 | | | | LensType = 10 | | | | LongFocal = 50 | | | | ShortFocal = 50 | | | | FocalUnits = 1 | | | | MaxAperture = 96 | | | | MinAperture = 352 | | | | FlashActivity = 0 | | | | FlashBits = 0 | | | | FocusContinuous = -1 | | | | AESetting = -1 | | | | ImageStabilization = -1 | | | | DisplayAperture = 0 | | | | ZoomSourceWidth = 0 | | | | ZoomTargetWidth = 0 | | | | SpotMeteringMode = -1 | | | | PhotoEffect = -1 | | | | ManualFlashOutput = 0 | | | | ColorTone = 0 | | | | SRAWQuality = 0 | | | 1) CanonFocalLength (SubDirectory) --> | | | + [BinaryData directory, 8 bytes] | | | | FocalType = 0 | | | | FocalLength = 50 I consider the severity grave as it causes data loss and makes the program unusable for some/many users. Happy hacking, Philip -- System Information: Debian Release: wheezy/sid APT prefers testing APT policy: (990, 'testing'), (800, 'unstable'), (150, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores) Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages rawtherapee depends on: ii libatkmm-1.6-1 2.22.6-1 ii libbz2-1.0 1.0.6-4 ii libc6 2.13-35 ii libcairomm-1.0-1 1.10.0-1 ii libexpat1 2.1.0-1 ii libgcc1 1:4.7.2-4 ii libglib2.0-0 2.33.12+really2.32.4-3 ii libglibmm-2.4-1c2a 2.32.1-1 ii libgomp1 4.7.2-4 ii libgtk2.0-0 2.24.10-2 ii libgtkmm-2.4-1c2a 1:2.24.2-1 ii libiptcdata0 1.0.4-3 ii libjpeg8 8d-1 ii liblcms2-2 2.2+git20110628-2.2 ii libpangomm-1.4-1 2.28.4-1 ii libpng12-0 1.2.49-1 ii libsigc++-2.0-0c2a 2.2.10-0.2 ii libstdc++6 4.7.2-4 ii libtiff4 3.9.6-9 ii rawtherapee-data 4.0.9-3 rawtherapee recommends no packages. rawtherapee suggests no packages. -- no debconf informationAuthor: Upstream Description: Use correct size on all multibyte EXIF tags which use TagDirectoryTable --- a/rtexif/rtexif.cc +++ b/rtexif/rtexif.cc @@ -902,7 +902,7 @@ size += valuesize + (valuesize%2); // we align tags to even byte positions if (makerNoteKind!=NOMK) - count = directory[0]->calculateSize (); + count = directory[0]->calculateSize () / getTypeSize(type); if (makerNoteKind==NIKON3 || makerNoteKind==OLYMPUS2 || makerNoteKind==FUJI) size += valuesize;
--- End Message ---
--- Begin Message ---Source: rawtherapee Source-Version: 4.0.9-4 We believe that the bug you reported is fixed in the latest version of rawtherapee, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 693...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Philip Rinn <ri...@gmx.net> (supplier of updated rawtherapee package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Mon, 19 Nov 2012 21:11:43 +0000 Source: rawtherapee Binary: rawtherapee rawtherapee-data Architecture: source amd64 all Version: 4.0.9-4 Distribution: unstable Urgency: low Maintainer: Philip Rinn <ri...@gmx.net> Changed-By: Philip Rinn <ri...@gmx.net> Description: rawtherapee - Free RAW converter and digital photo processing software rawtherapee-data - Free RAW converter and digital photo processing software (data fi Closes: 693736 Changes: rawtherapee (4.0.9-4) unstable; urgency=low . * Fix RC bug that corrupts EXIF data in some cases (closes: #693736): - add debian/patches/03-fix_exif_corruption.patch: Use the correct size for multibyte EXIF tags which use TagDirectoryTable Checksums-Sha1: c164e1ad074cddb2860b7925ad047bc96c63b20e 2644 rawtherapee_4.0.9-4.dsc fb94aa9cc8e2135fc4f62e2639d6a9d84d3fef87 9634 rawtherapee_4.0.9-4.debian.tar.gz 8f1e7f3f9bd43ce3a3eecfb9a80f2593012f9f31 2770656 rawtherapee_4.0.9-4_amd64.deb b197ee63687617a0eeb9af91794c21f28b065934 7141298 rawtherapee-data_4.0.9-4_all.deb Checksums-Sha256: 33cbaab417a691a23c9728df7fd11bf0703d6c8b9b499328b1536c5d89ee148a 2644 rawtherapee_4.0.9-4.dsc ee91fb38ccd51dbd20a8ee3b10157b8c3cc9fa6023dcc1ecb54d5f4edb3f63e1 9634 rawtherapee_4.0.9-4.debian.tar.gz 79efd9be7c11607639d113408e10c1b0a13cca5de7c03eda32bbb3ea0651ba82 2770656 rawtherapee_4.0.9-4_amd64.deb 000b5813bbdc42d6227d68d5eef3f54122317dc2dbc04cef3473088b510bae65 7141298 rawtherapee-data_4.0.9-4_all.deb Files: 50845ce8a676ab370546e6ef7cc38a3f 2644 graphics optional rawtherapee_4.0.9-4.dsc 06e2ae44921dfa8c7fa75cc0804cdd6c 9634 graphics optional rawtherapee_4.0.9-4.debian.tar.gz 85c8b3e47f03338300c7e89e4251a164 2770656 graphics optional rawtherapee_4.0.9-4_amd64.deb 7db6f0b7ce67752e4760b91c3e0ea31c 7141298 graphics optional rawtherapee-data_4.0.9-4_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQQcBAEBCAAGBQJQqtBQAAoJELjWss0C1vRz2nsgAKxDnXCaki7PBwDjNYbe9m1k J5pDRl02WOs2fLHtjqJwyBCnq9ubvgIRpV1lsBeddy//8Oib3HBIT9kc43y7BNM6 oq5rxNxUxHAlzG3lRhjZm49M+Z8aoPusneEXrQkbkSo8lNSeH1sZ6hEHCb8qqIpa bG5JhTs9H4vjiBnWQOt8/6KWH8OpzSjHo4GGmtizFk/hQDkBxeW+XJPi0VIIS+7x QW4nqrCETjmV3PT4EAHEJ+TLTMx4lWUnwVrNA+VgVCMOW92hQHpdu0WO3rJPqlK1 3W3NRSGNAUd2MbAAfy3zb08cgmecO/mdI53p1kFDrIMqdANQelNzcTiuspiKyG12 IMl4wCEcmUi9mo/xxy/iXV01+KaGIt3h+bbNoLrzZtSxRE9yP88iGyyPlGqx4sLZ 83tcu93K+GyUaDaIhufRt4JH8A9HfZ68WoCIVG1C+HFYHrzr6vPQbvth4l3BILWf hUIzDbYTGwdWzIMCcs6hu8gfPk4viHiHbUgDmthPL1gNnbTc6RkPzDIa/2v2ZLUl jCA3R5SSdubnysdUyanR/bkNgRM3nWJREWyn24QbK/1J+NYS1QbPW3SCfc3ZrS7f jKi0w8snSo27NXdTIj2L2zNnfeGnG1t0HOg5sy/C4BlSNzIPV/1J3lgc79rNRC1+ C/HOx+96bAWJ+eeJakdJPtsykapkRRca9gurBM+ipRW5TlaQ3iuF162sDxeRVAOs MzUm9QlpJrLbbH5Y+2CYApDuwZVVf7IgYny41ZvHghKkY7lem7i42JPk5FswMRJ0 0WJgE+dCS0M1PbJlfLB43SKIcDRVrkLYg1HDu+wd+Ebf1acOmNvhr/tVNertdiUR kIOY8wgQQfoi62ropiODMqlDc9E4TjULmiZV+vMz2ShKOnwbS+MQIFWXZzvYUYBy vJg/xn4q2l8yOKACt3fXU9uQraNMYkvpbpuT3ljodXIhcsMvDXsQbc3T8G+wcRft 73mribt75MZXdhwRHxC009pHFBsYoMRF2FJPOCbEbC3wF7ZMd/S7TzfIbe7PiBsR AeA6t5HOa/cPMEETB7JBuVboft7cdoKo2fROTUm0RPpPQXacws5UVMAjsCEGCe9M aVTuD6Fnn0xUZABzVSYw2ONCNvG3afWZA3CJDdyg93mMo+vm8Bq8QNPS7jUMDCTI 3pwAQGjBptyHVxrpWvf7LMgVpXPLotXCEYzy4BVMY1SzrvByyaGKET2hb4YxMzNc /NxX62oetCFWKoO+jUGba5+7tpOWmWkvpEfQzURSXDMCuwOFTaNDmOcsB1ilyjEZ mjUnKMvkb21tSUM0TC+eiBsRSRXU2vLzCenkiPlSPq+Tl0XEI/nFlE5Y/F3Cxmo= =CRwr -----END PGP SIGNATURE-----
--- End Message ---
