Source: broadcom-sta
Version: 5.100.82.112-7
Severity: grave

broadcom-sta wrongly detects Linux 3.x as supporting only WEXT.  It
therefore won't work with Network Manager and other applications that
use netlink for wireless configuration.  Marking as grave since this
makes it useless in a default desktop installation.

I'm attaching a patch that should fix the version checks.

Ben.

-- System Information:
Debian Release: wheezy/sid
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'proposed-updates'), (500, 
'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: i386 (x86_64)
Foreign Architectures: amd64

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
From: Ben Hutchings <b...@decadent.org.uk>
Subject: Use cfg80211 on Linux 3.x

The version checks for use of cfg80211 vs WEXT gave the wrong answer
for 3.x.

---
--- a/amd64/Makefile
+++ b/amd64/Makefile
@@ -16,7 +16,9 @@
 ifneq ($(KERNELRELEASE),)
 
   LINUXVER_GOODFOR_CFG80211:=$(strip $(shell \
-    if [ "$(VERSION)" -ge "2" -a "$(PATCHLEVEL)" -ge "6" -a "$(SUBLEVEL)" -ge "32" ]; then \
+    if [ "$(VERSION)" -ge "3" ]; then \
+      echo TRUE; \
+    elif [ "$(VERSION)" -eq "2" -a "$(PATCHLEVEL)" -eq "6" -a "$(SUBLEVEL)" -ge "32" ]; then \
       echo TRUE; \
     else \
       echo FALSE; \
@@ -24,7 +26,9 @@ ifneq ($(KERNELRELEASE),)
   ))
 
     LINUXVER_WEXT_ONLY:=$(strip $(shell \
-    if [ "$(VERSION)" -ge "2" -a "$(PATCHLEVEL)" -ge "6" -a "$(SUBLEVEL)" -ge "17" ]; then \
+    if [ "$(VERSION)" -ge "3" ]; then \
+      echo FALSE; \
+    elif [ "$(VERSION)" -eq "2" -a "$(PATCHLEVEL)" -eq "6" -a "$(SUBLEVEL)" -ge "17" ]; then \
       echo FALSE; \
     else \
       echo TRUE; \
--- a/i386/Makefile
+++ b/i386/Makefile
@@ -16,7 +16,9 @@
 ifneq ($(KERNELRELEASE),)
 
   LINUXVER_GOODFOR_CFG80211:=$(strip $(shell \
-    if [ "$(VERSION)" -ge "2" -a "$(PATCHLEVEL)" -ge "6" -a "$(SUBLEVEL)" -ge "32" ]; then \
+    if [ "$(VERSION)" -ge "3" ]; then \
+      echo TRUE; \
+    elif [ "$(VERSION)" -eq "2" -a "$(PATCHLEVEL)" -eq "6" -a "$(SUBLEVEL)" -ge "32" ]; then \
       echo TRUE; \
     else \
       echo FALSE; \
@@ -24,7 +26,9 @@ ifneq ($(KERNELRELEASE),)
   ))
 
     LINUXVER_WEXT_ONLY:=$(strip $(shell \
-    if [ "$(VERSION)" -ge "2" -a "$(PATCHLEVEL)" -ge "6" -a "$(SUBLEVEL)" -ge "17" ]; then \
+    if [ "$(VERSION)" -ge "3" ]; then \
+      echo FALSE; \
+    elif [ "$(VERSION)" -eq "2" -a "$(PATCHLEVEL)" -eq "6" -a "$(SUBLEVEL)" -ge "17" ]; then \
       echo FALSE; \
     else \
       echo TRUE; \

Reply via email to