Your message dated Thu, 15 Nov 2012 08:47:31 +0000 with message-id <e1tyv6h-00058s...@franck.debian.org> and subject line Bug#689898: fixed in lyskom-server 2.1.2-13 has caused the Debian Bug report #689898, regarding Ships a folder in /var/run or /var/lock (Policy Manual section 9.3.2) to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 689898: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=689898 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: lyskom-server Version: 2.1.2-12 Severity: serious Tags: patch Dear Maintainer, Andreas Beckmann <deb...@abeckmann.de> reported in -devel that your package (as well as 27 others) ships a folder either in /var/run or /var/lock. This is forbidden by policy. Lintian detects the problem and warns as follow: /var/run may be a temporary filesystem, so any directories or files needed /there must be created dynamically at boot time. Refer to Debian Policy Manual section 9.3.2 (Writing the scripts) for details. Severity: serious, Certainty: possible Check: files, Type: binary, udeb which is why I am reporting this bug with severity serious (and there fore, release critical). Please fix your package. I have attached what I believe is a good fix the problem, however, I haven't tried it, and I haven't tested if something more for creating the necessary folder at runtime should be added. Please make sure to test before applying the patch blindly. Cheers, Thomas Goirand (zigo)diff -u lyskom-server-2.1.2/debian/lyskom-server.dirs lyskom-server-2.1.2/debian/lyskom-server.dirs --- lyskom-server-2.1.2/debian/lyskom-server.dirs +++ lyskom-server-2.1.2/debian/lyskom-server.dirs @@ -7 +6,0 @@ -var/run/lyskom-server diff -u lyskom-server-2.1.2/debian/changelog lyskom-server-2.1.2/debian/changelog --- lyskom-server-2.1.2/debian/changelog +++ lyskom-server-2.1.2/debian/changelog @@ -1,3 +1,11 @@ +lyskom-server (2.1.2-12.1) unstable; urgency=low + + * Non-maintainer upload. + * Fixes wrong handling of var/run/lyskom-server life cycle (Closes: #XXXXXX). + * Now uses lsb-base to display messages. + + -- Thomas Goirand <z...@debian.org> Sat, 06 Oct 2012 21:05:23 +0800 + lyskom-server (2.1.2-12) unstable; urgency=low * Added Danish translation of Debconf templates. diff -u lyskom-server-2.1.2/debian/lyskom-server.init.d lyskom-server-2.1.2/debian/lyskom-server.init.d --- lyskom-server-2.1.2/debian/lyskom-server.init.d +++ lyskom-server-2.1.2/debian/lyskom-server.init.d @@ -19,6 +19,9 @@ ### END INIT INFO PATH=/sbin:/bin:/usr/sbin:/usr/bin +DESC="LysKOM server" +NAME=komrunning +RUNDIR=/var/run/lyskom-server if [ -f /etc/default/lyskom-server ]; then . /etc/default/lyskom-server @@ -26,28 +29,42 @@ test -x /usr/sbin/komrunning || exit 0 +. /lib/lsb/init-functions + +start_lyskom (){ + if [ ! -d ${RUNDIR} ] ; then + mkdir -p ${RUNDIR} + if [ -d ${RUNDIR} ] ; then + chown lyskom:nogroup ${RUNDIR} + fi + fi + /usr/sbin/komrunning start + return $? +} + case "$1" in start) + log_begin_msg "Starting ${DESC}" ${NAME} if test "$startonboot" = "NO"; then - echo "Automatic start of the LysKOM server from /etc/init.d is disabled." + log_failure_msg "Automatic start of the LysKOM server from /etc/init.d is disabled." else - sh $0 force-start + start_lyskom fi + log_end_msg 0 ;; force-start) - echo -n "Signalling start of LysKOM server" - mkdir -p /var/run/lyskom-server - /usr/sbin/komrunning start - echo "." + log_begin_msg "Starting ${DESC}" ${NAME} + start_lyskom + log_end_msg 0 ;; stop) - echo -n "Stopping LysKOM server" + log_begin_msg "Stopping ${DESC}" ${NAME} /usr/sbin/komrunning stop - rm -f /var/run/lyskom-server/pid - rm -f /var/run/lyskom-server/status - echo "." + rm -f ${RUNDIR}/pid + rm -f ${RUNDIR}/status + log_end_msg 0 ;; restart|force-reload)
--- End Message ---
--- Begin Message ---Source: lyskom-server Source-Version: 2.1.2-13 We believe that the bug you reported is fixed in the latest version of lyskom-server, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 689...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Magnus Holmgren <holmg...@debian.org> (supplier of updated lyskom-server package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Thu, 15 Nov 2012 09:26:58 +0100 Source: lyskom-server Binary: lyskom-server Architecture: source amd64 Version: 2.1.2-13 Distribution: unstable Urgency: low Maintainer: Magnus Holmgren <holmg...@debian.org> Changed-By: Magnus Holmgren <holmg...@debian.org> Description: lyskom-server - Server for the LysKOM conference system Closes: 689898 Changes: lyskom-server (2.1.2-13) unstable; urgency=low . * New maintainer. * Rename debian/lyskom-server.copyright debian/copyright as a source package should have a debian/copyright file. * Create /var/run/lyskom-server in the init script instead of shipping it with the package (Closes: #689898). Thanks Thomas Goirand. * Drop the $startonboot variable, which is rather pointless since lyskomd is actually started via cron, is disabled there by default, and will start regardless of $startonboot because the status file won't exist. * Fix LSB header in the init script: add $remote_fs and move $local_fs to Required-Start/Required-Stop; delete commas. * Add dependency on rsyslog | system-log-daemon, since the LSB header indicates that lyskomd requires a syslog facility. * Rework and simplify lyskom-server.postinst: * Use dpkg-statoverride to set ownership of data and log directories. * Don't nullify errors; the package should be left in an unconfigured state in such cases. Remove sanity checks. * Simply call adduser with --quiet instead of checking whether the lyskom user already exists. * Set stricter modes on the directories. * Don't delete /var/run/lyskom-server/status in the init script. It is created by komrunning when shutting down lyskomd to keep updateLysKOM from starting lyskomd again. * lyskom-server.postrm: As recommended by policy, don't delete log files until on purge. Also, simply rm -rf /var/lib/lyskom-server /var/log/lyskom-server. * Add dependendy on cron | cron-daemon, since that's how lyskomd is started. * debian/rules: Add build-indep and build-arch targets. Checksums-Sha1: 7c6a1c4c441574a862cc1522b46c2c2b1f6d98d4 1280 lyskom-server_2.1.2-13.dsc 8dadcfe1f46c5f0e3ff047e77dd3c987b2738620 62669 lyskom-server_2.1.2-13.diff.gz c084e5b23b227c13a5a6aff95bf1b5d6f1b394b5 647948 lyskom-server_2.1.2-13_amd64.deb Checksums-Sha256: fd9628bdd65bf7786f6585cec101ac7dc4bac76c15c4419d4d48545a4ac20bbe 1280 lyskom-server_2.1.2-13.dsc af01b4e8fbebf8883471391e6807dcc93785ed4add83dadc514c1dc562cc6396 62669 lyskom-server_2.1.2-13.diff.gz 882f09741a5cf9c629b538adfd2e2c1f2a70e6938d0e047c7efa8e5330537f27 647948 lyskom-server_2.1.2-13_amd64.deb Files: 1fece314f4803dfe45d36e2ac8807f9a 1280 net extra lyskom-server_2.1.2-13.dsc 05b7a0c157a4f8f203b69cc954330534 62669 net extra lyskom-server_2.1.2-13.diff.gz 596765d230abdef75ad3b7a98858f807 647948 net extra lyskom-server_2.1.2-13_amd64.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEAREIAAYFAlCkqI8ACgkQk7mRNn1h4+birQCggaXT3jXWiMZUgFT+YjfiPMji pQgAnRxYi1clnvrRDGHEjFg+40SS8Y9k =iIRw -----END PGP SIGNATURE-----
--- End Message ---
