On Sat, 10 Nov 2012 13:28:28 +1030, Ron wrote: > > On Fri, 09 Nov 2012 09:51:05 +1030, Ron wrote: > > The term "trivial" triggered me into trying it myself. > I'd hoped so :) I've got a small mountain of backlog still to dig through > right now, and this still isn't anywhere near the top of it just yet, so > that's much appreciated!
You're welcome. And great that you found the time to look a bit further and also discuss with the release team today, thanks. > > The attached patch adds -lGL to LIBS in overlay_gl/overlay_gl.pro > > which seems to determine the libmumble build. > Indeed. Minor nit, I'd probably put -lGL at the front of that list, > but mostly that's an old habit from when order mattered with one-pass > static lib linking - it's less of a deal if this is shared libs only. > > so LIBS *= -lGL -lrt -ldl instead of LIBS *= -lrt -ldl -lGL Ok, fine. > > - libmumble is linked against libGL (and many more things (?)): > That's fine, that's just ldd resolving the full chain of all things > that libs libmumble depends on depend on too. That was my assumption too, thanks for the confirmation. > (I had a quick dig through this myself, since I figured if I was > asserting it was trivial, it would probably pay to be sure of that, > and this tossed an extra layer of uncertaintly into the mix) :) On Sat, 10 Nov 2012 16:34:36 +1030, Ron wrote: > > So I guess the two interesting questions remaining now are: > > > > - Does it actually work! > > - and when do we want to upload it if it does ... > > Ok, so I just knocked up a quick and dirty test jig here for what > libmumble is doing, and it looks like my late fears about the first > point appear to be (most pleasantly!) unfounded. > > I can run: > > $ MUMBLE_OVERLAY_DEBUG=1 LD_PRELOAD=./libmumble.so.1.2.4 glxgears > > And it appears to be intercepting the needed glX calls exactly as > it ought to. I've tried this now, both with MUMBLE_OVERLAY_DEBUG=1 LD_PRELOAD=/usr/lib/mumble/libmumble.so.1.2.4 glxgears and MUMBLE_OVERLAY_DEBUG=1 mumble-overlay glxgears What I get is a short flicker, and the following output: MumbleOverlay: Mumble overlay library loaded MumbleOverlay: Iterating dlsym table 0x7fdebbb70348 0x7fdebbb706f0 39 MumbleOverlay: Original dlsym at 0x7fdebbb71030 MumbleOverlay: Request for symbol __driDriverExtensions (0x101d880:0x7fdebbb71030) Running synchronized to the vertical refresh. The framerate should be approximately the same as the monitor refresh rate. MumbleOverlay: Current context is: 0x101a950 MumbleOverlay: GLX version 1.4 MumbleOverlay: OpenGL Version 3.0 Mesa 8.0.5, Vendor Tungsten Graphics, Inc, Renderer Mesa DRI Intel(R) Sandybridge Mobile , Shader 1.30 MumbleOverlay: VERTEX: MumbleOverlay: FRAGMENT: X Error of failed request: GLXBadDrawable Major opcode of failed request: 154 (GLX) Minor opcode of failed request: 29 (X_GLXGetDrawableAttributes) Serial number of failed request: 33 Current serial number in output stream: 33 Is this the expected outcome? On Sat, 10 Nov 2012 19:54:41 +1030, Ron wrote: > On Sat, Nov 10, 2012 at 01:28:28PM +1030, Ron wrote: > > So I guess the two interesting questions remaining now are: > > > > - Does it actually work! > > - and when do we want to upload it if it does ... > > And as for the second, the best plan for -release at present would seem > to be to hold off on uploading the fix for this until they've had a > chance to review what's currently in unstable, and then we'll push this > as a separate fix after that. And thanks to adsb, -2.1 is unblocked now and should migrate to testing in the next hours \o/ So we can indeed concentrate on this GL issue separately now. > If people want to run some more tests in the meantime to ensure there is > nothing else we need to push with that, that would probably be a good idea. Ack; unfortunately I'm not the best candidate when it comes to games or voip ... I'm attaching a new debdiff, that re-orders the LIBS and adds some headers to the patch. Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Tom Waits: I Never Talk To Strangers
diff -Nru mumble-1.2.3-349-g315b5f5/debian/changelog mumble-1.2.3-349-g315b5f5/debian/changelog --- mumble-1.2.3-349-g315b5f5/debian/changelog 2012-10-14 18:37:03.000000000 +0200 +++ mumble-1.2.3-349-g315b5f5/debian/changelog 2012-11-10 02:06:26.000000000 +0100 @@ -1,3 +1,14 @@ +mumble (1.2.3-349-g315b5f5-2.2) UNRELEASED; urgency=low + + * Non-maintainer upload. + * Fix "Plugins: Failed to load libmumble.so: Cannot load library + /usr/lib/mumble/libmumble.so: (/usr/lib/mumble/libmumble.so: + undefined symbol: glPopClientAttrib)": + new patch 30-opengl: link libmumble against libGL + (Closes: #691535) + + -- gregor herrmann <gre...@debian.org> Sat, 10 Nov 2012 02:02:10 +0100 + mumble (1.2.3-349-g315b5f5-2.1) unstable; urgency=low * Non-maintainer upload. diff -Nru mumble-1.2.3-349-g315b5f5/debian/patches/30-opengl mumble-1.2.3-349-g315b5f5/debian/patches/30-opengl --- mumble-1.2.3-349-g315b5f5/debian/patches/30-opengl 1970-01-01 01:00:00.000000000 +0100 +++ mumble-1.2.3-349-g315b5f5/debian/patches/30-opengl 2012-11-10 21:31:16.000000000 +0100 @@ -0,0 +1,18 @@ +Description: libmumble needs to be linked against libGL +Origin: vendor +Bug-Debian: http://bugs.debian.org/691535 +Forwarded: no +Author: gregor herrmann <gre...@debian.org> +Last-Update: 2012-11-10 + +--- a/overlay_gl/overlay_gl.pro ++++ b/overlay_gl/overlay_gl.pro +@@ -7,7 +7,7 @@ + TARGET = mumble$(TARGET_ADD) + VERSION = 1.2.4 + SOURCES = overlay.c +-LIBS *= -lrt -ldl ++LIBS *= -lGL -lrt -ldl + QMAKE_CFLAGS *= -fvisibility=hidden $(CFLAGS_ADD) + QMAKE_LFLAGS -= -Wl,--no-undefined + QMAKE_LFLAGS *= $(LFLAGS_ADD) diff -Nru mumble-1.2.3-349-g315b5f5/debian/patches/series mumble-1.2.3-349-g315b5f5/debian/patches/series --- mumble-1.2.3-349-g315b5f5/debian/patches/series 2012-10-14 18:36:54.000000000 +0200 +++ mumble-1.2.3-349-g315b5f5/debian/patches/series 2012-11-10 02:04:36.000000000 +0100 @@ -5,3 +5,4 @@ 15-fix-noise-in-opus-mode 20-add-opus-threshold-option 25-add-codec-warnings +30-opengl
signature.asc
Description: Digital signature
