Control: tags -1 + patch

On 9 November 2012 04:15, Ludovic Courtès <l...@gnu.org> wrote:
> Your analysis makes perfect sense to me.

Thanks.

>
>> commit e13f1cbdffa4f333d9866d1b22cd2c9a3b17b3bd
>> Author: Ludovic Courtes <ludovic.cour...@laas.fr>
>> Date:   Sun Jun 25 22:43:20 2006 +0000
>>
>>     Fixed `guardians.test' so that it does not use symbols.
>
> In the context of 1.6/1.8, I’d first install the above patch and see
> whether it improves things.

This did not help, the tests still failed.

> Then, if that’s not enough, you may indeed relax the tests to (throw
> 'unresolved).  But make sure to do manual testing of guardians before
> you do.

On a linux-i386 machine that experiences the test failures, I have
manually confirmed that guardians do indeed work as documented:

$ ./pre-inst-guile --version | head -n1
Guile 1.6.8
$ ./pre-inst-guile
guile> (define g2 (make-guardian))
guile> (g2 (list (string-copy "g2-garbage")))
guile> (define g3 (make-guardian))
guile> (g3 (list (string-copy "g3-garbage")))
guile> (g3 g2)
guile> (set! g2 #f)
guile> (gc)
guile> (define saved #f)
guile> (do ((i 1 (1+ i)))
           ((> i 100)
            (set! saved (g3)))
         (apply + (iota 10)))
guile> saved
("g3-garbage")
guile> (set! saved #f)
guile> (do ((i 1 (1+ i)))
           ((> i 100)
            (set! saved (g3)))
         (apply + (iota 10)))
guile> saved
#<greedy guardian 0x90f36f0 (reachable: 0 unreachable: 1)>
guile> (saved)
("g2-garbage")
guile> (saved)
#f

which covers the same area as the failing tests.  The patch to relax
the tests makes the test-suite pass, and is ok for inclusion.

Andreas, I am not a DM, will you take care of this again?

Regards


--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to