On Fri, 02 Nov 2012 21:44:27 +0100, intrigeri wrote:

> gregor herrmann wrote (27 Oct 2012 15:51:05 GMT) :
> > Which means we need to create the symlink for new installs and for
> > upgrades from this range. Correct so far?
> I think so.

Good :)
 
> > Here's an attempt to implement this idea:
> [...]
> > -       if [ -z "$prevver" ] ; then
> > +       if [ -z "$prevver" ] || \
> > +           dpkg --compare-versions $prevver ge 1.4.6-1~ && \\

Hm, this "\\" does look like a typo ...

> > +           dpkg --compare-versions $prevver lt 1.4.7~ ; then
> >             # only create link on new installs
> > +           # or when upgrading from a version where it was removed 
> > unconditionally
> >                     ln -s ../../munin/apache.conf 
> > /etc/$webserver/conf.d/munin
> >         fi
> >         if [ -f $webserver_init_script ];then
> [...]
> > Please double-check if I got the logic right :)
> 
> Looks good to me.

Thanks!
 

Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Eagles

Attachment: signature.asc
Description: Digital signature

Reply via email to