Your message dated Thu, 01 Nov 2012 21:32:38 +0000
with message-id <e1tu2ns-00057e...@franck.debian.org>
and subject line Bug#536736: fixed in ncurses-hexedit 0.9.7-14.1
has caused the Debian Bug report #536736,
regarding ncurses-hexedit: Seg faults when you search for text that is not in
the file.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
536736: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=536736
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: ncurses-hexedit
Version: 0.9.7-14
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu jaunty ubuntu-patch
Here are the steps to repeat the problem.
1. Run hexeditor on a small file
2. ^W and choose "search for Hex bytes"
3. Enter a value not in the file and press enter, get "String not found", hit
enter to clear that dialog.
4. Hit ^W and choose "Find Next"
*** /tmp/tmpV4CbaG
In Ubuntu, we've applied the attached patch to achieve the following:
* src/windows.c: Fixes a crash which was caused by searching for
values that were not in the file being viewed.
Thanks to Jakob Hilmer for the patch. (LP: #122349)
We thought you might be interested in doing the same.
-- System Information:
Debian Release: 5.0
APT prefers jaunty-updates
APT policy: (500, 'jaunty-updates'), (500, 'jaunty-security'), (500, 'jaunty')
Architecture: i386 (i686)
Kernel: Linux 2.6.28-13-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -u ncurses-hexedit-0.9.7/debian/control ncurses-hexedit-0.9.7/debian/control
--- ncurses-hexedit-0.9.7/debian/control
+++ ncurses-hexedit-0.9.7/debian/control
@@ -1,7 +1,8 @@
Source: ncurses-hexedit
Section: editors
Priority: optional
-Maintainer: Manfred Lichtenstern <manf...@lichtenstern.biz>
+Maintainer: Ubuntu MOTU Developers <ubuntu-m...@lists.ubuntu.com>
+XSBC-Original-Maintainer: Manfred Lichtenstern <manf...@lichtenstern.biz>
Build-Depends: debhelper (>> 5.0.0), libncurses5-dev (>> 5.0.0)
Standards-Version: 3.8.0
diff -u ncurses-hexedit-0.9.7/debian/changelog ncurses-hexedit-0.9.7/debian/changelog
diff -u ncurses-hexedit-0.9.7/src/windows.c ncurses-hexedit-0.9.7/src/windows.c
--- ncurses-hexedit-0.9.7/src/windows.c
+++ ncurses-hexedit-0.9.7/src/windows.c
@@ -692,20 +692,21 @@
spot = boyer_moore_search (retr->str, offset + 1,
last_str_len = retr->len,
Globals.filesize - offset);
+ if (laststr)
+ free (laststr);
+ laststr = malloc (retr->len + 1);
+ memset (laststr, 0x00, retr->len + 1);
+ memcpy (laststr, retr->str, retr->len);
+ free (retr->str);
+ retr->str = NULL;
+ retr->len = 0;
+
if (spot && spot->flag)
{
offset += spot->offset + 1; /* started search one character
ahead of offset */
cursor_y = 1;
cursor_x = mappos (offset & M_0x0F);
- if (laststr)
- free (laststr);
- laststr = malloc (retr->len + 1);
- memset (laststr, 0x00, retr->len + 1);
- memcpy (laststr, retr->str, retr->len);
- free (retr->str);
- retr->str = NULL;
- retr->len = 0;
}
else
{
only in patch2:
unchanged:
--- ncurses-hexedit-0.9.7.orig/config.log
+++ ncurses-hexedit-0.9.7/config.log
@@ -0,0 +1,5 @@
+This file contains any messages produced by compilers while
+running configure, to aid debugging if configure makes a mistake.
+
+configure:557: checking for a BSD compatible install
+configure:610: checking whether build environment is sane
--- End Message ---
--- Begin Message ---
Source: ncurses-hexedit
Source-Version: 0.9.7-14.1
We believe that the bug you reported is fixed in the latest version of
ncurses-hexedit, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 536...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Gilbert <mgilb...@debian.org> (supplier of updated ncurses-hexedit
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 30 Oct 2012 21:03:18 +0000
Source: ncurses-hexedit
Binary: ncurses-hexedit
Architecture: source amd64
Version: 0.9.7-14.1
Distribution: unstable
Urgency: medium
Maintainer: Manfred Lichtenstern <manf...@lichtenstern.biz>
Changed-By: Michael Gilbert <mgilb...@debian.org>
Description:
ncurses-hexedit - Edit files/disks in hex, ASCII and EBCDIC
Closes: 536736
Changes:
ncurses-hexedit (0.9.7-14.1) unstable; urgency=medium
.
* Non-maintainer upload.
* Fix segflault when searching for text that isn't in the file being viewed
(closes: #536736)
- Patch thanks to Steven Burke.
Checksums-Sha1:
42d15f57e152304d6be49030ef40676a3065d701 2454 ncurses-hexedit_0.9.7-14.1.dsc
3112ca0c11cd43d1bf4942dac03bbfbaee669257 24501
ncurses-hexedit_0.9.7-14.1.diff.gz
e9d140bbb4720be1eff873d36bc0750dad6e3be3 72060
ncurses-hexedit_0.9.7-14.1_amd64.deb
Checksums-Sha256:
2cffbd13ca43c48555de8dfb25befdcc1d1be68dbc5630e0595c914b560d1bd2 2454
ncurses-hexedit_0.9.7-14.1.dsc
cc368147e77bbe5d52f74fe1bac825e7159287d5751bf4458fba3be8ebe4b8f1 24501
ncurses-hexedit_0.9.7-14.1.diff.gz
ccd153f176d21f7fe3d3f10c1b27de0eec16aae5e6606ab5f0ef6522e920ca62 72060
ncurses-hexedit_0.9.7-14.1_amd64.deb
Files:
1c7f1df81947360734c4412b15a588f0 2454 editors optional
ncurses-hexedit_0.9.7-14.1.dsc
a486741ba8e7964e9e279208dd2a10c8 24501 editors optional
ncurses-hexedit_0.9.7-14.1.diff.gz
eee091ba276c046f50acd1b56ba5eeb5 72060 editors optional
ncurses-hexedit_0.9.7-14.1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQQcBAEBCAAGBQJQkEFTAAoJELjWss0C1vRzhPIf/0vqfaLJPPkIDT4CRSDeYHin
WRrKP859hty9KWIlMmzRsWbWFCCqNIzYb3Mt4y6CqFPhEZyj37MVeD8ngqv82Xo8
kXgDjCVSpG8zpaK0LRSL5XWZ744oCYrROc5Z/UCcirl2NP9DjxSiXQAfSsOXAb4Z
x6AZilf9TEPftECKRCW2Hv++Df+ftfqQ4jVs8T6G3DhjNdqN1+kzw7aVL57Px1F5
+OYbWKJ4exF5d1ay/Qm/r/5M6sFDW41nLBFQ/Kqr/dJPO3Vqioc1aMpWNFU6oZMD
ToYOj8XEkoPglT6Y/dEHSUvOuBMfv2KM7J9D4xTZT0AY7as84hApEidaYA68mlR1
QjsdUM08SYmpUuzFIUCu47lSpq7hISqRzCybCHDJtNe+v5LkAi8V03Lq+mrU2Er7
kEP00ytV0Auu3HAUd4wPh9lcEYk6MRI0nURqbuzkwDO3yJFzgXgGswFPSz24ohrH
tTpTd158QrpEAhh+TmvFa/pFt+5ZBOs/9Ad+q6T0s5SOtTMx8SM4ST/OPYAPGUX7
pO671PKSeFcxn5THIYsXyCVdk8OxBFmrEN4WXkyPMSMdzzZNhDVPTelsMF1UfHz3
IMlN8ViQbN28ejcsLCZ5U667O2U5iswYmwD5ANjbn4204/SOMcslh3/96JqvvbGP
NmLsoyPmv4n7nDj+HC8zqY6GQzKlF8HcjmInQmFKyPKfpJneygzSjgZYUjCqrZUf
Dv8ygqhTn+ZfTWmdh1erOqm2hqyN4nUmqVLUJchuPiZvQcP/oJE1XBqhra17FBxI
gUJe0x/GN0P6ZdGX5EdOQfwBSoQfCC+BSA0AhsEnZOG5OtFPSmEqr6SPns9OL8uA
hztXn7QDtr7RucuDLX1ANTIJn8Be9UBlPvGpULlXcp4o8t0H9Y0mr9QGPTv/NUVg
Yq+gRB7DAzEUZnnqctUKLLzauIuZ9qs2df73X51e4v7UJQ/x2a9E7e5jzCc0u/2M
4svREMMilu595dNZxRzLzW3jBmbY2pbTgNugKQ/PvVSbiZR7a9lzbq/Yw9pf5KYC
J7EPCLB3/UzZtRikpPKtEqGNnNRQ87QHVjaVSCpGjRarOGwB4XDnKt8kgsvhbpxd
DVv4gPnrKVDe5SpCvzEq9Nb4KqAFlcHqK0vOTC+gHsg5hR5brbK5OWR9ETSAiqrV
v8HyRgO0JgsAyg3cx36mNU5D/2OOsF+NoJkNg22TvbB04wFX0Rbl7Mb/8LXvTDS/
P6Gpw25JIEioTUKcCOisHimbgnYlAM1UxXFrVrBqPsNKcSjKJMxHVUP6/lzwPPF5
6USNIEMK4RyGjOb0qbniVIR/qxxR99mwxZGUWEYyKy3DvqZomiuGM1VIjkTcAOE=
=Emfp
-----END PGP SIGNATURE-----
--- End Message ---
