On Mon, 2012-10-22 at 19:13 +0200, Arno Töll wrote:
> thanks for the report, but I noticed that already. I reported the
> problem to upstream [1] where it is fixed already in trunk and proposed
> as a backport to their stable branch for 3.2.x. Note, upstream's fix [2]
> is slightly different to yours.
> 
> You as an ARM expert, let me know if yours or theirs looks better please.
> 
> 
> [1] https://issues.apache.org/jira/browse/TS-1498
> [2]
> https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;a=commitdiff;h=a7baf7c8f1bb9206e17b9ac925e21e5beab08f56

Well, strictly speaking, mfence-type of instructions are translated to
the dmb asm instruction in armv7-a (check also
https://en.wikipedia.org/wiki/Memory_ordering and
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dai0274b/index.html 
check 3.4.7 Barriers and syncrhnization). So without wanting to sound like a 
know-it-all -I might be wrong and there might be a reason for defining them as 
no-ops- I think my patch is more correct.

Regards

Konstantinos


Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to