Your message dated Mon, 15 Oct 2012 15:02:36 +0000 with message-id <e1tnmbg-00025b...@franck.debian.org> and subject line Bug#689889: fixed in echolot 2.1.8-7 has caused the Debian Bug report #689889, regarding Ships a folder in /var/run or /var/lock (Policy Manual section 9.3.2) to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 689889: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=689889 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: echolot Version: 2.1.8-6 Severity: serious Tags: patch Dear Maintainer, Andreas Beckmann <deb...@abeckmann.de> reported in -devel that your package (as well as 27 others) ships a folder either in /var/run or /var/lock. This is forbidden by policy. Lintian detects the problem and warns as follow: /var/run may be a temporary filesystem, so any directories or files needed /there must be created dynamically at boot time. Refer to Debian Policy Manual section 9.3.2 (Writing the scripts) for details. Severity: serious, Certainty: possible Check: files, Type: binary, udeb which is why I am reporting this bug with severity serious (and there fore, release critical). Please fix your package. I have attached what I believe is a good fix the problem, however, I haven't tried it, and I haven't tested if something more for creating the necessary folder at runtime should be added. Please make sure to test before applying the patch blindly. Cheers, Thomas Goirand (zigo)diff -u echolot-2.1.8/debian/changelog echolot-2.1.8/debian/changelog --- echolot-2.1.8/debian/changelog +++ echolot-2.1.8/debian/changelog @@ -1,3 +1,10 @@ +echolot (2.1.8-6.1) UNRELEASED; urgency=low + + * Non-maintainer upload. + * Fixes handling of the /var/run/echolot folder life cycle (Closes: #XXXXXX). + + -- Thomas Goirand <z...@debian.org> Sat, 06 Oct 2012 16:59:36 +0800 + echolot (2.1.8-6) unstable; urgency=low * In postrm during purge remove (rm -rf) /var/lib/echolot instead of diff -u echolot-2.1.8/debian/echolot.init echolot-2.1.8/debian/echolot.init --- echolot-2.1.8/debian/echolot.init +++ echolot-2.1.8/debian/echolot.init @@ -25,7 +25,8 @@ # You probably don't want to mess with stuff below this line ################################################################ -PIDFILE=/var/run/echolot/pingd.pid +RUNFLD=/var/run/echolot +PIDFILE=${RUNFLD}/pingd.pid CHECKULIMIT=1 CHECKUID=1 USER=echolot @@ -41,6 +42,13 @@ # Reads config file (will override defaults above) [ -r /etc/default/echolot ] && . /etc/default/echolot +if [ ! -d ${RUNFLD} ] ; then + mkdir -p ${RUNFLD} || true + if [ -d ${RUNFLD} ] ; then + chown ${USER}:${GROUP} ${RUNFLD} + chmod 02770 ${RUNFLD} + fi +fi wait_for_deaddaemon () { PID=$1 diff -u echolot-2.1.8/debian/echolot.postinst echolot-2.1.8/debian/echolot.postinst --- echolot-2.1.8/debian/echolot.postinst +++ echolot-2.1.8/debian/echolot.postinst @@ -30,10 +30,6 @@ if ( ! dpkg-statoverride --list /var/lib/echolot > /dev/null ); then dpkg-statoverride --update --add root echolot 02775 /var/lib/echolot fi -# and /var/run/echolot -if ( ! dpkg-statoverride --list /var/run/echolot > /dev/null ); then - dpkg-statoverride --update --add root echolot 02770 /var/run/echolot -fi #DEBHELPER# diff -u echolot-2.1.8/debian/echolot.postrm echolot-2.1.8/debian/echolot.postrm --- echolot-2.1.8/debian/echolot.postrm +++ echolot-2.1.8/debian/echolot.postrm @@ -6,6 +6,7 @@ purge) rm -rf /var/lib/echolot rm -rf /var/log/echolot + rm -rf /var/run/echolot rmdir /etc/echolot/templates 2>/dev/null || true rmdir /etc/echolot 2>/dev/null || true dpkg-statoverride --remove /var/run/echolot >/dev/null 2>&1 || true only in patch2: unchanged: --- echolot-2.1.8.orig/debian/echolot.dirs +++ echolot-2.1.8/debian/echolot.dirs @@ -1,7 +1,6 @@ usr/bin usr/share/perl5 var/lib/echolot -var/run/echolot var/log/echolot etc/echolot etc/default
--- End Message ---
--- Begin Message ---Source: echolot Source-Version: 2.1.8-7 We believe that the bug you reported is fixed in the latest version of echolot, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 689...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Peter Palfrader <wea...@debian.org> (supplier of updated echolot package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Mon, 15 Oct 2012 16:24:47 +0200 Source: echolot Binary: echolot Architecture: source all Version: 2.1.8-7 Distribution: unstable Urgency: low Maintainer: Peter Palfrader <wea...@debian.org> Changed-By: Peter Palfrader <wea...@debian.org> Description: echolot - Pinger for anonymous remailers such as Mixmaster Closes: 459926 459938 563810 689889 Changes: echolot (2.1.8-7) unstable; urgency=low . * No longer ship /var/run/echolot in the package. Based upon work by Thomas Goirand (closes: #689889). * Fix a markup typo in the pingd manpage. * Fix an error in README.Debian where we say /etc/default/echolot when we mean /etc/init.d/echolot. * Fix a spelling mistake in README.Debian (closes: #459926). * Fix the name of an option in an example in pingd.conf(5) (closes: #459938). * Update the address for the remops mailinglist in README.Debian (closes: #563810). Checksums-Sha1: 8ed6da5e78493ed8abbf9aa94981659c3e1da5e7 1243 echolot_2.1.8-7.dsc 28c86a918e271d4fffe31f966d899b786d75bfd4 14308 echolot_2.1.8-7.diff.gz ad68370d914d8b82825cc592bbe2814145cd0a77 88874 echolot_2.1.8-7_all.deb Checksums-Sha256: a235b4c7c477f2fbd9e908e942aa62a0244cfdbffb89b3317c9c36b0356a5d92 1243 echolot_2.1.8-7.dsc 505785e4bc52ff78d25b3b2fbc87ae9925226c992d667723c870b1b0a3b5698a 14308 echolot_2.1.8-7.diff.gz a460278d4f98dee3568a0a312e5f9ef85c9e033639066900b7142170bca5b295 88874 echolot_2.1.8-7_all.deb Files: 2a1f6182cc1edef9010012762c0b8a48 1243 mail extra echolot_2.1.8-7.dsc 4476b49f5c874d4b1b28b3c1bddfe69e 14308 mail extra echolot_2.1.8-7.diff.gz bfc17c2e22b1940700847f54ad1018c9 88874 mail extra echolot_2.1.8-7_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQEcBAEBCAAGBQJQfCD+AAoJEDTSCgbh3sV3Y2MH/32ffSmVxVjGWznef8WPlT6k ByXv9M1/3xN4mAeABRr9M31ktF8tu5TvSaVP3kcJFxe2MWP8h9IFPA5Qe152lDL6 lSQZkTMOoHPUGuWDoaRoVIDP4HTyM5a3S7E10QHz1AxgcntgMQK3yoxFS9DV8AdJ NGoweZoubpjNXIIpclF7noI6bVfOAuPKkOcvXmj5dYqgwRHIWu7IZY8UFTMHd4a6 mpzOiBmG+Ygo9GoPgzIK1t2gVuv1tYzGp2soI3KdGk0NY+PS6jbAV5saMPfaVit4 UycMJsPLdAwVfO6d5Ao8Oq2qx694gUCP8EX4vWPSsNpFHUuum595EbnvnwdIv58= =WCK2 -----END PGP SIGNATURE-----
--- End Message ---
