Control: tags -1 + pending Dear Maintainers,
Andreas Beckmann <deb...@abeckmann.de> writes: > Package: timidity-daemon > Version: 2.13.2-40 > Severity: serious > User: debian...@lists.debian.org > Usertags: piuparts > > during a test with piuparts I noticed your package mishandles conffiles. > This is violates the policy, see > http://www.debian.org/doc/debian-policy/ch-files.html#s-config-files > > I miserably failed to understand that the maintainer scripts were to do, > the only thing I can say for sure is that the conffile > /etc/init.d/timidity is removed during the remove step of the package > (which is wrong, because configuration must be preserved after remove, > and needs to be clened up during purge only. > > And that will fail in the following scenario: > > install timidity-daemon > remove (don't purge!) timidity-daemon > install timidity-daemon > > Now /etc/init.d/timidity is missing (as dpkg will not restore deleted > configuration files as that is usually a user choice the should be > preserved). I have uploaded to DELAYED/2 a NMU of timidity versioned 2.13.2-40.1 which fixes that bug. The debdiff is attached. Don't hesitate to tell me if I should delay the upload longer. Guo: Thanks for your contribution. I did not directly upload your patch for two reasons. First it was buggy since it was removing the call to "invoke-rc.d timidity stop" in "prerm remove", and this call has to stay there. Second it was making unnecessary changes related to /etc/timidity/timidity.daemon, which is no longer shipped in the package (it seems to predate squeeze); NMUs have to change the minimal amount of code in order to fix the bug. But indeed, as Andreas has noted, a lot of obsolete stuff could probably be removed from the maintainer scripts.
diff -Nru timidity-2.13.2/debian/changelog timidity-2.13.2/debian/changelog
--- timidity-2.13.2/debian/changelog 2011-11-21 17:14:10.000000000 +0100
+++ timidity-2.13.2/debian/changelog 2012-10-11 20:11:33.000000000 +0200
@@ -1,3 +1,11 @@
+timidity (2.13.2-40.1) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * No longer remove /etc/init.d/timidity in timidity-daemon's "prerm remove".
+ Thanks to Guo Yixuan for digging into this issue. (Closes: #688713)
+
+ -- Sébastien Villemot <sebast...@debian.org> Thu, 11 Oct 2012 20:08:58 +0200
+
timidity (2.13.2-40) unstable; urgency=low
* New maintainer (Closes: #585039).
diff -Nru timidity-2.13.2/debian/timidity-daemon.prerm timidity-2.13.2/debian/timidity-daemon.prerm
--- timidity-2.13.2/debian/timidity-daemon.prerm 2009-09-11 12:44:23.000000000 +0200
+++ timidity-2.13.2/debian/timidity-daemon.prerm 2012-10-11 20:02:36.000000000 +0200
@@ -30,7 +30,6 @@
fi
fi
- rm_conffile timidity-daemon /etc/init.d/timidity
rm_conffile timidity-daemon /etc/timidity/timidity.daemon
;;
-- .''`. Sébastien Villemot : :' : Debian Developer `. `' http://www.dynare.org/sebastien `- GPG Key: 4096R/381A7594
pgpNS5buQaa7Z.pgp
Description: PGP signature
