Your message dated Mon, 08 Oct 2012 14:30:36 +0000
with message-id <e1tlels-0000ik...@franck.debian.org>
and subject line Bug#689904: fixed in tetrinetx 1.13.16-14
has caused the Debian Bug report #689904,
regarding Ships a folder in /var/run or /var/lock (Policy Manual section 9.3.2)
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
689904: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=689904
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: tetrinetx
Version: 1.13.16-13
Severity: serious
Tags: patch
Dear Maintainer,
Andreas Beckmann <deb...@abeckmann.de> reported in -devel that your package
(as well as 27 others) ships a folder either in /var/run or /var/lock. This
is forbidden by policy.
Lintian detects the problem and warns as follow:
/var/run may be a temporary filesystem, so any directories or files needed
/there must be created dynamically at boot time.
Refer to Debian Policy Manual section 9.3.2 (Writing the scripts) for
details.
Severity: serious, Certainty: possible
Check: files, Type: binary, udeb
which is why I am reporting this bug with severity serious (and there fore,
release critical).
Please fix your package. I have attached what I believe is a good fix the
problem, however, I haven't tried it, and I haven't tested if something more
for creating the necessary folder at runtime should be added. Please make
sure to test before applying the patch blindly.
Cheers,
Thomas Goirand (zigo)
diff -u tetrinetx-1.13.16/debian/dirs tetrinetx-1.13.16/debian/dirs
--- tetrinetx-1.13.16/debian/dirs
+++ tetrinetx-1.13.16/debian/dirs
@@ -1,5 +1,4 @@
etc/tetrinetx
usr/games
-var/run/tetrinetx
var/log/tetrinetx
var/games/tetrinetx
diff -u tetrinetx-1.13.16/debian/rules tetrinetx-1.13.16/debian/rules
--- tetrinetx-1.13.16/debian/rules
+++ tetrinetx-1.13.16/debian/rules
@@ -3,7 +3,6 @@
CFLAGS=-O2 -DUSE_IPV6 -fno-strength-reduce -Wall -fsigned-char -I/usr/include -L/usr/lib
DESTDIR=$(CURDIR)/debian/tetrinetx/
OWNDIRS= $(DESTDIR)var/games/tetrinetx \
- $(DESTDIR)var/run/tetrinetx \
$(DESTDIR)var/log/tetrinetx \
$(DESTDIR)etc/tetrinetx
diff -u tetrinetx-1.13.16/debian/init tetrinetx-1.13.16/debian/init
--- tetrinetx-1.13.16/debian/init
+++ tetrinetx-1.13.16/debian/init
@@ -13,8 +13,9 @@
NAME="tetrinetx"
DESC="Tetrinet Server"
-PIDF="/var/run/tetrinetx/game.pid"
-LOGF="/var/log/tetrinetx/game.log"
+RUNDIR="/var/run/tetrinetx"
+PIDF="${RUNDIR}/game.pid"
+LOGF="${RUNDIR}/game.log"
CONF="/etc/tetrinetx/game.conf"
BINX="/usr/games/tetrinetx"
@@ -30,6 +31,13 @@
fi
fi
+if [ ! -d ${RUNDIR} ] ; then
+ mkdir -p ${RUNDIR} || true
+ if [ -d ${RUNDIR} ] ; then
+ chown -R games:games ${RUNDIR}
+ fi
+fi
+
case "$ACTION" in
start|start-now)
echo -n "Starting ${DESC}: "
diff -u tetrinetx-1.13.16/debian/changelog tetrinetx-1.13.16/debian/changelog
--- tetrinetx-1.13.16/debian/changelog
+++ tetrinetx-1.13.16/debian/changelog
@@ -1,3 +1,10 @@
+tetrinetx (1.13.16-13.1) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Fixes /var/run/tetrinetx life cycle (Closes: #XXXXXX).
+
+ -- Thomas Goirand <z...@debian.org> Sat, 06 Oct 2012 22:56:18 +0800
+
tetrinetx (1.13.16-13) unstable; urgency=low
* Update homepage (Closes: #515049)
only in patch2:
unchanged:
--- tetrinetx-1.13.16.orig/debian/postrm
+++ tetrinetx-1.13.16/debian/postrm
@@ -0,0 +1,9 @@
+#!/bin/sh
+
+set -e
+
+if [ "${1}" = "purge" ] ; then
+ rm -rf /var/run/tetrinetx
+fi
+
+#DEBHELPER#
--- End Message ---
--- Begin Message ---
Source: tetrinetx
Source-Version: 1.13.16-14
We believe that the bug you reported is fixed in the latest version of
tetrinetx, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 689...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Julien Danjou <a...@debian.org> (supplier of updated tetrinetx package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Mon, 08 Oct 2012 09:59:44 +0200
Source: tetrinetx
Binary: tetrinetx
Architecture: source amd64
Version: 1.13.16-14
Distribution: unstable
Urgency: low
Maintainer: Julien Danjou <a...@debian.org>
Changed-By: Julien Danjou <a...@debian.org>
Description:
tetrinetx - game server for Tetrinet
Closes: 689904
Changes:
tetrinetx (1.13.16-14) unstable; urgency=low
.
* Do not ship /var/run directory (Closes: #689904)
Checksums-Sha1:
21bf8d27f3fc3345294fba71d3cea8322970377f 1719 tetrinetx_1.13.16-14.dsc
88a0a20aed09308916998fc4aea13e6d12f574de 10013 tetrinetx_1.13.16-14.diff.gz
ed08b46dd6fed2873440cb283af8202c7bf000dc 73550 tetrinetx_1.13.16-14_amd64.deb
Checksums-Sha256:
75c34e899727dd00866589f6ad9852b73e57093590bfbc4dc0a35ce4bd6be9ea 1719
tetrinetx_1.13.16-14.dsc
41a03b611db2ecf8831f5137f4040e89106e66766ca4cf9e316d74c70d16375f 10013
tetrinetx_1.13.16-14.diff.gz
2b4d3b791ee83942823af0867b5eba35827b619d80f3208bbfd4f999120a1298 73550
tetrinetx_1.13.16-14_amd64.deb
Files:
a3ba9be2a70b848e0bd80c8a3ecd56c2 1719 games optional tetrinetx_1.13.16-14.dsc
264d92d3e938ae30c25d137716f6c848 10013 games optional
tetrinetx_1.13.16-14.diff.gz
cea809900ee3fa33a5cb0f210c260eed 73550 games optional
tetrinetx_1.13.16-14_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBAgAGBQJQcojVAAoJEGEbqVCLeKXCeM8P/jwY4adeHqkjsCVSkre+NzFe
xaW++HfJUJRQGmHT3vsonyMdHZhd2w6wPsduFcrBCCFV8VWElpTYB+PS03gAiqRb
QJPMXl8b6UI9Kke6XcG6cHsjAghaXS6V6Roe+QQFNX1f4id7cGMJi/av1rtLhXD8
UbmPlB+B7mQhu5n+w8ifDzVbmXHf53O8FdkVJjdBLlwjIZzM89yuLbevtulYG27B
Wmg7LhfHI/MjCvrJJN8aqlZZAAXR5scmzqibuBwGMlFlU0M6XFTWTIAw8omUBd+C
DrTJWTCR0terLoDZZwFndoyvefXbSxycJ5nAocsqCSQ0/i3TRLHzDlMs52saGhyf
oEcsGRS5RiqVVP1ZyRiZx0bBifoqHqKLoQpSWL7vrxk3/9R5j2vIxEqMfdEvl8qp
fkDLdSaccC6F7+xoYpGSYEwqk0kbMRQt5rSqqPDxqBzxNdPojg5fu6Du3VRIU1uC
Oq0SAjcM0wTkOVMAl0PoMqFMhpguY3dHU2HXLckfKXU26Qn/rHu4BqEBdEEyrtpe
3No2drNF5Rqqz57byaMKIgraKsEUI8qr5cRc9UMP0GrdthDUoJWv0PGfLWtU2BiB
YwdqEVlDJJhYSVcjX2XNVPMMMp5VfT7DHUXqnYpocT/KDsNPMGxTYOk0QyO8/Cc9
WLFjk2WnijFAaaBdiVIh
=+M7R
-----END PGP SIGNATURE-----
--- End Message ---
