Package: mgetty
Version: 1.1.36-1.6
Severity: serious
Tags: patch

Dear Maintainer,

Andreas Beckmann <deb...@abeckmann.de> reported in -devel that your package
(as well as 27 others) ships a folder either in /var/run or /var/lock. This
is forbidden by policy.

Lintian detects the problem and warns as follow:

/var/run may be a temporary filesystem, so any directories or files needed
/there must be created dynamically at boot time.

Refer to Debian Policy Manual section 9.3.2 (Writing the scripts) for
details.

Severity: serious, Certainty: possible
Check: files, Type: binary, udeb

which is why I am reporting this bug with severity serious (and there fore,
release critical).

Please fix your package. I have attached what I believe is a good fix the
problem, however, I haven't tried it, and I haven't tested if something more
for creating the necessary folder at runtime should be added. Please make
sure to test before applying the patch blindly.

Cheers,

Thomas Goirand (zigo)
diff -u mgetty-1.1.36/debian/changelog mgetty-1.1.36/debian/changelog
--- mgetty-1.1.36/debian/changelog
+++ mgetty-1.1.36/debian/changelog
@@ -1,3 +1,12 @@
+mgetty (1.1.36-1.7) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Fixed the messed-up debian/copyright (Closes: #532452) and rewrote in
+  format 1.0.
+  * mgetty-fax doesn't ship /var/run/mgetty-fax anymore (Closes: #XXXXXX).
+
+ -- Thomas Goirand <z...@debian.org>  Sat, 06 Oct 2012 22:09:15 +0800
+
 mgetty (1.1.36-1.6) unstable; urgency=low
 
   * Non-maintainer upload.
diff -u mgetty-1.1.36/debian/mgetty-fax.postinst mgetty-1.1.36/debian/mgetty-fax.postinst
--- mgetty-1.1.36/debian/mgetty-fax.postinst
+++ mgetty-1.1.36/debian/mgetty-fax.postinst
@@ -54,8 +54,7 @@
 	    dpkg-statoverride --update --add $FAX_USER $FAX_GROUP 4755 /usr/lib/mgetty-fax/faxq-helper;
 	fi
 
-        for i in /var/spool/fax/outgoing /var/log/mgetty/fax \
-	    /var/run/mgetty-fax /var/lock/fax; do
+        for i in /var/spool/fax/outgoing /var/log/mgetty/fax ; do
 		if ! dpkg-statoverride --list $i >/dev/null; then
 		    dpkg-statoverride --update --add $FAX_USER root 0755 $i;
 		fi
diff -u mgetty-1.1.36/debian/copyright mgetty-1.1.36/debian/copyright
--- mgetty-1.1.36/debian/copyright
+++ mgetty-1.1.36/debian/copyright
@@ -1,32 +1,57 @@
-This is the Debian GNU/Linux prepackaged version of mgetty+sendfax
-Mgetty was written by Gert Doering <g...@greenie.muc.de>
-or <g...@space.net>
-
-You can find the source here:
-
-  ftp://alpha.greenie.net/pub/mgetty/source/
-
-This package was originally put together by:
-    Nils Rennebarth <n...@nus.pan-net.de>
-and was subsequently been maintained by:
-    Christoph Lameter, John Goerzen, and briefly Paul Haggart
-at which point Philip Hands <p...@hands.com> took over (Mid 1997).
-
-Since version 1.1.22, mgetty (and vgetty) is distributed under the GNU
-GPL. On Debian GNU/Linux systems, the text of the GPL can be found in
-the directory /usr/share/common-licenses/.
-
-In the frontends directories (/usr/share/doc/mgetty/frontends/...):
-  viewfax-2.5:
-    Copyright (C) 1990, 1995  Frank D. Cringle <f...@cliwe.ping.de>
-    Distributed under the GNU GPL (see above)
-
-  faxview-0.2:
-    Copyright (C) 1994--1996 Ralph Schleicher <r...@purple.in-ulm.de>
-    Distributed under the GNU GPL (see above)
-
-  the "rs" utilities for Emacs:
-    Copyright (C) 1995 Ralph Schleicher
-    Distributed under the GNU GPL (see above)
-
-  Many others whose distribution terms are explained in their source code...
+Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: This is the Debian GNU/Linux prepackaged version of mgetty+sendfax
+Source: ftp://alpha.greenie.net/pub/mgetty/source/
+
+Files: debian/*
+Copyright: (c) 1995, Nils Rennebarth <n...@nus.pan-net.de>
+	(c) 1996-1997, Christoph Lameter
+	(c) 1997, John Goerzen
+	(c) 1997, Paul Haggart
+        (c) 1997-2000, Philip Hands <p...@hands.com>
+	(c) 2001, Michael Stone <mst...@debian.org>
+	(c) 2001-2003, Wolfgang Sourdeau <w...@debian.org>
+	(c) 2002, Colin Walters <walt...@debian.org>
+	(c) 2003-2007, Andreas Barth <a...@not.so.argh.org>
+	(c) 2008, Petter Reinholdtsen <p...@debian.org>
+	(c) 2008, Chris Lamb <ch...@chris-lamb.co.uk>
+	(c) 2008, Nico Golde <n...@debian.org>
+	(c) 2008-2010, Christian Perrier <bubu...@debian.org>
+	(c) 2012, Thomas Goirand <z...@debian.org>
+License: GPL-2
+
+Files: frontends/www/viewfax.in, frontends/X11/viewfax/*
+Copyright (C) 1990, 1995, 2004  Frank D. Cringle <f...@cliwe.ping.de>
+License: GPL-2
+
+Files: frontends/tcl/faxview-0.2/*
+Copyright: (c) 1994--1996 Ralph Schleicher <r...@purple.in-ulm.de>
+License: GPL-2
+
+Files: frontends/emacs/rs/*
+Copyright: (c) 1995 Ralph Schleicher
+License: GPL-2
+
+Files: voice/libmgsm/*
+Copyright: 1992 by Jutta Degener and Carsten Bormann, Technische
+License: GPL-2
+
+Files: *
+Copyright: Gert Doering <g...@greenie.muc.de> or <g...@space.net>
+License: GPL-2
+
+License: GPL-2
+ This program is free software; you can redistribute it and/or modify it under
+ the terms of the GNU General Public License as published by the Free Software
+ Foundation; either version 2 of the License, or (at your option) any later
+ version.   
+ .
+ This program is distributed in the hope that it will be useful, but WITHOUT
+ ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
+ .
+ You should have received a copy of the GNU General Public License along with
+ this program; if not, write to the Free Software Foundation, Inc., 51 Franklin
+ St, Fifth Floor, Boston, MA 02110-1301 USA
+ .
+ On Debian systems, the complete text of the GNU General Public License v2
+ (GPL) can be found in /usr/share/common-licenses/GPL-2.
diff -u mgetty-1.1.36/debian/mgetty.postrm mgetty-1.1.36/debian/mgetty.postrm
--- mgetty-1.1.36/debian/mgetty.postrm
+++ mgetty-1.1.36/debian/mgetty.postrm
@@ -16,6 +16,7 @@
 	done
 	rmdir /etc/mgetty || true;
         rmdir /var/spool/fax/incoming /var/spool/fax || true;
+        rmdir -rf /var/run/mgetty || true;
 	;;
     *)
 	;;
diff -u mgetty-1.1.36/debian/mgetty-fax.init.d mgetty-1.1.36/debian/mgetty-fax.init.d
--- mgetty-1.1.36/debian/mgetty-fax.init.d
+++ mgetty-1.1.36/debian/mgetty-fax.init.d
@@ -27,7 +27,7 @@
 	chown uucp:root /var/lock/fax
 fi
 if [ ! -d /var/run/mgetty-fax ]; then
-	mkdir /var/run/mgetty-fax
+	mkdir -p /var/run/mgetty-fax
 	chown uucp:root /var/run/mgetty-fax
 fi
 
diff -u mgetty-1.1.36/debian/mgetty-fax.dirs mgetty-1.1.36/debian/mgetty-fax.dirs
--- mgetty-1.1.36/debian/mgetty-fax.dirs
+++ mgetty-1.1.36/debian/mgetty-fax.dirs
@@ -9,3 +9 @@
-var/lock/fax
 var/log/mgetty/fax
-var/run/mgetty-fax

Reply via email to