Salvatore Bonaccorso <car...@debian.org> writes: > On Sun, Sep 02, 2012 at 10:16:09AM +0200, Sylvestre Ledru wrote: >> Le 01/09/2012 13:33, Salvatore Bonaccorso a écrit :
>> > A rebuild of the libmatio-doc would suffice here, as Sebastien noted. >> > Is it fine for you to upload a 'no changes' upload or would you like >> > to do it yourself? >> > >> > This would fix RC bug #685694. >> > >> OK. Sounds great. :) (even if I don't like "no-changes" upload when I >> don't know why it failed before ... >> >> Don't hesitate to NMU with a 0 delay (or I can do the upload, no worries) > > Before I did an NMU upload I tested now the 4 build-rdeps of > libmatio-dev: scilab, dynare, vips and openmeeg. > > I get a FTBFS for openmeeg (failing tests) with a rebuilded libmatio. The cause of the FTBFS is a bug in libmatio 1.3.4-3, more precisely an illegal read. The bug is already present in the current sid binary, but only triggers a crash after a recompilation (probably because of compiler changes). I attach a testcase: a C program and a MAT file (taken from openmeeg testsuite). When this test is run against the current libmatio, valgrind detects an illegal read, but the program does not crash. When run against a recompiled libmatio, the program crashes, and so does openmeeg testsuite. The good news is that this bug has been fixed upstream on the 1.3 branch, but has never been released since the stable branch is now 1.5: http://matio.git.sourceforge.net/git/gitweb.cgi?p=matio/matio;a=commit;h=4b096356fda6973b404218bb7536b7267641fc55 Note that libmatio 1.5 currently in experimental is not affected. Sylvestre: how do you want to proceed? I can do a team upload with this patch incorporated. That would fix the libmatio-doc RC bug without introducing an FTBFS on other packages. Best,
#include <assert.h> #include <matio.h> int main() { mat_t *mt = Mat_Open("Head1.mat", MAT_ACC_RDONLY); assert(mt); matvar_t *matvar; while (matvar = Mat_VarReadNext(mt)) { } Mat_Close(mt); }
Head1.mat
Description: Binary data
-- .''`. Sébastien Villemot : :' : Debian Developer `. `' http://www.dynare.org/sebastien `- GPG Key: 4096R/381A7594
pgpZXmJ6g0Iws.pgp
Description: PGP signature