On 2012-09-28 08:25 +0200, أحمد المحمودي wrote:

> On Fri, Sep 28, 2012 at 08:54:30AM +0900, Kenshi Muto wrote:
>> mlterm is mostly maintained by Ahmed.
>> Ahmed, could you tell me what you think about?
>
>   Well, it is the same fix that was done in 3.1.2-1.1 for mlterm & 
>   mlterm.tiny
>
>   Yet I think it is better to do the fix in .preinst instead of 
>   .postinst as the file attached.
>
>   Note that I didn't test that fix yet.

I am afraid that your proposed fix will not work correctly.

> #!/bin/sh
> set -e
>
> case "$1" in
>     install|upgrade)
>         if dpkg --compare-versions "$2" lt "3.0.9" ; then

People who had already upgraded from earlier versions will still have an
empty directory, so the version should be adjusted.

>           rmdir /usr/share/doc/mlterm

The directory is not guaranteed to be empty at this time.  Also, you
want to protect this with "|| true" to make the script idempotent
(see Policy §6.2).

Cheers,
       Sven


--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to