package src:rhash
tags 687398 - unreproducible
thanks

> I could not reproduce this bug, either with cowbuilder or sbuild.
> 
> Please find enclosed my build log with sbuild and the diff against the
> one attached to the bug report.
Thanks for the diff, it helped a lot. Your difference is that you don't
use the parallel build while Lucas does. The upstream Makefiles
are broken wrt recursive parallel make invocations in several places, as
they call just 'make', see
http://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html
Also, the package rules file tries to be smarter than the upstream build
system by passing SHARED_TRG=rhash, thus effectively breaking it: the
top-level Makefile contains a "$(TARGET):" rule, that expands to "rhash"
and builds a "rhash" static binary, and a "rhash-shared" rule that builds
a "$(SHARED_TRG)" ("rhash_shared" by default) shared binary. For reasons
that I don't want to investigate this leads to a shared "rhash" binary
being built with -j1 (which was apparently the maintainer's intent) but a
static "rhash" binary built with -jN, which not only would overwrite the
intended shared binary, but also fails to link (this seems to be a good
thing, actually).

I suggest either heavy patching of the upstream build system or yielding
to it and renaming the binaries after the building.

I also don't get +$(MAKE) commands in debian/rules, that seems excessive.

-- 
WBR, wRAR

Attachment: signature.asc
Description: Digital signature

Reply via email to