package ruby-mocha tag 684860 - unreproducible tag 684860 pending thanks Hi!
Here is a recipe to reproduce the bug:
force the order of the tests run so that
test/acceptance/minitest_test.rb appears first, by adding
require "test/acceptance/minitest_test"
at the top of the file debian/ruby-tests.rb.
The problem is caused a patch (of mine... ) that loaded minitest/unit
unconditionally in test/acceptance/minitest_test.rb, whereas it was
supposed to be conditioned on the prior definition of MiniTest.
I am therefore modifying this patch and preparing an upload.
Attached is the diff I'm proposing.
Cheers,
Cédric
diff -Nru ruby-mocha-0.11.3/debian/changelog ruby-mocha-0.11.3/debian/changelog
--- ruby-mocha-0.11.3/debian/changelog 2012-06-27 00:01:49.000000000 +0200
+++ ruby-mocha-0.11.3/debian/changelog 2012-09-11 22:10:40.000000000 +0200
@@ -1,3 +1,12 @@
+ruby-mocha (0.11.3-3) UNRELEASED; urgency=low
+
+ * Modify remove_rubyges_stuff_in_minitest_test.patch to restore
+ loading of minitest/unit conditional to the definition of MiniTest.
+ Loading minitest/unit before Minitest is defined screens the definition of
+ TestUnitResult, causing tests to fail (Closes: #684860).
+
+ -- Cédric Boutillier <cedric.boutill...@gmail.com> Tue, 11 Sep 2012 17:29:15 +0200
+
ruby-mocha (0.11.3-2) unstable; urgency=low
* Bump the build-dependency on gem2deb to >= 0.3.0~ (closes: #674388).
diff -Nru ruby-mocha-0.11.3/debian/patches/remove_rubygems_stuff_in_minitest_test.patch ruby-mocha-0.11.3/debian/patches/remove_rubygems_stuff_in_minitest_test.patch
--- ruby-mocha-0.11.3/debian/patches/remove_rubygems_stuff_in_minitest_test.patch 2012-04-22 18:44:01.000000000 +0200
+++ ruby-mocha-0.11.3/debian/patches/remove_rubygems_stuff_in_minitest_test.patch 2012-09-11 17:28:13.000000000 +0200
@@ -7,10 +7,7 @@
--- a/test/acceptance/minitest_test.rb
+++ b/test/acceptance/minitest_test.rb
-@@ -1,20 +1,9 @@
-+require 'minitest/unit'
- require File.expand_path('../acceptance_test_helper', __FILE__)
-
+@@ -3,12 +3,12 @@
if defined?(MiniTest)
$stderr.puts "TODO: Running suite with MiniTest, running the MiniTestAdapterTest results in an error so skipping it for now."
else
@@ -20,12 +17,12 @@
- rescue Gem::LoadError
- # MiniTest gem not available
- end
--
-- begin
-- require 'minitest/unit'
-- rescue LoadError
-- # MiniTest not available
-- end
-
- if defined?(MiniTest)
++# begin
++# require 'rubygems'
++# gem 'minitest'
++# rescue Gem::LoadError
++# # MiniTest gem not available
++# end
+ begin
+ require 'minitest/unit'
signature.asc
Description: Digital signature
