Control: tag -1 + confirmed patch On Sat, 21 Jul 2012 23:47:36 +0200, Motiejus Jakštys wrote:
> Package: git-annex > Version: 3.20120614~bpo60+1 > Severity: serious > Justification: fails to build from source > > > Building git-annex in pbuilder on squeeze having backports.debian.org > repository enabled yields this error: FWIW: I tried with the current version from backports (3.20120629~bpo60+1) in a cowbuilder squeeze+backports chroot, and the tests also fail for me. If I then run "debian/rules build" or "make test" in the chroot manually, the tests pass. I can only guess that the difference is that p/cowbuilder use the fancy user/id pbuilder/1234 for building?! The version in unstable (3.20120825) in a sid cowbuilder chroot fails too, with slightly different errors but also between blackbox init and blackbox add: #v+ Testing 1:blackbox:0:git-annex init Testing 1:blackbox:1:git-annex add:0 Testing 1:blackbox:1:git-annex add:1 Cases: 54 Tried: 16 Errors: 0 Failures: 0 *** Please tell me who you are. Run git config --global user.email "y...@example.com" git config --global user.name "Your Name" to set your account's default identity. Omit --global to set the identity only in this repository. fatal: empty ident <git-annex test <t...@example.com>> not allowed ### Failure in: 1:blackbox:1:git-annex add:1 git annex init failed Testing 1:blackbox:1:git-annex add:2 Cases: 54 Tried: 17 Errors: 0 Failures: 1 #v- [and so on ...] The version in testing (3.20120629) in a wheezy cowbuilder chroot fails like 3.20120825. Long debugging session told short: p/cowbuilder don't set a name for their builduser, which makes git explode (the "fatal: empty ident" errors). Solution: set GIT_AUTHOR_NAME _and_ GIT_COMMITTER_NAME in test.hs (additionally to EMAIL; or GIT_AUTHOR_EMAIL and GIT_COMMITTER_EMAIL instead of EMAIL). Or run dh_auto_test with GIT_AUTHOR_NAME and GIT_COMMITTER_NAME set in d/rules. Both solutions tested with the version in sid. (And attached.) Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Ludwig Hirsch: Der Turm
diff -Nru git-annex-3.20120825/debian/rules git-annex-3.20120825.fixored/debian/rules
--- git-annex-3.20120825/debian/rules 2012-07-17 19:54:56.000000000 +0200
+++ git-annex-3.20120825.fixored/debian/rules 2012-09-06 19:41:46.070734988 +0200
@@ -2,6 +2,11 @@
%:
dh $@
+override_dh_auto_test:
+ GIT_AUTHOR_NAME="git-annex test" \
+ GIT_COMMITTER_NAME="git-annex test" \
+ dh_auto_test
+
# Not intended for use by anyone except the author.
announcedir:
@echo ${HOME}/src/git-annex/doc/news
diff -Nru git-annex-3.20120825/test.hs git-annex-3.20120825.fixored/test.hs --- git-annex-3.20120825/test.hs 2012-08-25 15:59:46.000000000 +0200 +++ git-annex-3.20120825.fixored/test.hs 2012-09-06 19:45:20.822727310 +0200 @@ -881,8 +881,11 @@ setEnv "PATH" (cwd ++ ":" ++ p) True setEnv "TOPDIR" cwd True -- Avoid git complaining if it cannot determine the user's email - -- address. - setEnv "EMAIL" "git-annex test <t...@example.com>" True + -- address, or exploding if it doesn't know the user's name. + setEnv "GIT_AUTHOR_EMAIL" "t...@example.com" True + setEnv "GIT_AUTHOR_NAME" "git-annex test" True + setEnv "GIT_COMMITTER_EMAIL" "t...@example.com" True + setEnv "GIT_COMMITTER_NAME" "git-annex test" True changeToTmpDir :: FilePath -> IO () changeToTmpDir t = do
signature.asc
Description: Digital signature
