Hi, On Wed, Jul 11, 2012 at 08:01:41PM +0200, Evgeni Golov wrote: > I have prepared a (trivial) patch, which is attached and solves the > issue. No intent to NMU right now.
Thanks for the patch! Please don't NMU since I've got some other stuff that should be fixed. I'll take care of that shortly. > --- collectd-5.1.0/debian/collectd-core.collectd.init.d > +++ collectd-5.1.0/debian/collectd-core.collectd.init.d > @@ -50,12 +50,12 @@ > . /etc/default/$NAME > fi > > -if test "$DISABLE" != 0 -a "$1" == "start"; then > +if test "$DISABLE" != 0 -a \( "$1" == "start" -o "$1" == "restart" \); then > log_warning_msg "Not starting $DESC, disabled by /etc/default/$NAME." > exit 0 > fi Hrm, on "restart" should the daemon be stopped in that case? Imho, "restart" is meant to be something like "apply the current configuration" and disabling the daemon is kind of a configuration setting, so I'd go for stopping collectd. > -if test ! -e "$CONFIGFILE" -a "$1" == "start"; then > +if test ! -e "$CONFIGFILE" -a \( "$1" == "start" -o "$1" == "restart" \); > then > log_warning_msg "Not starting $DESC, no configuration ($CONFIGFILE) > found." > exit 0 > fi Basically the same applies here as well. Cheers, Sebastian -- Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/ Those who would give up Essential Liberty to purchase a little Temporary Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin
signature.asc
Description: Digital signature
