On Mon, Jul 02, 2012 at 10:00:26PM +0200, Christoph G. Baumann wrote: >Hello Steve,
Hi Christoph! >it seems we committed fixes more or less at the same time. Yup, Murphy's Law in action... :-) >I studied your patch but did not see the point. The makefiles in the >subdirectories inherit the CFLAGS and CXXFLAGS from the top level >makefile which already contains dpkg-buildflags calls. If you look at the build output, you can see that (e.g.) maclib and screenlib are *not* using the hardening flags. Look for -Wformat in the output. This tells me that the flags are not being inherited. In fact, for your own changes I can see you've added -fPIC in all of the Makefile.in instances directly to make sure they get applied...! >The problem on armhf seems to be a missing -fPIC which is not >injected by dpkg-buildflags. I added this flag in my last upload. The -fPIC is one way of fixing it; simply making sure all the objects are built with a consistent set of flags (by forcing the use of dpkg-buildflags everywhere) is another. Curious: have you checked that the hardening options have worked on all the binaries? >BTW: Did you test building on armhf? Yes, and it worked. That's what I uploaded - armhf and source. -- Steve McIntyre, Cambridge, UK. st...@einval.com < liw> everything I know about UK hotels I learned from "Fawlty Towers" -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
