Your message dated Tue, 22 May 2012 07:47:26 +0000
with message-id <e1swjou-0000tn...@franck.debian.org>
and subject line Bug#673434: fixed in dssp 2.0.4-2
has caused the Debian Bug report #673434,
regarding dssp: ftbs with gcc-4.7
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
673434: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=673434
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: dssp
Version: 2.0.4-1
Severity: serious
User: debian-...@lists.debian.org
Usertags: ftbfs-gcc-4.7
Tags: patch

dssp fails to build with gcc-4-7 in unstable:

g++ -MD -c -o obj/utils.o src/utils.cpp -g -O2 -fstack-protector
--param=ssp-buffer-size=4 -Wformat -Werror=format-security -iquote src
-g -Wall -Wno-multichar -pthread -O3 -DUSE_COMPRESSION -DLINUX
-DVERSION='"2.0.4"' -DNDEBUG
In file included from src/primitives-3d.cpp:17:0:
src/matrix.h: In instantiation of 'matrix<T> operator-(const
matrix_base<T>&, const matrix_base<T>&) [with T = double]':
src/primitives-3d.cpp:336:25:   required from here
src/matrix.h:313:79: error: 'min' was not declared in this scope, and no
declarations were found by argument-dependent lookup at the point of
instantiation [-fpermissive]
In file included from /usr/include/c++/4.7/algorithm:62:0,
                 from /usr/include/c++/4.7/valarray:40,
                 from src/primitives-3d.cpp:10:
/usr/include/c++/4.7/bits/stl_algobase.h:233:5: note: 'template<class
_Tp, class _Compare> const _Tp& std::min(const _Tp&, const _Tp&,
_Compare)' declared here, later in the translation unit
In file included from src/primitives-3d.cpp:17:0:
src/matrix.h:313:79: error: 'min' was not declared in this scope, and no
declarations were found by argument-dependent lookup at the point of
instantiation [-fpermissive]
In file included from /usr/include/c++/4.7/algorithm:62:0,
                 from /usr/include/c++/4.7/valarray:40,
                 from src/primitives-3d.cpp:10:
/usr/include/c++/4.7/bits/stl_algobase.h:233:5: note: 'template<class
_Tp, class _Compare> const _Tp& std::min(const _Tp&, const _Tp&,
_Compare)' declared here, later in the translation unit
make[1]: *** [obj/primitives-3d.o] Error 1

attached a patch fixing the issue.
--- dssp-2.0.4.orig/src/matrix.h
+++ dssp-2.0.4/src/matrix.h
@@ -14,6 +14,7 @@
 #include <istream>
 #include <cassert>
 #include <stdexcept>
+#include <algorithm>
 
 // --------------------------------------------------------------------
 // uBlas compatible matrix types
@@ -310,7 +311,7 @@ matrix<T> operator*(const matrix_base<T>
 template<typename T>
 matrix<T> operator-(const matrix_base<T>& lhs, const matrix_base<T>& rhs)
 {
-	matrix<T> result(min(lhs.dim_m(), rhs.dim_m()), min(lhs.dim_n(), rhs.dim_n()));
+	matrix<T> result(std::min(lhs.dim_m(), rhs.dim_m()), std::min(lhs.dim_n(), rhs.dim_n()));
 	
 	for (uint32 i = 0; i < result.dim_m(); ++i)
 	{

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message ---
Source: dssp
Source-Version: 2.0.4-2

We believe that the bug you reported is fixed in the latest version of
dssp, which is due to be installed in the Debian FTP archive:

dssp-dbg_2.0.4-2_amd64.deb
  to main/d/dssp/dssp-dbg_2.0.4-2_amd64.deb
dssp_2.0.4-2.debian.tar.gz
  to main/d/dssp/dssp_2.0.4-2.debian.tar.gz
dssp_2.0.4-2.dsc
  to main/d/dssp/dssp_2.0.4-2.dsc
dssp_2.0.4-2_amd64.deb
  to main/d/dssp/dssp_2.0.4-2_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 673...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Maarten L. Hekkelman <m.hekkel...@cmbi.ru.nl> (supplier of updated dssp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 21 May 2012 10:00:00 +0200
Source: dssp
Binary: dssp dssp-dbg
Architecture: source amd64
Version: 2.0.4-2
Distribution: unstable
Urgency: low
Maintainer: Debian Med Packaging Team 
<debian-med-packag...@lists.alioth.debian.org>
Changed-By: Maarten L. Hekkelman <m.hekkel...@cmbi.ru.nl>
Description: 
 dssp       - protein secondary structure assignment based on 3D structure
 dssp-dbg   - debugging symbols for dssp
Closes: 673434
Changes: 
 dssp (2.0.4-2) unstable; urgency=low
 .
   [ Laszlo Kajan ]
   * Stick to debhelper compatibility level 7 to enable flawless
     build on Ubuntu Lucid (documented in debian/README.source)
 .
   [ Maarten L. Hekkelman ]
   * Fix for compiling with gcc 4.7, std::min (Closes: #673434)
   * Added the use of dpkg-buildflags to include hardening flags since
     debhelper is still maintained at version 7.
Checksums-Sha1: 
 82147b37c534e13701a720cc32bfc905794e3097 1592 dssp_2.0.4-2.dsc
 2006f6894a0554ed1f27550bf624f92e5a1cf014 4995 dssp_2.0.4-2.debian.tar.gz
 79c3177065ac05af5b120357f7d0ec6e5c40d395 197576 dssp_2.0.4-2_amd64.deb
 b0119184f717b0d200ffc97f64afc92a19c664a3 1652696 dssp-dbg_2.0.4-2_amd64.deb
Checksums-Sha256: 
 e7746e6f68d60f1635380d83143d590723ff257ae25d8b7ec498ddd18055a503 1592 
dssp_2.0.4-2.dsc
 0a16ed3f680761d3d079e3045e56a7c7dc48d6f56030fa4893bb6758d9d8bb93 4995 
dssp_2.0.4-2.debian.tar.gz
 977b93d7fef673638f9dd5f1788bc5453682651a9f4a0efe48d965c9e7e97303 197576 
dssp_2.0.4-2_amd64.deb
 9cbc1c5be759206c78d643a062657a90fbe40a7f847e029d3978b64c6d2a4b9f 1652696 
dssp-dbg_2.0.4-2_amd64.deb
Files: 
 08051d3458cde1e37d6198206506a60a 1592 science optional dssp_2.0.4-2.dsc
 3ef2f943340f0865fb2330e1181b5c81 4995 science optional 
dssp_2.0.4-2.debian.tar.gz
 f312c3494f4444795df6ec53ac92332d 197576 science optional dssp_2.0.4-2_amd64.deb
 a4d09015d5629f666c6823bdfc7a7859 1652696 debug extra dssp-dbg_2.0.4-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAk+7QYIACgkQYDBbMcCf01q2UQCfQkXrNtVDlWLZM6DLHxlnu/vE
iXAAn1646ECrxWaScNGlKwP0IWrCrQMF
=ByPc
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to