Your message dated Fri, 11 May 2012 04:48:51 +0000
with message-id <e1sshmd-0005pm...@franck.debian.org>
and subject line Bug#664569: fixed in pythonqt 2.0.1-1.1
has caused the Debian Bug report #664569,
regarding pythonqt: FTBFS against Qt 4.8
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
664569: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=664569
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: pythonqt
Version: 2.0.1-1
Tags: patch
User: debian-qt-...@lists.debian.org
Usertags: qt48-transition

Your package fails to build against Qt 4.8 which is currently in experimental.
The transition to unstable/testing is tracked in bug #653903.

I'm attaching a patch that fixes the build failure.
The moc code calls the emit() function of PythonQtStdDecorators but emit is 
defined to
an empty string.
So the patch defines QT_NO_KEYWORDS for moc_PythonQtStdDecorators.cxx and does
the necessary changes in PythonQtStdDecorators.h to support QT_NO_KEYWORDS.
Ideally the whole source would build without the generic Qt keywords but it 
doesn't.
The patch can be applied even before Qt 4.8 enters unstable.

Build log:

> [ 93%] Building CXX object 
> CMakeFiles/PythonQt.dir/src/gui/moc_PythonQtScriptingConsole.cxx.o
> /usr/bin/c++   -DPYTHONQT_EXPORTS -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_CORE_LIB -g 
> -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security  
> -fPIC -I/usr/include/python2.7 -I/usr/include/qt4 -I/usr/include/qt4/QtGui 
> -I/usr/include/qt4/QtCore -I/build/buildd/pythonqt-2.0.1/src    -o 
> CMakeFiles/PythonQt.dir/src/gui/moc_PythonQtScriptingConsole.cxx.o -c 
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/gui/moc_PythonQtScriptingConsole.cxx
> In file included from 
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/moc_PythonQtStdDecorators.cxx:10:0:
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/../../src/PythonQtStdDecorators.h:
>  In member function 'void PythonQtStdDecorators::static_Qt_qDebug(const 
> QByteArray&)':
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/../../src/PythonQtStdDecorators.h:83:72:
>  warning: format not a string literal and no format arguments 
> [-Wformat-security]
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/../../src/PythonQtStdDecorators.h:
>  In member function 'void PythonQtStdDecorators::static_Qt_qWarning(const 
> QByteArray&)':
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/../../src/PythonQtStdDecorators.h:85:76:
>  warning: format not a string literal and no format arguments 
> [-Wformat-security]
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/../../src/PythonQtStdDecorators.h:
>  In member function 'void PythonQtStdDecorators::static_Qt_qCritical(const 
> QByteArray&)':
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/../../src/PythonQtStdDecorators.h:87:78:
>  warning: format not a string literal and no format arguments 
> [-Wformat-security]
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/../../src/PythonQtStdDecorators.h:
>  In member function 'void PythonQtStdDecorators::static_Qt_qFatal(const 
> QByteArray&)':
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/../../src/PythonQtStdDecorators.h:89:72:
>  warning: format not a string literal and no format arguments 
> [-Wformat-security]
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/moc_PythonQtStdDecorators.cxx:
>  In static member function 'static void 
> PythonQtStdDecorators::qt_static_metacall(QObject*, QMetaObject::Call, int, 
> void**)':
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/moc_PythonQtStdDecorators.cxx:152:25:
>  error: expected unqualified-id before '(' token
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/moc_PythonQtStdDecorators.cxx:153:25:
>  error: expected unqualified-id before '(' token
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/moc_PythonQtStdDecorators.cxx:154:25:
>  error: expected unqualified-id before '(' token
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/moc_PythonQtStdDecorators.cxx:155:25:
>  error: expected unqualified-id before '(' token
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/moc_PythonQtStdDecorators.cxx:156:25:
>  error: expected unqualified-id before '(' token
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/moc_PythonQtStdDecorators.cxx:157:25:
>  error: expected unqualified-id before '(' token
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/moc_PythonQtStdDecorators.cxx:158:26:
>  error: expected unqualified-id before '(' token
> /build/buildd/pythonqt-2.0.1/obj-i686-linux-gnu/src/moc_PythonQtStdDecorators.cxx:159:26:
>  error: expected unqualified-id before '(' token
> make[3]: *** [CMakeFiles/PythonQt.dir/src/moc_PythonQtStdDecorators.cxx.o] 
> Error 1

Regards,
Felix

diff -Nru pythonqt-2.0.1/debian/patches/cmakebuildsystem.patch pythonqt-2.0.1/debian/patches/cmakebuildsystem.patch
--- pythonqt-2.0.1/debian/patches/cmakebuildsystem.patch	2011-03-10 16:19:44.000000000 +0100
+++ pythonqt-2.0.1/debian/patches/cmakebuildsystem.patch	2012-03-18 23:32:55.000000000 +0100
@@ -2,7 +2,7 @@
 ===================================================================
 --- /dev/null	1970-01-01 00:00:00.000000000 +0000
 +++ PythonQt2.0.1/CMakeLists.txt	2011-03-06 19:23:17.000000000 +0100
-@@ -0,0 +1,259 @@
+@@ -0,0 +1,266 @@
 +cmake_minimum_required(VERSION 2.8)
 +
 +#-----------------------------------------------------------------------------
@@ -240,6 +240,13 @@
 +set_target_properties(PythonQt PROPERTIES DEFINE_SYMBOL PYTHONQT_EXPORTS)
 +set_target_properties(PythonQt PROPERTIES ${PythonQt_LIBRARY_PROPERTIES})
 +
++foreach(source ${gen_moc_sources})
++  string(REGEX MATCH "PythonQtStdDecorators" match ${source})
++  if(match)
++    set_property(SOURCE ${source} PROPERTY COMPILE_FLAGS -DQT_NO_KEYWORDS)
++  endif(match)
++endforeach(source {gen_moc_sources})
++
 +#
 +# That should solve linkage error on Mac when the project is used in a superbuild setup
 +# See http://blog.onesadcookie.com/2008/01/installname-magic.html
diff -Nru pythonqt-2.0.1/debian/patches/series pythonqt-2.0.1/debian/patches/series
--- pythonqt-2.0.1/debian/patches/series	2011-03-10 16:19:44.000000000 +0100
+++ pythonqt-2.0.1/debian/patches/series	2012-03-18 23:20:37.000000000 +0100
@@ -1 +1,2 @@
 cmakebuildsystem.patch
+stddecorators_no_keywords.patch
diff -Nru pythonqt-2.0.1/debian/patches/stddecorators_no_keywords.patch pythonqt-2.0.1/debian/patches/stddecorators_no_keywords.patch
--- pythonqt-2.0.1/debian/patches/stddecorators_no_keywords.patch	1970-01-01 01:00:00.000000000 +0100
+++ pythonqt-2.0.1/debian/patches/stddecorators_no_keywords.patch	2012-03-18 23:20:44.000000000 +0100
@@ -0,0 +1,24 @@
+--- pythonqt-2.0.1.orig/src/PythonQtStdDecorators.h
++++ pythonqt-2.0.1/src/PythonQtStdDecorators.h
+@@ -56,16 +56,20 @@ class PYTHONQT_EXPORT PythonQtStdDecorat
+ {
+   Q_OBJECT
+ 
+-public slots:
++public Q_SLOTS:
+   bool connect(QObject* sender, const QByteArray& signal, PyObject* callable);
+   bool connect(QObject* sender, const QByteArray& signal, QObject* receiver, const QByteArray& slot);
+   bool disconnect(QObject* sender, const QByteArray& signal, PyObject* callable);
+   bool disconnect(QObject* sender, const QByteArray& signal, QObject* receiver, const QByteArray& slot);
+ 
++#ifndef QT_NO_KEYWORDS
+ #undef emit
++#endif
+   void emit(QObject* sender, const QByteArray& signal, PyObject* arg1 = NULL,PyObject* arg2 = NULL,
+             PyObject* arg3 = NULL,PyObject* arg4 = NULL,PyObject* arg5 = NULL,PyObject* arg6 = NULL,PyObject* arg7 = NULL);
++#ifndef QT_NO_KEYWORDS
+ #define emit
++#endif
+   
+   QObject* parent(QObject* o);
+   void setParent(QObject* o, QObject* parent);

--- End Message ---
--- Begin Message ---
Source: pythonqt
Source-Version: 2.0.1-1.1

We believe that the bug you reported is fixed in the latest version of
pythonqt, which is due to be installed in the Debian FTP archive:

libpythonqt2-dev_2.0.1-1.1_i386.deb
  to main/p/pythonqt/libpythonqt2-dev_2.0.1-1.1_i386.deb
libpythonqt2.0_2.0.1-1.1_i386.deb
  to main/p/pythonqt/libpythonqt2.0_2.0.1-1.1_i386.deb
pythonqt_2.0.1-1.1.debian.tar.gz
  to main/p/pythonqt/pythonqt_2.0.1-1.1.debian.tar.gz
pythonqt_2.0.1-1.1.dsc
  to main/p/pythonqt/pythonqt_2.0.1-1.1.dsc



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 664...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Scott Kitterman <sc...@kitterman.com> (supplier of updated pythonqt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 09 May 2012 00:14:21 -0400
Source: pythonqt
Binary: libpythonqt2.0 libpythonqt2-dev
Architecture: source i386
Version: 2.0.1-1.1
Distribution: unstable
Urgency: low
Maintainer: Debian Med Packaging Team 
<debian-med-packag...@lists.alioth.debian.org>
Changed-By: Scott Kitterman <sc...@kitterman.com>
Description: 
 libpythonqt2-dev - Dynamic Python binding for the Qt framework - development
 libpythonqt2.0 - Dynamic Python binding for the Qt framework - runtime
Closes: 664569
Changes: 
 pythonqt (2.0.1-1.1) unstable; urgency=low
 .
   * Non-maintainer upload.
   * Fix FTBFS with Qt 4.8 (Closes: #664569)
     - Add debian/patches/stddecorators_no_keywords.patch
     - Extend debian/patches/cmakebuildsystem.patch to compile with
       -DQT_NO_KEYWORDS
     - Thanks to Felix Geyer for the patch
Checksums-Sha1: 
 dc223794fe28d26fad21c85cfd7ea58a3fef2b23 1524 pythonqt_2.0.1-1.1.dsc
 69b0fc99cea2dcf93d279f4102dd223b3ed83081 6686 pythonqt_2.0.1-1.1.debian.tar.gz
 7d4a8746141eb98a94e520bfa2c3c08febb07279 830344 
libpythonqt2.0_2.0.1-1.1_i386.deb
 6c08376b46d013de6e8b38867c8302461d5c42d9 32666 
libpythonqt2-dev_2.0.1-1.1_i386.deb
Checksums-Sha256: 
 a5de3f6e4426045fb5edcc33f15aaaa36a23ea172c739e4cf52e8333724fb2e4 1524 
pythonqt_2.0.1-1.1.dsc
 31c5c1e13b7f6f894bb1edeab9137bbab09f5ae56f16046f152b23281b7aafaf 6686 
pythonqt_2.0.1-1.1.debian.tar.gz
 2a457e5735bb2d37da70bcd783d1145ca7e748faa428219772058f2ec5040d3f 830344 
libpythonqt2.0_2.0.1-1.1_i386.deb
 c3d373a63eaceb882d89debcbf23ca5bd82fbb9aa6b757b25b9f1affa375d0ec 32666 
libpythonqt2-dev_2.0.1-1.1_i386.deb
Files: 
 e5a80213a4a2864642d33356010c8a09 1524 libs optional pythonqt_2.0.1-1.1.dsc
 d7558e138dcee5b565400211181d05f0 6686 libs optional 
pythonqt_2.0.1-1.1.debian.tar.gz
 c1e031aaf374d358036348e1e6ed4f9d 830344 libs optional 
libpythonqt2.0_2.0.1-1.1_i386.deb
 584b6082e7a4f7b4d744dc5af33b9aea 32666 libdevel optional 
libpythonqt2-dev_2.0.1-1.1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk+p8d4ACgkQHajaM93NaGoyhACfYz2rP9LZa4GSX6Py5DVs6auk
SRUAn1HvQyz87rdHYvVaYZpFBniCyLOD
=COeA
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to